[edk2] [patch V2 0/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues

Dandan Bi posted 2 patches 6 years, 6 months ago
Failed in applying to current master (apply log)
.../UefiShellAcpiViewCommandLib/AcpiParser.c       | 174 +++++++++-------
.../UefiShellAcpiViewCommandLib/AcpiParser.h       | 223 ++++++++++++---------
.../UefiShellAcpiViewCommandLib/AcpiTableParser.c  |  77 +++----
.../UefiShellAcpiViewCommandLib/AcpiTableParser.h  |  39 ++--
.../Library/UefiShellAcpiViewCommandLib/AcpiView.c | 113 +++++++----
.../Library/UefiShellAcpiViewCommandLib/AcpiView.h |  69 ++++---
.../Parsers/Bgrt/BgrtParser.c                      |  12 +-
.../Parsers/Dbg2/Dbg2Parser.c                      |  34 ++--
.../Parsers/Dsdt/DsdtParser.c                      |   7 +-
.../Parsers/Fadt/FadtParser.c                      |  68 +++++--
.../Parsers/Gtdt/GtdtParser.c                      |  57 ++++--
.../Parsers/Iort/IortParser.c                      | 159 ++++++++-------
.../Parsers/Madt/MadtParser.c                      |  67 ++++---
.../Parsers/Mcfg/McfgParser.c                      |  18 +-
.../Parsers/Rsdp/RsdpParser.c                      |  42 ++--
.../Parsers/Slit/SlitParser.c                      |  61 +++---
.../Parsers/Spcr/SpcrParser.c                      |  42 ++--
.../Parsers/Srat/SratParser.c                      |  82 +++++---
.../Parsers/Ssdt/SsdtParser.c                      |   7 +-
.../Parsers/Xsdt/XsdtParser.c                      |  11 +-
.../UefiShellAcpiViewCommandLib.c                  |  18 +-
.../UefiShellAcpiViewCommandLib.h                  |   4 +-
.../UefiShellAcpiViewCommandLib.inf                |   3 +
23 files changed, 823 insertions(+), 564 deletions(-)
[edk2] [patch V2 0/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues
Posted by Dandan Bi 6 years, 6 months ago
ECC tool report some coding style issue in UefiShellAcpiViewCommandLib.
This patch series is to clean these issues.

V2: Remove the updates of guard macros in header files in patch 2.

Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Evan Lloyd <evan.lloyd@arm.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>

Dandan Bi (2):
  ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues
  ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues

 .../UefiShellAcpiViewCommandLib/AcpiParser.c       | 174 +++++++++-------
 .../UefiShellAcpiViewCommandLib/AcpiParser.h       | 223 ++++++++++++---------
 .../UefiShellAcpiViewCommandLib/AcpiTableParser.c  |  77 +++----
 .../UefiShellAcpiViewCommandLib/AcpiTableParser.h  |  39 ++--
 .../Library/UefiShellAcpiViewCommandLib/AcpiView.c | 113 +++++++----
 .../Library/UefiShellAcpiViewCommandLib/AcpiView.h |  69 ++++---
 .../Parsers/Bgrt/BgrtParser.c                      |  12 +-
 .../Parsers/Dbg2/Dbg2Parser.c                      |  34 ++--
 .../Parsers/Dsdt/DsdtParser.c                      |   7 +-
 .../Parsers/Fadt/FadtParser.c                      |  68 +++++--
 .../Parsers/Gtdt/GtdtParser.c                      |  57 ++++--
 .../Parsers/Iort/IortParser.c                      | 159 ++++++++-------
 .../Parsers/Madt/MadtParser.c                      |  67 ++++---
 .../Parsers/Mcfg/McfgParser.c                      |  18 +-
 .../Parsers/Rsdp/RsdpParser.c                      |  42 ++--
 .../Parsers/Slit/SlitParser.c                      |  61 +++---
 .../Parsers/Spcr/SpcrParser.c                      |  42 ++--
 .../Parsers/Srat/SratParser.c                      |  82 +++++---
 .../Parsers/Ssdt/SsdtParser.c                      |   7 +-
 .../Parsers/Xsdt/XsdtParser.c                      |  11 +-
 .../UefiShellAcpiViewCommandLib.c                  |  18 +-
 .../UefiShellAcpiViewCommandLib.h                  |   4 +-
 .../UefiShellAcpiViewCommandLib.inf                |   3 +
 23 files changed, 823 insertions(+), 564 deletions(-)

-- 
2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [patch V2 0/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues
Posted by Ni, Ruiyu 6 years, 6 months ago
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Bi, Dandan
> Sent: Wednesday, June 6, 2018 8:50 PM
> To: edk2-devel@lists.01.org
> Cc: Alexei.Fedorov@arm.com; Sami Mujawar <sami.mujawar@arm.com>;
> Evan Lloyd <evan.lloyd@arm.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch V2 0/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC
> issues
> 
> ECC tool report some coding style issue in UefiShellAcpiViewCommandLib.
> This patch series is to clean these issues.
> 
> V2: Remove the updates of guard macros in header files in patch 2.
> 
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Evan Lloyd <evan.lloyd@arm.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> Dandan Bi (2):
>   ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues
>   ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues
> 
>  .../UefiShellAcpiViewCommandLib/AcpiParser.c       | 174 +++++++++-------
>  .../UefiShellAcpiViewCommandLib/AcpiParser.h       | 223 ++++++++++++----
> -----
>  .../UefiShellAcpiViewCommandLib/AcpiTableParser.c  |  77 +++----
>   .../UefiShellAcpiViewCommandLib/AcpiTableParser.h  |  39 ++--
>   .../Library/UefiShellAcpiViewCommandLib/AcpiView.c | 113 +++++++----
>   .../Library/UefiShellAcpiViewCommandLib/AcpiView.h |  69 ++++---
>  .../Parsers/Bgrt/BgrtParser.c                      |  12 +-
>  .../Parsers/Dbg2/Dbg2Parser.c                      |  34 ++--
>  .../Parsers/Dsdt/DsdtParser.c                      |   7 +-
>  .../Parsers/Fadt/FadtParser.c                      |  68 +++++--
>  .../Parsers/Gtdt/GtdtParser.c                      |  57 ++++--
>  .../Parsers/Iort/IortParser.c                      | 159 ++++++++-------
>  .../Parsers/Madt/MadtParser.c                      |  67 ++++---
>  .../Parsers/Mcfg/McfgParser.c                      |  18 +-
>  .../Parsers/Rsdp/RsdpParser.c                      |  42 ++--
>  .../Parsers/Slit/SlitParser.c                      |  61 +++---
>  .../Parsers/Spcr/SpcrParser.c                      |  42 ++--
>  .../Parsers/Srat/SratParser.c                      |  82 +++++---
>  .../Parsers/Ssdt/SsdtParser.c                      |   7 +-
>  .../Parsers/Xsdt/XsdtParser.c                      |  11 +-
>  .../UefiShellAcpiViewCommandLib.c                  |  18 +-
>  .../UefiShellAcpiViewCommandLib.h                  |   4 +-
>  .../UefiShellAcpiViewCommandLib.inf                |   3 +
>  23 files changed, 823 insertions(+), 564 deletions(-)
> 
> --
> 2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel