Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The OEM Table ID length cannot be more than 8 characters.
Moreover, the ACPICA iASL compiler patch "Add error messages
for ACPI tables with bad OEM and OEM Table IDs" dated
13 April 2018 [20180413]
(https://github.com/acpica/acpica/commit/ca828bd15604699c14a02e98f4d0d9c4d6885e44)
introduced checks for the OEM Table ID length. If the
OEM Table ID length is more than 8 characters in the
DSDT/SSDT table's DefinitionBlock(), it flags them as
an error.
This patch adjusts the length of the OEM Table ID to
8 characters in the DSDT and SSDT tables.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/289_fix_dsdt_definitionblock_v1
Notes:
v1:
- Fixed DSDT build error flagged by latest ACPICA iasl compiler [SAMI]
Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl
index 15ce7c020045d42f08cf92ad76644b07f0a1e25e..fae6a4be423b4b7da5e9677139f2ab3deac5520e 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl
@@ -12,7 +12,7 @@
**/
-DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXPRESS", 1) {
+DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXP", 1) {
Scope(_SB) {
//
// Processor
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Evan Lloyd <evan.lloyd@arm.com> > -----Original Message----- > From: Sami Mujawar <sami.mujawar@arm.com> > Sent: 20 June 2018 17:43 > To: edk2-devel@lists.01.org > Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Daniil Egranov > <Daniil.Egranov@arm.com>; Thomas Abraham > <thomas.abraham@arm.com>; leif.lindholm@linaro.org; Evan Lloyd > <Evan.Lloyd@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; > Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd > <nd@arm.com> > Subject: [PATCH edk2-platforms v1][platforms/devel-dynamictables] > Platform/ARM: Fix OEM Table ID length in DSDT > > The OEM Table ID length cannot be more than 8 characters. > Moreover, the ACPICA iASL compiler patch "Add error messages for ACPI > tables with bad OEM and OEM Table IDs" dated > 13 April 2018 [20180413] > (https://github.com/acpica/acpica/commit/ca828bd15604699c14a02e98f4d0 > d9c4d6885e44) > introduced checks for the OEM Table ID length. If the OEM Table ID length is > more than 8 characters in the DSDT/SSDT table's DefinitionBlock(), it flags > them as an error. > > This patch adjusts the length of the OEM Table ID to > 8 characters in the DSDT and SSDT tables. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar <sami.mujawar@arm.com> > --- > > The changes can be seen at https://github.com/samimujawar/edk2- > platforms/tree/289_fix_dsdt_definitionblock_v1 > > Notes: > v1: > - Fixed DSDT build error flagged by latest ACPICA iasl compiler [SAMI] > > > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/D > sdt.asl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/ > Dsdt.asl > b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib > /Dsdt.asl > index > 15ce7c020045d42f08cf92ad76644b07f0a1e25e..fae6a4be423b4b7da5e96771 > 39f2ab3deac5520e 100644 > --- > a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/ > Dsdt.asl > +++ > b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib > +++ /Dsdt.asl > @@ -12,7 +12,7 @@ > > **/ > > -DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXPRESS", 1) > { > +DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXP", 1) { > Scope(_SB) { > // > // Processor > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Wed, Jun 20, 2018 at 05:42:54PM +0100, Sami Mujawar wrote: > The OEM Table ID length cannot be more than 8 characters. > Moreover, the ACPICA iASL compiler patch "Add error messages > for ACPI tables with bad OEM and OEM Table IDs" dated > 13 April 2018 [20180413] > (https://github.com/acpica/acpica/commit/ca828bd15604699c14a02e98f4d0d9c4d6885e44) > introduced checks for the OEM Table ID length. If the > OEM Table ID length is more than 8 characters in the > DSDT/SSDT table's DefinitionBlock(), it flags them as > an error. > > This patch adjusts the length of the OEM Table ID to > 8 characters in the DSDT and SSDT tables. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar <sami.mujawar@arm.com> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> Pushed as 693bbd8747. > --- > > The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/289_fix_dsdt_definitionblock_v1 > > Notes: > v1: > - Fixed DSDT build error flagged by latest ACPICA iasl compiler [SAMI] > > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > index 15ce7c020045d42f08cf92ad76644b07f0a1e25e..fae6a4be423b4b7da5e9677139f2ab3deac5520e 100644 > --- a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > @@ -12,7 +12,7 @@ > > **/ > > -DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXPRESS", 1) { > +DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXP", 1) { > Scope(_SB) { > // > // Processor > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
© 2016 - 2024 Red Hat, Inc.