1. Patchew
  2. EDK2
  3. View series

[edk2] [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool

Sami Mujawar posted 5 patches 6 years, 5 months ago
Failed in applying to current master (apply log)
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/AcpiTableFactory.c             |   6 +-
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactory/DeviceTreeTableFactory.c |   6 +-
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory.h                           |   6 +-
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c                        |   2 +-
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf                      |   1 +
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/SmbiosTableFactory.c         |   6 +-
DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c                        |  59 +++---
DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf                      |   1 +
DynamicTablesPkg/DynamicTablesPkg.dec                                                           |   5 +-
DynamicTablesPkg/Include/AcpiTableGenerator.h                                                   |  30 +--
DynamicTablesPkg/Include/ConfigurationManagerHelper.h                                           |   2 +-
DynamicTablesPkg/Include/ConfigurationManagerObject.h                                           |  12 +-
DynamicTablesPkg/Include/DeviceTreeTableGenerator.h                                             |  24 +--
DynamicTablesPkg/Include/Library/TableHelperLib.h                                               |   6 +-
DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h                                |   4 +-
DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h                                 |   6 +-
DynamicTablesPkg/Include/SmbiosTableGenerator.h                                                 |  24 +--
DynamicTablesPkg/Include/StandardNameSpaceObjects.h                                             |   2 +-
DynamicTablesPkg/Include/TableGenerator.h                                                       |  32 ++--
DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf                             |   1 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c                                |  16 +-
DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf                             |   1 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                                |  20 +-
DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf                             |   1 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c                                |  38 ++--
DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf                             |   1 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c                                | 194 ++++++++++----------
DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf                             |   1 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                                |  32 ++--
DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf                             |   1 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c                                |  16 +-
DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf                               |   1 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c                                  |  13 +-
DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf                             |   1 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c                                |  12 +-
DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c                                    |   4 +-
DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf                               |   1 +
37 files changed, 316 insertions(+), 272 deletions(-)
[edk2] [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool
Posted by Sami Mujawar 6 years, 5 months ago 
This patch series fixes the issues reported by the ecc tool.

The changes can be seen at https://github.com/samimujawar/edk2-staging/tree/290_fix_ecc_issues_v1

Sami Mujawar (5):
  DynamicTablesPkg: Add module info to file header
  DynamicTablesPkg: Fix function documentation
  DynamicTablesPkg: Fix variable naming issue
  DynamicTablesPkg: Fix macro to prevent side effect
  DynamicTablesPkg: Fix variable declaration

 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/AcpiTableFactory.c             |   6 +-
 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactory/DeviceTreeTableFactory.c |   6 +-
 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory.h                           |   6 +-
 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c                        |   2 +-
 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf                      |   1 +
 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/SmbiosTableFactory.c         |   6 +-
 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c                        |  59 +++---
 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf                      |   1 +
 DynamicTablesPkg/DynamicTablesPkg.dec                                                           |   5 +-
 DynamicTablesPkg/Include/AcpiTableGenerator.h                                                   |  30 +--
 DynamicTablesPkg/Include/ConfigurationManagerHelper.h                                           |   2 +-
 DynamicTablesPkg/Include/ConfigurationManagerObject.h                                           |  12 +-
 DynamicTablesPkg/Include/DeviceTreeTableGenerator.h                                             |  24 +--
 DynamicTablesPkg/Include/Library/TableHelperLib.h                                               |   6 +-
 DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h                                |   4 +-
 DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h                                 |   6 +-
 DynamicTablesPkg/Include/SmbiosTableGenerator.h                                                 |  24 +--
 DynamicTablesPkg/Include/StandardNameSpaceObjects.h                                             |   2 +-
 DynamicTablesPkg/Include/TableGenerator.h                                                       |  32 ++--
 DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf                             |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c                                |  16 +-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf                             |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                                |  20 +-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf                             |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c                                |  38 ++--
 DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf                             |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c                                | 194 ++++++++++----------
 DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf                             |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                                |  32 ++--
 DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf                             |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c                                |  16 +-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf                               |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c                                  |  13 +-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf                             |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c                                |  12 +-
 DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c                                    |   4 +-
 DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf                               |   1 +
 37 files changed, 316 insertions(+), 272 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool
Posted by Evan Lloyd 6 years, 5 months ago 
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: 27 June 2018 17:48
> To: edk2-devel@lists.01.org
> Cc: leif.lindholm@linaro.org; Evan Lloyd <Evan.Lloyd@arm.com>; Matteo
> Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt
> <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
> Subject: [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool
> 
> This patch series fixes the issues reported by the ecc tool.
> 
> The changes can be seen at https://github.com/samimujawar/edk2-
> staging/tree/290_fix_ecc_issues_v1
> 
> Sami Mujawar (5):
>   DynamicTablesPkg: Add module info to file header
>   DynamicTablesPkg: Fix function documentation
>   DynamicTablesPkg: Fix variable naming issue
>   DynamicTablesPkg: Fix macro to prevent side effect
>   DynamicTablesPkg: Fix variable declaration
> 
> 
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/Acpi
> TableFactory.c             |   6 +-
> 
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactor
> y/DeviceTreeTableFactory.c |   6 +-
> 
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory.
> h                           |   6 +-
> 
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryD
> xe.c                        |   2 +-
> 
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryD
> xe.inf                      |   1 +
> 
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/S
> mbiosTableFactory.c         |   6 +-
> 
> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManag
> erDxe.c                        |  59 +++---
> 
> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManag
> erDxe.inf                      |   1 +
>  DynamicTablesPkg/DynamicTablesPkg.dec                                                           |
> 5 +-
>  DynamicTablesPkg/Include/AcpiTableGenerator.h
> |  30 +--
>  DynamicTablesPkg/Include/ConfigurationManagerHelper.h
> |   2 +-
>  DynamicTablesPkg/Include/ConfigurationManagerObject.h
> |  12 +-
>  DynamicTablesPkg/Include/DeviceTreeTableGenerator.h
> |  24 +--
>  DynamicTablesPkg/Include/Library/TableHelperLib.h
> |   6 +-
>  DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h
> |   4 +-
>  DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h
> |   6 +-
>  DynamicTablesPkg/Include/SmbiosTableGenerator.h
> |  24 +--
>  DynamicTablesPkg/Include/StandardNameSpaceObjects.h
> |   2 +-
>  DynamicTablesPkg/Include/TableGenerator.h
> |  32 ++--
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf
> |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> |  16 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf
> |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c
> |  20 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf
> |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c
> |  38 ++--
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf
> |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c
> | 194 ++++++++++----------
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf
> |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c
> |  32 ++--
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf
> |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c
> |  16 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf
> |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c
> |  13 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf
> |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
> |  12 +-
>  DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c
> |   4 +-
>  DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf
> |   1 +
>  37 files changed, 316 insertions(+), 272 deletions(-)
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool
Posted by Leif Lindholm 6 years, 5 months ago 
On Wed, Jun 27, 2018 at 05:47:41PM +0100, Sami Mujawar wrote:
> This patch series fixes the issues reported by the ecc tool.
> 
> The changes can be seen at https://github.com/samimujawar/edk2-staging/tree/290_fix_ecc_issues_v1

For series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 726ccd02b1..d4b26ac2bb.

/
    Leif

> Sami Mujawar (5):
>   DynamicTablesPkg: Add module info to file header
>   DynamicTablesPkg: Fix function documentation
>   DynamicTablesPkg: Fix variable naming issue
>   DynamicTablesPkg: Fix macro to prevent side effect
>   DynamicTablesPkg: Fix variable declaration
> 
>  DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/AcpiTableFactory.c             |   6 +-
>  DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactory/DeviceTreeTableFactory.c |   6 +-
>  DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory.h                           |   6 +-
>  DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c                        |   2 +-
>  DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf                      |   1 +
>  DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/SmbiosTableFactory.c         |   6 +-
>  DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c                        |  59 +++---
>  DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf                      |   1 +
>  DynamicTablesPkg/DynamicTablesPkg.dec                                                           |   5 +-
>  DynamicTablesPkg/Include/AcpiTableGenerator.h                                                   |  30 +--
>  DynamicTablesPkg/Include/ConfigurationManagerHelper.h                                           |   2 +-
>  DynamicTablesPkg/Include/ConfigurationManagerObject.h                                           |  12 +-
>  DynamicTablesPkg/Include/DeviceTreeTableGenerator.h                                             |  24 +--
>  DynamicTablesPkg/Include/Library/TableHelperLib.h                                               |   6 +-
>  DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h                                |   4 +-
>  DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h                                 |   6 +-
>  DynamicTablesPkg/Include/SmbiosTableGenerator.h                                                 |  24 +--
>  DynamicTablesPkg/Include/StandardNameSpaceObjects.h                                             |   2 +-
>  DynamicTablesPkg/Include/TableGenerator.h                                                       |  32 ++--
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf                             |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c                                |  16 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf                             |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                                |  20 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf                             |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c                                |  38 ++--
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf                             |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c                                | 194 ++++++++++----------
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf                             |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                                |  32 ++--
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf                             |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c                                |  16 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf                               |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c                                  |  13 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf                             |   1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c                                |  12 +-
>  DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c                                    |   4 +-
>  DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf                               |   1 +
>  37 files changed, 316 insertions(+), 272 deletions(-)
> 
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-8c64711

© 2016 - 2024 Red Hat, Inc.