1. Patchew
  2. EDK2
  3. View series

[edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

Sami Mujawar posted 6 patches 5 years, 9 months ago
Failed in applying to current master (apply log)
Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc                            |  3 +-
Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c          | 86 +++++++++---------
Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf     |  1 +
Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf           |  1 +
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc                        |  3 +-
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 93 ++++++++++----------
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  1 +
Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf       |  1 +
8 files changed, 101 insertions(+), 88 deletions(-)
[edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool
Posted by Sami Mujawar 5 years, 9 months ago 
This patch series fixes the issues reported by the ecc tool.

The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1

Sami Mujawar (6):
  Platform/ARM: FVP: Add module info to file header
  Platform/ARM: FVP: Fix function documentation
  Platform/ARM: FVP: Fix variable declaration
  Platform/ARM: Juno: Add module info to file header
  Platform/ARM: Juno: Fix function documentation
  Platform/ARM: Juno: Fix variable declaration

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc                            |  3 +-
 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c          | 86 +++++++++---------
 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf     |  1 +
 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf           |  1 +
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc                        |  3 +-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 93 ++++++++++----------
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  1 +
 Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf       |  1 +
 8 files changed, 101 insertions(+), 88 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool
Posted by Evan Lloyd 5 years, 9 months ago 
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: 27 June 2018 17:49
> To: edk2-devel@lists.01.org
> Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Daniil Egranov
> <Daniil.Egranov@arm.com>; Thomas Abraham
> <thomas.abraham@arm.com>; leif.lindholm@linaro.org; Evan Lloyd
> <Evan.Lloyd@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
> Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd
> <nd@arm.com>
> Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix
> issues reported by ecc tool
> 
> This patch series fixes the issues reported by the ecc tool.
> 
> The changes can be seen at https://github.com/samimujawar/edk2-
> platforms/tree/290_fix_ecc_issues_v1
> 
> Sami Mujawar (6):
>   Platform/ARM: FVP: Add module info to file header
>   Platform/ARM: FVP: Fix function documentation
>   Platform/ARM: FVP: Fix variable declaration
>   Platform/ARM: Juno: Add module info to file header
>   Platform/ARM: Juno: Fix function documentation
>   Platform/ARM: Juno: Fix variable declaration
> 
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> nc                            |  3 +-
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> onfigurationManager.c          | 86 +++++++++---------
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> onfigurationManagerDxe.inf     |  1 +
> 
> Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> rmASLTablesLib.inf           |  1 +
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> sc.inc                        |  3 +-
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> xe/ConfigurationManager.c      | 93 ++++++++++----------
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> xe/ConfigurationManagerDxe.inf |  1 +
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> atformASLTablesLib.inf       |  1 +
>  8 files changed, 101 insertions(+), 88 deletions(-)
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool
Posted by Leif Lindholm 5 years, 9 months ago 
On Wed, Jun 27, 2018 at 04:58:04PM +0000, Evan Lloyd wrote:
> 
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

Should I take this one (and the one on the other accompanying set) as
Reviewed-by?

/
    Leif

> > -----Original Message-----
> > From: Sami Mujawar <sami.mujawar@arm.com>
> > Sent: 27 June 2018 17:49
> > To: edk2-devel@lists.01.org
> > Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Daniil Egranov
> > <Daniil.Egranov@arm.com>; Thomas Abraham
> > <thomas.abraham@arm.com>; leif.lindholm@linaro.org; Evan Lloyd
> > <Evan.Lloyd@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
> > Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd
> > <nd@arm.com>
> > Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix
> > issues reported by ecc tool
> > 
> > This patch series fixes the issues reported by the ecc tool.
> > 
> > The changes can be seen at https://github.com/samimujawar/edk2-
> > platforms/tree/290_fix_ecc_issues_v1
> > 
> > Sami Mujawar (6):
> >   Platform/ARM: FVP: Add module info to file header
> >   Platform/ARM: FVP: Fix function documentation
> >   Platform/ARM: FVP: Fix variable declaration
> >   Platform/ARM: Juno: Add module info to file header
> >   Platform/ARM: Juno: Fix function documentation
> >   Platform/ARM: Juno: Fix variable declaration
> > 
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> > nc                            |  3 +-
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManager.c          | 86 +++++++++---------
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManagerDxe.inf     |  1 +
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> > rmASLTablesLib.inf           |  1 +
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> > sc.inc                        |  3 +-
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManager.c      | 93 ++++++++++----------
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManagerDxe.inf |  1 +
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> > atformASLTablesLib.inf       |  1 +
> >  8 files changed, 101 insertions(+), 88 deletions(-)
> > 
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> > 
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool
Posted by Evan Lloyd 5 years, 9 months ago 

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Evan
> Lloyd
> Sent: 27 June 2018 17:58
> To: Sami Mujawar <Sami.Mujawar@arm.com>; edk2-devel@lists.01.org
> Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Stephanie Hughes-Fitt
> <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
> Subject: Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-
> dynamictables] Fix issues reported by ecc tool
> 
> 
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

 [[Evan Lloyd]] Oops, copy pasted wrong line, sorry.
Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>

> 
> > -----Original Message-----
> > From: Sami Mujawar <sami.mujawar@arm.com>
> > Sent: 27 June 2018 17:49
> > To: edk2-devel@lists.01.org
> > Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Daniil Egranov
> > <Daniil.Egranov@arm.com>; Thomas Abraham
> <thomas.abraham@arm.com>;
> > leif.lindholm@linaro.org; Evan Lloyd <Evan.Lloyd@arm.com>; Matteo
> > Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt
> > <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
> > Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables]
> > Fix issues reported by ecc tool
> >
> > This patch series fixes the issues reported by the ecc tool.
> >
> > The changes can be seen at https://github.com/samimujawar/edk2-
> > platforms/tree/290_fix_ecc_issues_v1
> >
> > Sami Mujawar (6):
> >   Platform/ARM: FVP: Add module info to file header
> >   Platform/ARM: FVP: Fix function documentation
> >   Platform/ARM: FVP: Fix variable declaration
> >   Platform/ARM: Juno: Add module info to file header
> >   Platform/ARM: Juno: Fix function documentation
> >   Platform/ARM: Juno: Fix variable declaration
> >
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> > nc                            |  3 +-
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManager.c          | 86 +++++++++---------
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManagerDxe.inf     |  1 +
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> > rmASLTablesLib.inf           |  1 +
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> > sc.inc                        |  3 +-
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManager.c      | 93 ++++++++++----------
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManagerDxe.inf |  1 +
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> > atformASLTablesLib.inf       |  1 +
> >  8 files changed, 101 insertions(+), 88 deletions(-)
> >
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> >
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool
Posted by Leif Lindholm 5 years, 9 months ago 
On Wed, Jun 27, 2018 at 05:48:42PM +0100, Sami Mujawar wrote:
> This patch series fixes the issues reported by the ecc tool.
> 
> The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1

For series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 693bbd8747..63de92e662.

/
    Leif

> Sami Mujawar (6):
>   Platform/ARM: FVP: Add module info to file header
>   Platform/ARM: FVP: Fix function documentation
>   Platform/ARM: FVP: Fix variable declaration
>   Platform/ARM: Juno: Add module info to file header
>   Platform/ARM: Juno: Fix function documentation
>   Platform/ARM: Juno: Fix variable declaration
> 
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc                            |  3 +-
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c          | 86 +++++++++---------
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf     |  1 +
>  Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf           |  1 +
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc                        |  3 +-
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 93 ++++++++++----------
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  1 +
>  Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf       |  1 +
>  8 files changed, 101 insertions(+), 88 deletions(-)
> 
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-8c64711

© 2016 - 2024 Red Hat, Inc.