Fixed correct password not works issue

[edk2] [Patch 0/2] Fixed correct password not works issue

Posted by Eric Dong 5 years, 9 months ago

Opal device may have an count in firmware to decide whether to resistent 
user input password. If yes, even correct password will be reject by device
firmware. This count will be reset only after an cold reboot or user input
correct password.

Opal driver also has an internal count to decide whether allowed user to input 
password. A reboot (code or hot) action will reset this count.

Current implementation just base on the count in opal driver to decide whether
allow user to input password again. In this case, if the count in opal device
already exceeded, even an correct password will be rejected.

New solution will check both count, either cout exceed will cause opal driver 
report count exceed and a shutdown required.

Eric Dong (2):
  SecurityPkg/TcgStorageOpalLib: Return AUTHORITY_LOCKED_OUT error.
  SecurityPkg/OpalPassword: Fixed input correct password not works issue

 SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 10 +++++++++-
 SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c             |  9 +++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

-- 
2.15.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch 0/2] Fixed correct password not works issue

Posted by Wu, Hao A 5 years, 9 months ago

The series looks good to me.
Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Eric
> Dong
> Sent: Tuesday, July 10, 2018 12:02 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch 0/2] Fixed correct password not works issue
> 
> Opal device may have an count in firmware to decide whether to resistent
> user input password. If yes, even correct password will be reject by device
> firmware. This count will be reset only after an cold reboot or user input
> correct password.
> 
> Opal driver also has an internal count to decide whether allowed user to input
> password. A reboot (code or hot) action will reset this count.
> 
> Current implementation just base on the count in opal driver to decide whether
> allow user to input password again. In this case, if the count in opal device
> already exceeded, even an correct password will be rejected.
> 
> New solution will check both count, either cout exceed will cause opal driver
> report count exceed and a shutdown required.
> 
> Eric Dong (2):
>   SecurityPkg/TcgStorageOpalLib: Return AUTHORITY_LOCKED_OUT error.
>   SecurityPkg/OpalPassword: Fixed input correct password not works issue
> 
>  SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 10 +++++++++-
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c             |  9 +++++++++
>  2 files changed, 18 insertions(+), 1 deletion(-)
> 
> --
> 2.15.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel