1. Patchew
  2. EDK2
  3. View series

[edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution

Laszlo Ersek posted 1 patch 5 years, 9 months ago
Failed in applying to current master (apply log)
ArmVirtPkg/ArmVirt.dsc.inc | 1 -
1 file changed, 1 deletion(-)
[edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
Posted by Laszlo Ersek 5 years, 9 months ago 
The class name for the "PeiResourcePublicationLib" instance is just
"ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
module included in the ArmVirtPkg platforms depends on this lib class;
remove its resolution.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Julien Grall <julien.grall@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    built on all six platforms:
    
    ArmVirtQemu-AARCH64
    ArmVirtQemu-ARM
    ArmVirtQemuKernel-AARCH64
    ArmVirtQemuKernel-ARM
    ArmVirtXen-AARCH64
    ArmVirtXen-ARM

 ArmVirtPkg/ArmVirt.dsc.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 8bb54c5e6579..70a0ac4d786c 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
   PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
   OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
-  PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
   UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
 
-- 
2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
Posted by Ard Biesheuvel 5 years, 9 months ago 
On 24 July 2018 at 15:21, Laszlo Ersek <lersek@redhat.com> wrote:
> The class name for the "PeiResourcePublicationLib" instance is just
> "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
> module included in the ArmVirtPkg platforms depends on this lib class;
> remove its resolution.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Julien Grall <julien.grall@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>
> Notes:
>     built on all six platforms:
>
>     ArmVirtQemu-AARCH64
>     ArmVirtQemu-ARM
>     ArmVirtQemuKernel-AARCH64
>     ArmVirtQemuKernel-ARM
>     ArmVirtXen-AARCH64
>     ArmVirtXen-ARM
>
>  ArmVirtPkg/ArmVirt.dsc.inc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 8bb54c5e6579..70a0ac4d786c 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
>    PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
>    OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>    PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
> -  PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
>    UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
>    ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
>
> --
> 2.14.1.3.gb7cf6e02401b
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
Posted by Laszlo Ersek 5 years, 9 months ago 
On 07/24/18 15:22, Ard Biesheuvel wrote:
> On 24 July 2018 at 15:21, Laszlo Ersek <lersek@redhat.com> wrote:
>> The class name for the "PeiResourcePublicationLib" instance is just
>> "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
>> module included in the ArmVirtPkg platforms depends on this lib class;
>> remove its resolution.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Julien Grall <julien.grall@linaro.org>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Commit 49a4797e9c68, thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
Posted by Carsey, Jaben 5 years, 9 months ago 
Laszlo,

Do you think that using the incorrect name for a library instance should generate an error?  I would have thought it would have...

-Jaben

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, July 24, 2018 6:21 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous
> ResourcePublicationLib resolution
> 
> The class name for the "PeiResourcePublicationLib" instance is just
> "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
> module included in the ArmVirtPkg platforms depends on this lib class;
> remove its resolution.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Julien Grall <julien.grall@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     built on all six platforms:
> 
>     ArmVirtQemu-AARCH64
>     ArmVirtQemu-ARM
>     ArmVirtQemuKernel-AARCH64
>     ArmVirtQemuKernel-ARM
>     ArmVirtXen-AARCH64
>     ArmVirtXen-ARM
> 
>  ArmVirtPkg/ArmVirt.dsc.inc | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 8bb54c5e6579..70a0ac4d786c 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
> 
> PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc
> eLib.inf
> 
> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN
> ull/OemHookStatusCodeLibNull.inf
> 
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base
> PeCoffGetEntryPointLib.inf
> -
> PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiR
> esourcePublicationLib.inf
> 
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> mpressLib.inf
> 
> ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx
> tractGuidedSectionLib.inf
> 
> --
> 2.14.1.3.gb7cf6e02401b
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
Posted by Gao, Liming 5 years, 9 months ago 
Jaben:
  Yes. BaseTools can generate the error message for it. But, more checker in BaseTools parser phase will also increase the build performance. This is the balance here. 

Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Carsey, Jaben
> Sent: Wednesday, July 25, 2018 6:25 AM
> To: Laszlo Ersek <lersek@redhat.com>; edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
> 
> Laszlo,
> 
> Do you think that using the incorrect name for a library instance should generate an error?  I would have thought it would have...
> 
> -Jaben
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Laszlo Ersek
> > Sent: Tuesday, July 24, 2018 6:21 AM
> > To: edk2-devel-01 <edk2-devel@lists.01.org>
> > Subject: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous
> > ResourcePublicationLib resolution
> >
> > The class name for the "PeiResourcePublicationLib" instance is just
> > "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
> > module included in the ArmVirtPkg platforms depends on this lib class;
> > remove its resolution.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Julien Grall <julien.grall@linaro.org>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> >
> > Notes:
> >     built on all six platforms:
> >
> >     ArmVirtQemu-AARCH64
> >     ArmVirtQemu-ARM
> >     ArmVirtQemuKernel-AARCH64
> >     ArmVirtQemuKernel-ARM
> >     ArmVirtXen-AARCH64
> >     ArmVirtXen-ARM
> >
> >  ArmVirtPkg/ArmVirt.dsc.inc | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> > index 8bb54c5e6579..70a0ac4d786c 100644
> > --- a/ArmVirtPkg/ArmVirt.dsc.inc
> > +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> > @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
> >
> > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc
> > eLib.inf
> >
> > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN
> > ull/OemHookStatusCodeLibNull.inf
> >
> > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base
> > PeCoffGetEntryPointLib.inf
> > -
> > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiR
> > esourcePublicationLib.inf
> >
> > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> > mpressLib.inf
> >
> > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx
> > tractGuidedSectionLib.inf
> >
> > --
> > 2.14.1.3.gb7cf6e02401b
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-8c64711

© 2016 - 2024 Red Hat, Inc.