From nobody Sat Apr 20 15:07:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1533267659490729.7114509860672; Thu, 2 Aug 2018 20:40:59 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 67940210C4DB3; Thu, 2 Aug 2018 20:40:58 -0700 (PDT) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 636442097FA8F for ; Thu, 2 Aug 2018 20:40:56 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2018 20:40:55 -0700 Received: from ray-dev.ccr.corp.intel.com ([10.239.9.4]) by orsmga004.jf.intel.com with ESMTP; 02 Aug 2018 20:40:55 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,437,1526367600"; d="scan'208";a="221377343" From: Ruiyu Ni To: edk2-devel@lists.01.org Date: Fri, 3 Aug 2018 11:41:31 +0800 Message-Id: <20180803034131.109784-1-ruiyu.ni@intel.com> X-Mailer: git-send-email 2.16.1.windows.1 Subject: [edk2] [PATCH] ShellPkg/acpi: Code cleanup to pass static code checker X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hao A Wu MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RDMRC_1 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao A Wu Reviewed-by: Hao Wu --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | = 2 +- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | = 1 + .../Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | = 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 18c4983e95..5cab20023d 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -297,7 +297,7 @@ DumpUint64 ( Val =3D *(UINT32*)(Ptr + sizeof (UINT32)); =20 Val <<=3D 32; - Val |=3D *(UINT32*)Ptr; + Val |=3D (UINT64)*(UINT32*)Ptr; =20 Print (Format, Val); } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/Shel= lPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c index 47ce93f104..4199e82ab1 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c @@ -284,6 +284,7 @@ ConvertStrToAcpiSignature ( UINT8 Index; CHAR8 Ptr[4]; =20 + ZeroMem (Ptr, sizeof (Ptr)); Index =3D 0; =20 // Convert to Upper case and convert to ASCII diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiView= CommandLib.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiVi= ewCommandLib.c index 245700a253..c6eb7087cf 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommand= Lib.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommand= Lib.c @@ -118,7 +118,7 @@ UefiShellAcpiViewCommandLibConstructor ( gShellAcpiViewHiiHandle =3D NULL; =20 // Check Shell Profile Debug1 bit of the profiles mask - if ((FixedPcdGet8 (PcdShellProfileMask) & BIT1) =3D=3D 0) { + if ((PcdGet8 (PcdShellProfileMask) & BIT1) =3D=3D 0) { return EFI_SUCCESS; } =20 --=20 2.16.1.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel