The functions that are never called have been removed.
They are EhcDumpRegs,EhcDisableAsyncSchd and EhcDisablePeriodSchd
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 27 ---------------
MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h | 11 ------
MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c | 44 ------------------------
3 files changed, 82 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
index 76368b4748..71755d421b 100644
--- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
+++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
@@ -228,31 +228,4 @@ EhcDumpBuf (
DEBUG ((EFI_D_VERBOSE, "\n"));
}
-/**
- Dump the EHCI status registers.
-
- @param Ehc USB EHCI Host Controller instance
-**/
-VOID
-EhcDumpRegs (
- IN USB2_HC_DEV *Ehc
- )
-{
- UINT8 Index;
-
- DEBUG ((EFI_D_VERBOSE, " EHC_CAPLENGTH_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_CAPLENGTH_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_HCSPARAMS_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_HCSPARAMS_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_HCCPARAMS_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_HCCPARAMS_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_USBCMD_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBCMD_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_USBSTS_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBSTS_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_USBINTR_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBINTR_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_FRINDEX_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_FRINDEX_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_CTRLDSSEG_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_CTRLDSSEG_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_FRAME_BASE_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_FRAME_BASE_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_ASYNC_HEAD_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_ASYNC_HEAD_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_CONFIG_FLAG_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_CONFIG_FLAG_OFFSET)));
- for (Index = 0; Index < (UINT8) (Ehc->HcStructParams & HCSP_NPORTS); Index++) {
- DEBUG ((EFI_D_VERBOSE, " EHC_PORT_STAT_OFFSET(%d) = 0x%08x\n", Index, EhcReadOpReg (Ehc, EHC_PORT_STAT_OFFSET + (4 * Index))));
- }
-}
diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
index bc84bb7864..a64b0551a0 100644
--- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
+++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
@@ -61,15 +61,4 @@ EhcDumpBuf (
);
-/**
- Dump the EHCI status registers.
-
- @param Ehc USB EHCI Host Controller instance
-
-**/
-VOID
-EhcDumpRegs (
- IN USB2_HC_DEV *Ehc
- );
-
#endif
diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
index 34836eccf5..59752d1bdc 100644
--- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
+++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
@@ -372,29 +372,7 @@ EhcEnablePeriodSchd (
}
-/**
- Disable periodic schedule.
- @param Ehc The EHCI device.
- @param Timeout Time to wait before abort (in millisecond, ms).
-
- @retval EFI_SUCCESS Periodic schedule is disabled.
- @retval EFI_DEVICE_ERROR Fail to disable periodic schedule.
-
-**/
-EFI_STATUS
-EhcDisablePeriodSchd (
- IN USB2_HC_DEV *Ehc,
- IN UINT32 Timeout
- )
-{
- EFI_STATUS Status;
-
- EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_PERIOD);
-
- Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_PERIOD_ENABLED, FALSE, Timeout);
- return Status;
-}
@@ -424,29 +402,7 @@ EhcEnableAsyncSchd (
-/**
- Disable asynchrounous schedule.
- @param Ehc The EHCI device.
- @param Timeout Time to wait before abort (in millisecond, ms).
-
- @retval EFI_SUCCESS The asynchronous schedule is disabled.
- @return Others Failed to disable the asynchronous schedule.
-
-**/
-EFI_STATUS
-EhcDisableAsyncSchd (
- IN USB2_HC_DEV *Ehc,
- IN UINT32 Timeout
- )
-{
- EFI_STATUS Status;
-
- EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_ASYNC);
-
- Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_ASYNC_ENABLED, FALSE, Timeout);
- return Status;
-}
--
2.18.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant
> functions
>
> The functions that are never called have been removed.
> They are EhcDumpRegs,EhcDisableAsyncSchd and EhcDisablePeriodSchd
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 27 ---------------
> MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h | 11 ------
> MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c | 44 ------------------------
> 3 files changed, 82 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
> b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
> index 76368b4748..71755d421b 100644
> --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
> +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
> @@ -228,31 +228,4 @@ EhcDumpBuf (
> DEBUG ((EFI_D_VERBOSE, "\n"));
> }
>
> -/**
> - Dump the EHCI status registers.
> -
> - @param Ehc USB EHCI Host Controller instance
>
> -**/
> -VOID
> -EhcDumpRegs (
> - IN USB2_HC_DEV *Ehc
> - )
> -{
> - UINT8 Index;
> -
> - DEBUG ((EFI_D_VERBOSE, " EHC_CAPLENGTH_OFFSET = 0x%08x\n",
> EhcReadCapRegister (Ehc, EHC_CAPLENGTH_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_HCSPARAMS_OFFSET = 0x%08x\n",
> EhcReadCapRegister (Ehc, EHC_HCSPARAMS_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_HCCPARAMS_OFFSET = 0x%08x\n",
> EhcReadCapRegister (Ehc, EHC_HCCPARAMS_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_USBCMD_OFFSET = 0x%08x\n",
> EhcReadOpReg (Ehc, EHC_USBCMD_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_USBSTS_OFFSET = 0x%08x\n",
> EhcReadOpReg (Ehc, EHC_USBSTS_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_USBINTR_OFFSET = 0x%08x\n",
> EhcReadOpReg (Ehc, EHC_USBINTR_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_FRINDEX_OFFSET = 0x%08x\n",
> EhcReadOpReg (Ehc, EHC_FRINDEX_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_CTRLDSSEG_OFFSET = 0x%08x\n",
> EhcReadOpReg (Ehc, EHC_CTRLDSSEG_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_FRAME_BASE_OFFSET = 0x%08x\n",
> EhcReadOpReg (Ehc, EHC_FRAME_BASE_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_ASYNC_HEAD_OFFSET = 0x%08x\n",
> EhcReadOpReg (Ehc, EHC_ASYNC_HEAD_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_CONFIG_FLAG_OFFSET = 0x%08x\n",
> EhcReadOpReg (Ehc, EHC_CONFIG_FLAG_OFFSET)));
> - for (Index = 0; Index < (UINT8) (Ehc->HcStructParams & HCSP_NPORTS);
> Index++) {
> - DEBUG ((EFI_D_VERBOSE, " EHC_PORT_STAT_OFFSET(%d) = 0x%08x\n",
> Index, EhcReadOpReg (Ehc, EHC_PORT_STAT_OFFSET + (4 * Index))));
> - }
> -}
> diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
> b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
> index bc84bb7864..a64b0551a0 100644
> --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
> +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
> @@ -61,15 +61,4 @@ EhcDumpBuf (
> );
>
>
> -/**
> - Dump the EHCI status registers.
> -
> - @param Ehc USB EHCI Host Controller instance
> -
> -**/
> -VOID
> -EhcDumpRegs (
> - IN USB2_HC_DEV *Ehc
> - );
> -
> #endif
> diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
> b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
> index 34836eccf5..59752d1bdc 100644
> --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
> +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
> @@ -372,29 +372,7 @@ EhcEnablePeriodSchd ( }
>
>
> -/**
> - Disable periodic schedule.
>
> - @param Ehc The EHCI device.
> - @param Timeout Time to wait before abort (in millisecond, ms).
> -
> - @retval EFI_SUCCESS Periodic schedule is disabled.
> - @retval EFI_DEVICE_ERROR Fail to disable periodic schedule.
> -
> -**/
> -EFI_STATUS
> -EhcDisablePeriodSchd (
> - IN USB2_HC_DEV *Ehc,
> - IN UINT32 Timeout
> - )
> -{
> - EFI_STATUS Status;
> -
> - EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET,
> USBCMD_ENABLE_PERIOD);
> -
> - Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET,
> USBSTS_PERIOD_ENABLED, FALSE, Timeout);
> - return Status;
> -}
>
>
>
> @@ -424,29 +402,7 @@ EhcEnableAsyncSchd (
>
>
>
> -/**
> - Disable asynchrounous schedule.
>
> - @param Ehc The EHCI device.
> - @param Timeout Time to wait before abort (in millisecond, ms).
> -
> - @retval EFI_SUCCESS The asynchronous schedule is disabled.
> - @return Others Failed to disable the asynchronous schedule.
> -
> -**/
> -EFI_STATUS
> -EhcDisableAsyncSchd (
> - IN USB2_HC_DEV *Ehc,
> - IN UINT32 Timeout
> - )
> -{
> - EFI_STATUS Status;
> -
> - EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_ASYNC);
> -
> - Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET,
> USBSTS_ASYNC_ENABLED, FALSE, Timeout);
> - return Status;
> -}
>
>
>
> --
> 2.18.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant functions
The functions that are never called have been removed.
They are EhcDumpRegs,EhcDisableAsyncSchd and EhcDisablePeriodSchd
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 27 --------------- MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h | 11 ------
MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c | 44 ------------------------
3 files changed, 82 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
index 76368b4748..71755d421b 100644
--- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
+++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
@@ -228,31 +228,4 @@ EhcDumpBuf (
DEBUG ((EFI_D_VERBOSE, "\n"));
}
-/**
- Dump the EHCI status registers.
-
- @param Ehc USB EHCI Host Controller instance
-**/
-VOID
-EhcDumpRegs (
- IN USB2_HC_DEV *Ehc
- )
-{
- UINT8 Index;
-
- DEBUG ((EFI_D_VERBOSE, " EHC_CAPLENGTH_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_CAPLENGTH_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_HCSPARAMS_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_HCSPARAMS_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_HCCPARAMS_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_HCCPARAMS_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_USBCMD_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBCMD_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_USBSTS_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBSTS_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_USBINTR_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBINTR_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_FRINDEX_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_FRINDEX_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_CTRLDSSEG_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_CTRLDSSEG_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_FRAME_BASE_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_FRAME_BASE_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_ASYNC_HEAD_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_ASYNC_HEAD_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_CONFIG_FLAG_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_CONFIG_FLAG_OFFSET)));
- for (Index = 0; Index < (UINT8) (Ehc->HcStructParams & HCSP_NPORTS); Index++) {
- DEBUG ((EFI_D_VERBOSE, " EHC_PORT_STAT_OFFSET(%d) = 0x%08x\n", Index, EhcReadOpReg (Ehc, EHC_PORT_STAT_OFFSET + (4 * Index))));
- }
-}
diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
index bc84bb7864..a64b0551a0 100644
--- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
+++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
@@ -61,15 +61,4 @@ EhcDumpBuf (
);
-/**
- Dump the EHCI status registers.
-
- @param Ehc USB EHCI Host Controller instance
-
-**/
-VOID
-EhcDumpRegs (
- IN USB2_HC_DEV *Ehc
- );
-
#endif
diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
index 34836eccf5..59752d1bdc 100644
--- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
+++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
@@ -372,29 +372,7 @@ EhcEnablePeriodSchd ( }
-/**
- Disable periodic schedule.
- @param Ehc The EHCI device.
- @param Timeout Time to wait before abort (in millisecond, ms).
-
- @retval EFI_SUCCESS Periodic schedule is disabled.
- @retval EFI_DEVICE_ERROR Fail to disable periodic schedule.
-
-**/
-EFI_STATUS
-EhcDisablePeriodSchd (
- IN USB2_HC_DEV *Ehc,
- IN UINT32 Timeout
- )
-{
- EFI_STATUS Status;
-
- EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_PERIOD);
-
- Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_PERIOD_ENABLED, FALSE, Timeout);
- return Status;
-}
@@ -424,29 +402,7 @@ EhcEnableAsyncSchd (
-/**
- Disable asynchrounous schedule.
- @param Ehc The EHCI device.
- @param Timeout Time to wait before abort (in millisecond, ms).
-
- @retval EFI_SUCCESS The asynchronous schedule is disabled.
- @return Others Failed to disable the asynchronous schedule.
-
-**/
-EFI_STATUS
-EhcDisableAsyncSchd (
- IN USB2_HC_DEV *Ehc,
- IN UINT32 Timeout
- )
-{
- EFI_STATUS Status;
-
- EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_ASYNC);
-
- Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_ASYNC_ENABLED, FALSE, Timeout);
- return Status;
-}
--
2.18.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On 08/08/18 10:46, shenglei wrote:
> The functions that are never called have been removed.
> They are EhcDumpRegs,EhcDisableAsyncSchd and EhcDisablePeriodSchd
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 27 ---------------
> MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h | 11 ------
> MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c | 44 ------------------------
> 3 files changed, 82 deletions(-)
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Laszlo
>
> diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
> index 76368b4748..71755d421b 100644
> --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
> +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
> @@ -228,31 +228,4 @@ EhcDumpBuf (
> DEBUG ((EFI_D_VERBOSE, "\n"));
> }
>
> -/**
> - Dump the EHCI status registers.
> -
> - @param Ehc USB EHCI Host Controller instance
>
> -**/
> -VOID
> -EhcDumpRegs (
> - IN USB2_HC_DEV *Ehc
> - )
> -{
> - UINT8 Index;
> -
> - DEBUG ((EFI_D_VERBOSE, " EHC_CAPLENGTH_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_CAPLENGTH_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_HCSPARAMS_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_HCSPARAMS_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_HCCPARAMS_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_HCCPARAMS_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_USBCMD_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBCMD_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_USBSTS_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBSTS_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_USBINTR_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBINTR_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_FRINDEX_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_FRINDEX_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_CTRLDSSEG_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_CTRLDSSEG_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_FRAME_BASE_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_FRAME_BASE_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_ASYNC_HEAD_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_ASYNC_HEAD_OFFSET)));
> - DEBUG ((EFI_D_VERBOSE, " EHC_CONFIG_FLAG_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_CONFIG_FLAG_OFFSET)));
> - for (Index = 0; Index < (UINT8) (Ehc->HcStructParams & HCSP_NPORTS); Index++) {
> - DEBUG ((EFI_D_VERBOSE, " EHC_PORT_STAT_OFFSET(%d) = 0x%08x\n", Index, EhcReadOpReg (Ehc, EHC_PORT_STAT_OFFSET + (4 * Index))));
> - }
> -}
> diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
> index bc84bb7864..a64b0551a0 100644
> --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
> +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
> @@ -61,15 +61,4 @@ EhcDumpBuf (
> );
>
>
> -/**
> - Dump the EHCI status registers.
> -
> - @param Ehc USB EHCI Host Controller instance
> -
> -**/
> -VOID
> -EhcDumpRegs (
> - IN USB2_HC_DEV *Ehc
> - );
> -
> #endif
> diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
> index 34836eccf5..59752d1bdc 100644
> --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
> +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
> @@ -372,29 +372,7 @@ EhcEnablePeriodSchd (
> }
>
>
> -/**
> - Disable periodic schedule.
>
> - @param Ehc The EHCI device.
> - @param Timeout Time to wait before abort (in millisecond, ms).
> -
> - @retval EFI_SUCCESS Periodic schedule is disabled.
> - @retval EFI_DEVICE_ERROR Fail to disable periodic schedule.
> -
> -**/
> -EFI_STATUS
> -EhcDisablePeriodSchd (
> - IN USB2_HC_DEV *Ehc,
> - IN UINT32 Timeout
> - )
> -{
> - EFI_STATUS Status;
> -
> - EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_PERIOD);
> -
> - Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_PERIOD_ENABLED, FALSE, Timeout);
> - return Status;
> -}
>
>
>
> @@ -424,29 +402,7 @@ EhcEnableAsyncSchd (
>
>
>
> -/**
> - Disable asynchrounous schedule.
>
> - @param Ehc The EHCI device.
> - @param Timeout Time to wait before abort (in millisecond, ms).
> -
> - @retval EFI_SUCCESS The asynchronous schedule is disabled.
> - @return Others Failed to disable the asynchronous schedule.
> -
> -**/
> -EFI_STATUS
> -EhcDisableAsyncSchd (
> - IN USB2_HC_DEV *Ehc,
> - IN UINT32 Timeout
> - )
> -{
> - EFI_STATUS Status;
> -
> - EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_ASYNC);
> -
> - Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_ASYNC_ENABLED, FALSE, Timeout);
> - return Status;
> -}
>
>
>
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
© 2016 - 2025 Red Hat, Inc.