From nobody Tue May 13 20:55:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1533718047917462.97472208261775; Wed, 8 Aug 2018 01:47:27 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 816FA210DF777; Wed, 8 Aug 2018 01:47:26 -0700 (PDT) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6A167210DF75D for ; Wed, 8 Aug 2018 01:47:25 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 01:47:25 -0700 Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga006.fm.intel.com with ESMTP; 08 Aug 2018 01:47:20 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,456,1526367600"; d="scan'208";a="252946649" From: shenglei To: edk2-devel@lists.01.org Date: Wed, 8 Aug 2018 16:46:47 +0800 Message-Id: <20180808084712.34696-2-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180808084712.34696-1-shenglei.zhang@intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> Subject: [edk2] [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Dong , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RDMRC_1 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The function DumpImageAuthentication that is never calld has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- .../Application/CapsuleApp/CapsuleDump.c | 31 ------------------- 1 file changed, 31 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModuleP= kg/Application/CapsuleApp/CapsuleDump.c index 45c3ecd050..7a3eb94362 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c @@ -106,37 +106,6 @@ DumpUxCapsule ( Print(L" OffsetY - 0x%x\n", DisplayCapsule->ImagePayload.Offse= tY); } =20 -/** - Dump FMP image authentication information. - - @param[in] Image The FMP capsule image - @param[in] ImageSize The size of the FMP capsule image in bytes. - - @return the size of FMP authentication. -**/ -UINTN -DumpImageAuthentication ( - IN VOID *Image, - IN UINTN ImageSize - ) -{ - EFI_FIRMWARE_IMAGE_AUTHENTICATION *ImageAuthentication; - - ImageAuthentication =3D Image; - if (CompareGuid(&ImageAuthentication->AuthInfo.CertType, &gEfiCertPkcs7G= uid) || - CompareGuid(&ImageAuthentication->AuthInfo.CertType, &gEfiCertTypeRs= a2048Sha256Guid)) { - Print(L"[ImageAuthentication]\n"); - Print(L" MonotonicCount - 0x%lx\n", ImageAuthentication->MonotonicC= ount); - Print(L"WIN_CERTIFICATE:\n"); - Print(L" dwLength - 0x%x\n", ImageAuthentication->AuthInfo.Hd= r.dwLength); - Print(L" wRevision - 0x%x\n", ImageAuthentication->AuthInfo.Hd= r.wRevision); - Print(L" wCertificateType - 0x%x\n", ImageAuthentication->AuthInfo.Hd= r.wCertificateType); - Print(L" CertType - %g\n", &ImageAuthentication->AuthInfo.Cer= tType); - return sizeof(ImageAuthentication->MonotonicCount) + ImageAuthenticati= on->AuthInfo.Hdr.dwLength; - } else { - return 0; - } -} =20 /** Dump a non-nested FMP capsule. --=20 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel