From nobody Tue May 13 21:06:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1533718057919220.2217212557889; Wed, 8 Aug 2018 01:47:37 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4F2E8210E0F9E; Wed, 8 Aug 2018 01:47:32 -0700 (PDT) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5401A210DF774 for ; Wed, 8 Aug 2018 01:47:31 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 01:47:30 -0700 Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga006.fm.intel.com with ESMTP; 08 Aug 2018 01:47:28 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,456,1526367600"; d="scan'208";a="252946664" From: shenglei To: edk2-devel@lists.01.org Date: Wed, 8 Aug 2018 16:46:51 +0800 Message-Id: <20180808084712.34696-6-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180808084712.34696-1-shenglei.zhang@intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> Subject: [edk2] [PATCH 05/26] MdeModulePkg NvmExpressDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Dong , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RDMRC_1 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The functions that are never called have been removed. They are ReadNvmeAdminSubmissionQueueBaseAddress, ReadNvmeAdminCompletionQueueBaseAddress and ReadNvmeAdminQueueAttributes https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Hao Wu Reviewed-by: Laszlo Ersek Reviewed-by: Star Zeng --- .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 110 ------------------ 1 file changed, 110 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c b/MdeModule= Pkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c index 30ade3a589..421561f16d 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c @@ -183,43 +183,7 @@ ReadNvmeControllerStatus ( return EFI_SUCCESS; } =20 -/** - Read Nvm Express admin queue attributes register. - - @param Private The pointer to the NVME_CONTROLLER_PRIVATE_DATA= data structure. - @param Aqa The buffer used to store admin queue attributes= register content. - - @return EFI_SUCCESS Successfully read the admin queue attributes re= gister content. - @return EFI_DEVICE_ERROR Fail to read the admin queue attributes registe= r. - -**/ -EFI_STATUS -ReadNvmeAdminQueueAttributes ( - IN NVME_CONTROLLER_PRIVATE_DATA *Private, - IN NVME_AQA *Aqa - ) -{ - EFI_PCI_IO_PROTOCOL *PciIo; - EFI_STATUS Status; - UINT32 Data; - - PciIo =3D Private->PciIo; - Status =3D PciIo->Mem.Read ( - PciIo, - EfiPciIoWidthUint32, - NVME_BAR, - NVME_AQA_OFFSET, - 1, - &Data - ); - - if (EFI_ERROR(Status)) { - return Status; - } =20 - WriteUnaligned32 ((UINT32*)Aqa, Data); - return EFI_SUCCESS; -} =20 /** Write Nvm Express admin queue attributes register. @@ -262,43 +226,6 @@ WriteNvmeAdminQueueAttributes ( return EFI_SUCCESS; } =20 -/** - Read Nvm Express admin submission queue base address register. - - @param Private The pointer to the NVME_CONTROLLER_PRIVATE_DATA= data structure. - @param Asq The buffer used to store admin submission queue= base address register content. - - @return EFI_SUCCESS Successfully read the admin submission queue ba= se address register content. - @return EFI_DEVICE_ERROR Fail to read the admin submission queue base ad= dress register. - -**/ -EFI_STATUS -ReadNvmeAdminSubmissionQueueBaseAddress ( - IN NVME_CONTROLLER_PRIVATE_DATA *Private, - IN NVME_ASQ *Asq - ) -{ - EFI_PCI_IO_PROTOCOL *PciIo; - EFI_STATUS Status; - UINT64 Data; - - PciIo =3D Private->PciIo; - Status =3D PciIo->Mem.Read ( - PciIo, - EfiPciIoWidthUint32, - NVME_BAR, - NVME_ASQ_OFFSET, - 2, - &Data - ); - - if (EFI_ERROR(Status)) { - return Status; - } - - WriteUnaligned64 ((UINT64*)Asq, Data); - return EFI_SUCCESS; -} =20 /** Write Nvm Express admin submission queue base address register. @@ -341,44 +268,7 @@ WriteNvmeAdminSubmissionQueueBaseAddress ( return EFI_SUCCESS; } =20 -/** - Read Nvm Express admin completion queue base address register. - - @param Private The pointer to the NVME_CONTROLLER_PRIVATE_DATA= data structure. - @param Acq The buffer used to store admin completion queue= base address register content. - - @return EFI_SUCCESS Successfully read the admin completion queue ba= se address register content. - @return EFI_DEVICE_ERROR Fail to read the admin completion queue base ad= dress register. - -**/ -EFI_STATUS -ReadNvmeAdminCompletionQueueBaseAddress ( - IN NVME_CONTROLLER_PRIVATE_DATA *Private, - IN NVME_ACQ *Acq - ) -{ - EFI_PCI_IO_PROTOCOL *PciIo; - EFI_STATUS Status; - UINT64 Data; - - PciIo =3D Private->PciIo; =20 - Status =3D PciIo->Mem.Read ( - PciIo, - EfiPciIoWidthUint32, - NVME_BAR, - NVME_ACQ_OFFSET, - 2, - &Data - ); - - if (EFI_ERROR(Status)) { - return Status; - } - - WriteUnaligned64 ((UINT64*)Acq, Data); - return EFI_SUCCESS; -} =20 /** Write Nvm Express admin completion queue base address register. --=20 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel