From nobody Tue May 13 20:55:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1533718066609239.3963497615499; Wed, 8 Aug 2018 01:47:46 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id A07B521CAD9B2; Wed, 8 Aug 2018 01:47:32 -0700 (PDT) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9BE8221BADAB9 for ; Wed, 8 Aug 2018 01:47:31 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 01:47:31 -0700 Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga006.fm.intel.com with ESMTP; 08 Aug 2018 01:47:30 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,456,1526367600"; d="scan'208";a="252946669" From: shenglei To: edk2-devel@lists.01.org Date: Wed, 8 Aug 2018 16:46:52 +0800 Message-Id: <20180808084712.34696-7-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180808084712.34696-1-shenglei.zhang@intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> Subject: [edk2] [PATCH 06/26] MdeModulePkg PciBusDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Dong , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RDMRC_1 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The functions that are never called have been removed. They are UpStreamBridgesAttributes and GetHpcPciAddressFromRootBridge. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Laszlo Ersek Reviewed-by: Ruiyu Ni Reviewed-by: Star Zeng --- .../Bus/Pci/PciBusDxe/PciDeviceSupport.c | 80 ------------------- .../Bus/Pci/PciBusDxe/PciDeviceSupport.h | 17 ---- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 41 ---------- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 21 ----- 4 files changed, 159 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c b/MdeModuleP= kg/Bus/Pci/PciBusDxe/PciDeviceSupport.c index 48cf57a24f..f7039da992 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c @@ -1061,85 +1061,5 @@ ActiveVGADeviceOnTheRootBridge ( } =20 =20 -/** - Get HPC PCI address according to its device path. - - @param RootBridge Root bridege Io instance. - @param RemainingDevicePath Given searching device path. - @param PciAddress Buffer holding searched result. - - @retval EFI_SUCCESS PCI address was stored in PciAddress - @retval EFI_NOT_FOUND Can not find the specific device path. - -**/ -EFI_STATUS -GetHpcPciAddressFromRootBridge ( - IN PCI_IO_DEVICE *RootBridge, - IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath, - OUT UINT64 *PciAddress - ) -{ - EFI_DEV_PATH_PTR Node; - PCI_IO_DEVICE *Temp; - EFI_DEVICE_PATH_PROTOCOL *CurrentDevicePath; - LIST_ENTRY *CurrentLink; - BOOLEAN MisMatch; - - MisMatch =3D FALSE; - - CurrentDevicePath =3D RemainingDevicePath; - Node.DevPath =3D CurrentDevicePath; - Temp =3D NULL; - - while (!IsDevicePathEnd (CurrentDevicePath)) { - - CurrentLink =3D RootBridge->ChildList.ForwardLink; - Node.DevPath =3D CurrentDevicePath; - - while (CurrentLink !=3D NULL && CurrentLink !=3D &RootBridge->ChildLis= t) { - Temp =3D PCI_IO_DEVICE_FROM_LINK (CurrentLink); - - if (Node.Pci->Device =3D=3D Temp->DeviceNumber && - Node.Pci->Function =3D=3D Temp->FunctionNumber) { - RootBridge =3D Temp; - break; - } - - CurrentLink =3D CurrentLink->ForwardLink; - } - - // - // Check if we find the bridge - // - if (CurrentLink =3D=3D &RootBridge->ChildList) { - - MisMatch =3D TRUE; - break; - - } - - CurrentDevicePath =3D NextDevicePathNode (CurrentDevicePath); - } - - if (MisMatch) { - - CurrentDevicePath =3D NextDevicePathNode (CurrentDevicePath); - - if (IsDevicePathEnd (CurrentDevicePath)) { - *PciAddress =3D EFI_PCI_ADDRESS (RootBridge->BusNumber, Node.Pci->De= vice, Node.Pci->Function, 0); - return EFI_SUCCESS; - } - - return EFI_NOT_FOUND; - } =20 - if (Temp !=3D NULL) { - *PciAddress =3D EFI_PCI_ADDRESS (Temp->BusNumber, Temp->DeviceNumber, = Temp->FunctionNumber, 0); - } else { - return EFI_NOT_FOUND; - } - - return EFI_SUCCESS; - -} =20 diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h b/MdeModuleP= kg/Bus/Pci/PciBusDxe/PciDeviceSupport.h index 1a01e72b1e..c282381f85 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h @@ -255,23 +255,6 @@ ActiveVGADeviceOnTheRootBridge ( IN PCI_IO_DEVICE *RootBridge ); =20 -/** - Get HPC PCI address according to its device path. - - @param RootBridge Root bridege Io instance. - @param RemainingDevicePath Given searching device path. - @param PciAddress Buffer holding searched result. - - @retval EFI_SUCCESS PCI address was stored in PciAddress. - @retval EFI_NOT_FOUND Can not find the specific device path. - -**/ -EFI_STATUS -GetHpcPciAddressFromRootBridge ( - IN PCI_IO_DEVICE *RootBridge, - IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath, - OUT UINT64 *PciAddress - ); =20 /** Destroy a pci device node. diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/= PciBusDxe/PciIo.c index 87b0b9884a..291578c63c 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c @@ -2061,47 +2061,6 @@ PciIoSetBarAttributes ( return EFI_SUCCESS; } =20 -/** - Program parent bridge's attribute recurrently. - - @param PciIoDevice Child Pci device instance - @param Operation The operation to perform on the attributes for this = PCI controller. - @param Attributes The mask of attributes that are used for Set, Enable= , and Disable - operations. - - @retval EFI_SUCCESS The operation on the PCI controller's attr= ibutes was completed. - @retval EFI_INVALID_PARAMETER One or more parameters are invalid. - @retval EFI_UNSUPPORTED one or more of the bits set in - Attributes are not supported by this PCI c= ontroller or one of - its parent bridges when Operation is Set, = Enable or Disable. - -**/ -EFI_STATUS -UpStreamBridgesAttributes ( - IN PCI_IO_DEVICE *PciIoDevice, - IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION Operation, - IN UINT64 Attributes - ) -{ - PCI_IO_DEVICE *Parent; - EFI_PCI_IO_PROTOCOL *PciIo; - - Parent =3D PciIoDevice->Parent; - - while (Parent !=3D NULL && IS_PCI_BRIDGE (&Parent->Pci)) { - - // - // Get the PciIo Protocol - // - PciIo =3D &Parent->PciIo; - - PciIo->Attributes (PciIo, Operation, Attributes, NULL); - - Parent =3D Parent->Parent; - } - - return EFI_SUCCESS; -} =20 /** Test whether two Pci devices has same parent bridge. diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h b/MdeModulePkg/Bus/Pci/= PciBusDxe/PciIo.h index b7e38ded3f..69e7c32881 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h @@ -646,27 +646,6 @@ PciIoSetBarAttributes ( IN OUT UINT64 *Length ); =20 -/** - Program parent bridge's attribute recurrently. - - @param PciIoDevice Child Pci device instance - @param Operation The operation to perform on the attributes for this = PCI controller. - @param Attributes The mask of attributes that are used for Set, Enable= , and Disable - operations. - - @retval EFI_SUCCESS The operation on the PCI controller's attr= ibutes was completed. - @retval EFI_INVALID_PARAMETER One or more parameters are invalid. - @retval EFI_UNSUPPORTED one or more of the bits set in - Attributes are not supported by this PCI c= ontroller or one of - its parent bridges when Operation is Set, = Enable or Disable. - -**/ -EFI_STATUS -UpStreamBridgesAttributes ( - IN PCI_IO_DEVICE *PciIoDevice, - IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION Operation, - IN UINT64 Attributes - ); =20 /** Test whether two Pci devices has same parent bridge. --=20 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel