From nobody Wed Dec 17 04:05:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1533718068098298.3757523550132; Wed, 8 Aug 2018 01:47:48 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C9CC6210E0FB1; Wed, 8 Aug 2018 01:47:35 -0700 (PDT) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E2CD021CB74A7 for ; Wed, 8 Aug 2018 01:47:32 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 01:47:32 -0700 Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga006.fm.intel.com with ESMTP; 08 Aug 2018 01:47:32 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,456,1526367600"; d="scan'208";a="252946676" From: shenglei To: edk2-devel@lists.01.org Date: Wed, 8 Aug 2018 16:46:53 +0800 Message-Id: <20180808084712.34696-8-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180808084712.34696-1-shenglei.zhang@intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> Subject: [edk2] [PATCH 07/26] MdeModulePkg SdMmcPciHcDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Dong , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RDMRC_1 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The functions that are never called have been removed. They are SdCardGetCsd and SdCardGetScr. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 107 ------------------ 1 file changed, 107 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c b/MdeModulePkg/B= us/Pci/SdMmcPciHcDxe/SdDevice.c index 9e70de956f..8c93933bc6 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c @@ -318,116 +318,9 @@ SdCardSetRca ( return Status; } =20 -/** - Send command SEND_CSD to the SD device to get the data of the CSD regist= er. - - Refer to SD Physical Layer Simplified Spec 4.1 Section 4.7 for details. - - @param[in] PassThru A pointer to the EFI_SD_MMC_PASS_THRU_PROTOCOL= instance. - @param[in] Slot The slot number of the SD card to send the com= mand to. - @param[in] Rca The relative device address of selected device. - @param[out] Csd The buffer to store the content of the CSD reg= ister. - Note the caller should ignore the lowest byte = of this - buffer as the content of this byte is meaningl= ess even - if the operation succeeds. - - @retval EFI_SUCCESS The operation is done correctly. - @retval Others The operation fails. - -**/ -EFI_STATUS -SdCardGetCsd ( - IN EFI_SD_MMC_PASS_THRU_PROTOCOL *PassThru, - IN UINT8 Slot, - IN UINT16 Rca, - OUT SD_CSD *Csd - ) -{ - EFI_SD_MMC_COMMAND_BLOCK SdMmcCmdBlk; - EFI_SD_MMC_STATUS_BLOCK SdMmcStatusBlk; - EFI_SD_MMC_PASS_THRU_COMMAND_PACKET Packet; - EFI_STATUS Status; - - ZeroMem (&SdMmcCmdBlk, sizeof (SdMmcCmdBlk)); - ZeroMem (&SdMmcStatusBlk, sizeof (SdMmcStatusBlk)); - ZeroMem (&Packet, sizeof (Packet)); - - Packet.SdMmcCmdBlk =3D &SdMmcCmdBlk; - Packet.SdMmcStatusBlk =3D &SdMmcStatusBlk; - Packet.Timeout =3D SD_MMC_HC_GENERIC_TIMEOUT; =20 - SdMmcCmdBlk.CommandIndex =3D SD_SEND_CSD; - SdMmcCmdBlk.CommandType =3D SdMmcCommandTypeAc; - SdMmcCmdBlk.ResponseType =3D SdMmcResponseTypeR2; - SdMmcCmdBlk.CommandArgument =3D (UINT32)Rca << 16; =20 - Status =3D SdMmcPassThruPassThru (PassThru, Slot, &Packet, NULL); - if (!EFI_ERROR (Status)) { - // - // For details, refer to SD Host Controller Simplified Spec 3.0 Table = 2-12. - // - CopyMem (((UINT8*)Csd) + 1, &SdMmcStatusBlk.Resp0, sizeof (SD_CSD) - 1= ); - } - - return Status; -} - -/** - Send command SEND_CSD to the SD device to get the data of the CSD regist= er. - - Refer to SD Physical Layer Simplified Spec 4.1 Section 4.7 for details. =20 - @param[in] PassThru A pointer to the EFI_SD_MMC_PASS_THRU_PROTOCOL= instance. - @param[in] Slot The slot number of the SD card to send the com= mand to. - @param[in] Rca The relative device address of selected device. - @param[out] Scr The buffer to store the content of the SCR reg= ister. - - @retval EFI_SUCCESS The operation is done correctly. - @retval Others The operation fails. - -**/ -EFI_STATUS -SdCardGetScr ( - IN EFI_SD_MMC_PASS_THRU_PROTOCOL *PassThru, - IN UINT8 Slot, - IN UINT16 Rca, - OUT SD_SCR *Scr - ) -{ - EFI_SD_MMC_COMMAND_BLOCK SdMmcCmdBlk; - EFI_SD_MMC_STATUS_BLOCK SdMmcStatusBlk; - EFI_SD_MMC_PASS_THRU_COMMAND_PACKET Packet; - EFI_STATUS Status; - - ZeroMem (&SdMmcCmdBlk, sizeof (SdMmcCmdBlk)); - ZeroMem (&SdMmcStatusBlk, sizeof (SdMmcStatusBlk)); - ZeroMem (&Packet, sizeof (Packet)); - - Packet.SdMmcCmdBlk =3D &SdMmcCmdBlk; - Packet.SdMmcStatusBlk =3D &SdMmcStatusBlk; - Packet.Timeout =3D SD_MMC_HC_GENERIC_TIMEOUT; - - SdMmcCmdBlk.CommandIndex =3D SD_APP_CMD; - SdMmcCmdBlk.CommandType =3D SdMmcCommandTypeAc; - SdMmcCmdBlk.ResponseType =3D SdMmcResponseTypeR1; - SdMmcCmdBlk.CommandArgument =3D (UINT32)Rca << 16; - - Status =3D SdMmcPassThruPassThru (PassThru, Slot, &Packet, NULL); - if (EFI_ERROR (Status)) { - return Status; - } - - SdMmcCmdBlk.CommandIndex =3D SD_SEND_SCR; - SdMmcCmdBlk.CommandType =3D SdMmcCommandTypeAdtc; - SdMmcCmdBlk.ResponseType =3D SdMmcResponseTypeR1; - - Packet.InDataBuffer =3D Scr; - Packet.InTransferLength =3D sizeof (SD_SCR); - - Status =3D SdMmcPassThruPassThru (PassThru, Slot, &Packet, NULL); - - return Status; -} =20 /** Send command SELECT_DESELECT_CARD to the SD device to select/deselect it. --=20 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel