:p
atchew
Login
Two redundant library classes have been removed. The redundant function "IsSystemFmp" has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1067 Cc: Jiewen Yao <jiewen.yao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei <shenglei.zhang@intel.com> --- .../SystemFirmwareCommonDxe.c | 27 ------------------- .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 1 - .../SystemFirmwareReportDxe.inf | 2 -- 3 files changed, 30 deletions(-) diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c index XXXXXXX..XXXXXXX 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c @@ -XXX,XX +XXX,XX @@ InitializePrivateData ( return EFI_SUCCESS; } -/** - Return if this FMP is a system FMP or a device FMP, based upon FmpImageInfo. - - @param[in] FmpImageInfo A pointer to EFI_FIRMWARE_IMAGE_DESCRIPTOR - - @retval TRUE It is a system FMP. - @retval FALSE It is a device FMP. -**/ -BOOLEAN -IsSystemFmp ( - IN EFI_FIRMWARE_IMAGE_DESCRIPTOR *FmpImageInfo - ) -{ - GUID *Guid; - UINTN Count; - UINTN Index; - - Guid = PcdGetPtr(PcdSystemFmpCapsuleImageTypeIdGuid); - Count = PcdGetSize(PcdSystemFmpCapsuleImageTypeIdGuid) / sizeof(GUID); - for (Index = 0; Index < Count; Index++, Guid++) { - if (CompareGuid(&FmpImageInfo->ImageTypeId, Guid)) { - return TRUE; - } - } - - return FALSE; -} diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h index XXXXXXX..XXXXXXX 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h @@ -XXX,XX +XXX,XX @@ #include <Library/UefiDriverEntryPoint.h> #include <Library/DevicePathLib.h> #include <Library/HobLib.h> -#include <Library/DxeServicesLib.h> #include <Library/DxeServicesTableLib.h> #include <Library/PlatformFlashAccessLib.h> #include <Library/EdkiiSystemCapsuleLib.h> diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf index XXXXXXX..XXXXXXX 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf @@ -XXX,XX +XXX,XX @@ HobLib UefiRuntimeServicesTableLib UefiDriverEntryPoint - DxeServicesLib DxeServicesTableLib - PrintLib EdkiiSystemCapsuleLib [Pcd] -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Two redundant library classes have been removed. The redundant function "IsSystemFmp" has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1067 v2: Remove DxeServicesLib from SystemFirmwareUpdateDxe.inf. Cc: Jiewen Yao <jiewen.yao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei <shenglei.zhang@intel.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com> --- .../SystemFirmwareCommonDxe.c | 27 ------------------- .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 1 - .../SystemFirmwareReportDxe.inf | 2 -- .../SystemFirmwareUpdateDxe.inf | 1 - 4 files changed, 31 deletions(-) diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c index XXXXXXX..XXXXXXX 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c @@ -XXX,XX +XXX,XX @@ InitializePrivateData ( return EFI_SUCCESS; } -/** - Return if this FMP is a system FMP or a device FMP, based upon FmpImageInfo. - - @param[in] FmpImageInfo A pointer to EFI_FIRMWARE_IMAGE_DESCRIPTOR - - @retval TRUE It is a system FMP. - @retval FALSE It is a device FMP. -**/ -BOOLEAN -IsSystemFmp ( - IN EFI_FIRMWARE_IMAGE_DESCRIPTOR *FmpImageInfo - ) -{ - GUID *Guid; - UINTN Count; - UINTN Index; - - Guid = PcdGetPtr(PcdSystemFmpCapsuleImageTypeIdGuid); - Count = PcdGetSize(PcdSystemFmpCapsuleImageTypeIdGuid) / sizeof(GUID); - for (Index = 0; Index < Count; Index++, Guid++) { - if (CompareGuid(&FmpImageInfo->ImageTypeId, Guid)) { - return TRUE; - } - } - - return FALSE; -} diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h index XXXXXXX..XXXXXXX 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h @@ -XXX,XX +XXX,XX @@ #include <Library/UefiDriverEntryPoint.h> #include <Library/DevicePathLib.h> #include <Library/HobLib.h> -#include <Library/DxeServicesLib.h> #include <Library/DxeServicesTableLib.h> #include <Library/PlatformFlashAccessLib.h> #include <Library/EdkiiSystemCapsuleLib.h> diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf index XXXXXXX..XXXXXXX 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf @@ -XXX,XX +XXX,XX @@ HobLib UefiRuntimeServicesTableLib UefiDriverEntryPoint - DxeServicesLib DxeServicesTableLib - PrintLib EdkiiSystemCapsuleLib [Pcd] diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf index XXXXXXX..XXXXXXX 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf @@ -XXX,XX +XXX,XX @@ HobLib UefiRuntimeServicesTableLib UefiDriverEntryPoint - DxeServicesLib EdkiiSystemCapsuleLib PlatformFlashAccessLib IniParsingLib -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel