Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Siyuan Fu <siyuan.fu@intel.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li <songpeng.li@intel.com> --- NetworkPkg/IScsiDxe/IScsiDxe.inf | 1 - NetworkPkg/IScsiDxe/IScsiProto.c | 33 ------------ NetworkPkg/IpSecDxe/Ikev2/Payload.c | 18 ------- NetworkPkg/IpSecDxe/Ikev2/Utility.c | 76 ---------------------------- NetworkPkg/IpSecDxe/Ikev2/Utility.h | 67 ------------------------ NetworkPkg/TcpDxe/TcpOption.c | 30 ----------- NetworkPkg/TcpDxe/TcpOption.h | 16 ------ NetworkPkg/TlsDxe/TlsDxe.inf | 1 - NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 23 --------- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 10 ---- 10 files changed, 275 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDxe.inf index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IScsiDxe/IScsiDxe.inf +++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf @@ -XXX,XX +XXX,XX @@ gEfiIfrTianoGuid ## SOMETIMES_PRODUCES ## UNDEFINED gEfiAcpiTableGuid ## SOMETIMES_CONSUMES ## SystemTable gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable - gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable gEfiAdapterInfoNetworkBootGuid ## SOMETIMES_CONSUMES ## UNDEFINED gEfiAdapterInfoUndiIpv6SupportGuid ## SOMETIMES_CONSUMES ## GUID diff --git a/NetworkPkg/IScsiDxe/IScsiProto.c b/NetworkPkg/IScsiDxe/IScsiProto.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IScsiDxe/IScsiProto.c +++ b/NetworkPkg/IScsiDxe/IScsiProto.c @@ -XXX,XX +XXX,XX @@ IScsiDelTcb ( } -/** - Find the task control block by the initator task tag. - - @param[in] TcbList The tcb list. - @param[in] InitiatorTaskTag The initiator task tag. - - @return The task control block found. - @retval NULL The task control block cannot be found. - -**/ -ISCSI_TCB * -IScsiFindTcbByITT ( - IN LIST_ENTRY *TcbList, - IN UINT32 InitiatorTaskTag - ) -{ - ISCSI_TCB *Tcb; - LIST_ENTRY *Entry; - - Tcb = NULL; - - NET_LIST_FOR_EACH (Entry, TcbList) { - Tcb = NET_LIST_USER_STRUCT (Entry, ISCSI_TCB, Link); - - if (Tcb->InitiatorTaskTag == InitiatorTaskTag) { - break; - } - } - - return Tcb; -} - - /** Create a data segment, pad it, and calculate the CRC if needed. diff --git a/NetworkPkg/IpSecDxe/Ikev2/Payload.c b/NetworkPkg/IpSecDxe/Ikev2/Payload.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IpSecDxe/Ikev2/Payload.c +++ b/NetworkPkg/IpSecDxe/Ikev2/Payload.c @@ -XXX,XX +XXX,XX @@ ON_EXIT: return Status; } -/** - Save some useful payloads after accepting the Packet. - - @param[in] SessionCommon Pointer to IKEV2_SESSION_COMMON related to the operation. - @param[in] IkePacket Pointer to received IkePacet. - @param[in] IkeType The type used to indicate it is in IkeSa or ChildSa or Info - exchange. - -**/ -VOID -Ikev2OnPacketAccepted ( - IN IKEV2_SESSION_COMMON *SessionCommon, - IN IKE_PACKET *IkePacket, - IN UINT8 IkeType - ) -{ - return; -} /** diff --git a/NetworkPkg/IpSecDxe/Ikev2/Utility.c b/NetworkPkg/IpSecDxe/Ikev2/Utility.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IpSecDxe/Ikev2/Utility.c +++ b/NetworkPkg/IpSecDxe/Ikev2/Utility.c @@ -XXX,XX +XXX,XX @@ Ikev2SaSessionRemove ( return NULL; } -/** - Marking a SA session as on deleting. - - @param[in] IkeSaSession Pointer to IKEV2_SA_SESSION. - - @retval EFI_SUCCESS Find the related SA session and marked it. - -**/ -EFI_STATUS -Ikev2SaSessionOnDeleting ( - IN IKEV2_SA_SESSION *IkeSaSession - ) -{ - return EFI_SUCCESS; -} /** Free specified Seession Common. The session common would belong to a IKE SA or @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaSessionReg ( return ; } -/** - Find the ChildSaSession by it's MessagId. - - @param[in] SaSessionList Pointer to a ChildSaSession List. - @param[in] Mid The messageId used to search ChildSaSession. - - @return Pointer to IKEV2_CHILD_SA_SESSION or NULL. - -**/ -IKEV2_CHILD_SA_SESSION * -Ikev2ChildSaSessionLookupByMid ( - IN LIST_ENTRY *SaSessionList, - IN UINT32 Mid - ) -{ - LIST_ENTRY *Entry; - IKEV2_CHILD_SA_SESSION *ChildSaSession; - - NET_LIST_FOR_EACH (Entry, SaSessionList) { - ChildSaSession = IKEV2_CHILD_SA_SESSION_BY_IKE_SA (Entry); - - if (ChildSaSession->MessageId == Mid) { - return ChildSaSession; - } - } - return NULL; -} /** This function find the Child SA by the specified SPI. @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaSessionRemove ( return NULL; } -/** - Mark a specified Child SA Session as on deleting. - - @param[in] ChildSaSession Pointer to IKEV2_CHILD_SA_SESSION. - - @retval EFI_SUCCESS Operation is successful. - -**/ -EFI_STATUS -Ikev2ChildSaSessionOnDeleting ( - IN IKEV2_CHILD_SA_SESSION *ChildSaSession - ) -{ - return EFI_SUCCESS; -} - /** Free the memory located for the specified IKEV2_CHILD_SA_SESSION. @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaAssociateSpdEntry ( } -/** - This function finds the SPI from Create Child SA Exchange Packet. - - @param[in] IkePacket Pointer to IKE_PACKET to be searched. - - @retval SPI number or 0 if it is not supported. - -**/ -UINT32 -Ikev2ChildExchangeRekeySpi ( - IN IKE_PACKET *IkePacket - ) -{ - // - // Not support yet. - // - return 0; -} /** Validate the IKE header of received IKE packet. diff --git a/NetworkPkg/IpSecDxe/Ikev2/Utility.h b/NetworkPkg/IpSecDxe/Ikev2/Utility.h index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IpSecDxe/Ikev2/Utility.h +++ b/NetworkPkg/IpSecDxe/Ikev2/Utility.h @@ -XXX,XX +XXX,XX @@ Ikev2SaSessionRemove ( ); -/** - Marking a SA session as on deleting. - - @param[in] IkeSaSession Pointer to IKEV2_SA_SESSION. - - @retval EFI_SUCCESS Find the related SA session and marked it. - -**/ -EFI_STATUS -Ikev2SaSessionOnDeleting ( - IN IKEV2_SA_SESSION *IkeSaSession - ); - /** After IKE/Child SA is estiblished, close the time event and free sent packet. @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaSessionLookupBySpi ( IN UINT32 Spi ); -/** - Find the ChildSaSession by it's MessagId. - - @param[in] SaSessionList Pointer to a ChildSaSession List. - @param[in] Mid The messageId used to search ChildSaSession. - - @return Pointer to IKEV2_CHILD_SA_SESSION. - -**/ -IKEV2_CHILD_SA_SESSION * -Ikev2ChildSaSessionLookupByMid ( - IN LIST_ENTRY *SaSessionList, - IN UINT32 Mid - ); /** Insert a Child SA Session into the specified ChildSa list.. @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaSessionRemove ( IN UINT8 ListType ); -/** - Mark a specified Child SA Session as on deleting. - - @param[in] ChildSaSession Pointer to IKEV2_CHILD_SA_SESSION. - - @retval EFI_SUCCESS Operation is successful. - -**/ -EFI_STATUS -Ikev2ChildSaSessionOnDeleting ( - IN IKEV2_CHILD_SA_SESSION *ChildSaSession - ); /** Free the memory located for the specified IKEV2_CHILD_SA_SESSION. @@ -XXX,XX +XXX,XX @@ Ikev2ChildExchangeRequestType( IN IKE_PACKET *IkePacket ); -/** - This function finds the SPI from Create Child Sa Exchange Packet. - - @param[in] IkePacket Pointer to IKE_PACKET to be searched. - - @retval SPI number. - -**/ -UINT32 -Ikev2ChildExchangeRekeySpi( - IN IKE_PACKET *IkePacket - ); - /** Associate a SPD selector to the Child SA Session. @@ -XXX,XX +XXX,XX @@ Ikev2DecodePacket ( IN UINTN IkeType ); -/** - Save some useful payloads after accepting the Packet. - - @param[in] SessionCommon Pointer to IKEV2_SESSION_COMMON related to the operation. - @param[in] IkePacket Pointer to received IkePacet. - @param[in] IkeType The type used to indicate it is in IkeSa or ChildSa or Info - exchange. - -**/ -VOID -Ikev2OnPacketAccepted ( - IN IKEV2_SESSION_COMMON *SessionCommon, - IN IKE_PACKET *IkePacket, - IN UINT8 IkeType - ); /** Send out IKEV2 packet. diff --git a/NetworkPkg/TcpDxe/TcpOption.c b/NetworkPkg/TcpDxe/TcpOption.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/TcpDxe/TcpOption.c +++ b/NetworkPkg/TcpDxe/TcpOption.c @@ -XXX,XX +XXX,XX @@ TcpParseOption ( return 0; } - -/** - Check the segment against PAWS. - - @param[in] Tcb Pointer to the TCP_CB of this TCP instance. - @param[in] TSVal The timestamp value. - - @retval 1 The segment passed the PAWS check. - @retval 0 The segment failed to pass the PAWS check. - -**/ -UINT32 -TcpPawsOK ( - IN TCP_CB *Tcb, - IN UINT32 TSVal - ) -{ - // - // PAWS as defined in RFC1323, buggy... - // - if (TCP_TIME_LT (TSVal, Tcb->TsRecent) && - TCP_TIME_LT (Tcb->TsRecentAge + TCP_PAWS_24DAY, mTcpTick) - ) { - - return 0; - - } - - return 1; -} diff --git a/NetworkPkg/TcpDxe/TcpOption.h b/NetworkPkg/TcpDxe/TcpOption.h index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/TcpDxe/TcpOption.h +++ b/NetworkPkg/TcpDxe/TcpOption.h @@ -XXX,XX +XXX,XX @@ TcpParseOption ( IN OUT TCP_OPTION *Option ); -/** - Check the segment against PAWS. - - @param[in] Tcb Pointer to the TCP_CB of this TCP instance. - @param[in] TSVal The timestamp value. - - @retval 1 The segment passed the PAWS check. - @retval 0 The segment failed to pass the PAWS check. - -**/ -UINT32 -TcpPawsOK ( - IN TCP_CB *Tcb, - IN UINT32 TSVal - ); - #endif diff --git a/NetworkPkg/TlsDxe/TlsDxe.inf b/NetworkPkg/TlsDxe/TlsDxe.inf index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/TlsDxe/TlsDxe.inf +++ b/NetworkPkg/TlsDxe/TlsDxe.inf @@ -XXX,XX +XXX,XX @@ BaseLib UefiLib DebugLib - NetLib BaseCryptLib TlsLib diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c @@ -XXX,XX +XXX,XX @@ PxeBcCacheDhcp6Packet ( return EFI_SUCCESS; } - -/** - Free all the nodes in the list for boot file. - - @param[in] Head The pointer to the head of list. - -**/ -VOID -PxeBcFreeBootFileOption ( - IN LIST_ENTRY *Head - ) -{ - LIST_ENTRY *Entry; - LIST_ENTRY *NextEntry; - PXEBC_DHCP6_OPTION_NODE *Node; - - NET_LIST_FOR_EACH_SAFE (Entry, NextEntry, Head) { - Node = NET_LIST_USER_STRUCT (Entry, PXEBC_DHCP6_OPTION_NODE, Link); - RemoveEntryList (Entry); - FreePool (Node); - } -} - /** Retrieve the boot server address using the EFI_DNS6_PROTOCOL. diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h @@ -XXX,XX +XXX,XX @@ typedef struct { } PXEBC_DHCP6_PACKET_CACHE; -/** - Free all the nodes in the boot file list. - - @param[in] Head The pointer to the head of the list. - -**/ -VOID -PxeBcFreeBootFileOption ( - IN LIST_ENTRY *Head - ); /** -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Some redundant functions and definitions which are never calld have been removed. These fuctions are manually searched in source files to make sure that they are not used elsewhere. Songpeng Li (5): NetworkPkg: IScsiDxe: Remove the redundant code and definition. NetworkPkg: IpSecDxe: Remove the redundant code. NetworkPkg: TcpDxe: Remove the redundant code. NetworkPkg: TlsDxe: Remove the redundant definition. NetworkPkg: UefiPxeBcDxe: Remove the redundant code. NetworkPkg/IScsiDxe/IScsiDxe.inf | 1 - NetworkPkg/IScsiDxe/IScsiProto.c | 33 ------------ NetworkPkg/IpSecDxe/Ikev2/Payload.c | 18 ------- NetworkPkg/IpSecDxe/Ikev2/Utility.c | 76 ---------------------------- NetworkPkg/IpSecDxe/Ikev2/Utility.h | 67 ------------------------ NetworkPkg/TcpDxe/TcpOption.c | 32 +----------- NetworkPkg/TcpDxe/TcpOption.h | 18 +------ NetworkPkg/TlsDxe/TlsDxe.inf | 3 +- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 23 --------- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 10 ---- 10 files changed, 3 insertions(+), 278 deletions(-) -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel The function IScsiFindTcbByITT that is never called have been removed. The definition gEfiAcpi20TableGuid has been removed. Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Siyuan Fu <siyuan.fu@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li <songpeng.li@intel.com> --- NetworkPkg/IScsiDxe/IScsiDxe.inf | 1 - NetworkPkg/IScsiDxe/IScsiProto.c | 33 -------------------------------- 2 files changed, 34 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDxe.inf index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IScsiDxe/IScsiDxe.inf +++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf @@ -XXX,XX +XXX,XX @@ gEfiIfrTianoGuid ## SOMETIMES_PRODUCES ## UNDEFINED gEfiAcpiTableGuid ## SOMETIMES_CONSUMES ## SystemTable gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable - gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable gEfiAdapterInfoNetworkBootGuid ## SOMETIMES_CONSUMES ## UNDEFINED gEfiAdapterInfoUndiIpv6SupportGuid ## SOMETIMES_CONSUMES ## GUID diff --git a/NetworkPkg/IScsiDxe/IScsiProto.c b/NetworkPkg/IScsiDxe/IScsiProto.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IScsiDxe/IScsiProto.c +++ b/NetworkPkg/IScsiDxe/IScsiProto.c @@ -XXX,XX +XXX,XX @@ IScsiDelTcb ( } -/** - Find the task control block by the initator task tag. - - @param[in] TcbList The tcb list. - @param[in] InitiatorTaskTag The initiator task tag. - - @return The task control block found. - @retval NULL The task control block cannot be found. - -**/ -ISCSI_TCB * -IScsiFindTcbByITT ( - IN LIST_ENTRY *TcbList, - IN UINT32 InitiatorTaskTag - ) -{ - ISCSI_TCB *Tcb; - LIST_ENTRY *Entry; - - Tcb = NULL; - - NET_LIST_FOR_EACH (Entry, TcbList) { - Tcb = NET_LIST_USER_STRUCT (Entry, ISCSI_TCB, Link); - - if (Tcb->InitiatorTaskTag == InitiatorTaskTag) { - break; - } - } - - return Tcb; -} - - /** Create a data segment, pad it, and calculate the CRC if needed. -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel The functions that are never called have been removed. They are Ikev2OnPacketAccepted, Ikev2SaSessionOnDeleting, Ikev2ChildSaSessionLookupByMid, Ikev2ChildSaSessionOnDeleting and Ikev2ChildExchangeRekeySpi. Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Siyuan Fu <siyuan.fu@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li <songpeng.li@intel.com> --- NetworkPkg/IpSecDxe/Ikev2/Payload.c | 18 ------- NetworkPkg/IpSecDxe/Ikev2/Utility.c | 76 ----------------------------- NetworkPkg/IpSecDxe/Ikev2/Utility.h | 67 ------------------------- 3 files changed, 161 deletions(-) diff --git a/NetworkPkg/IpSecDxe/Ikev2/Payload.c b/NetworkPkg/IpSecDxe/Ikev2/Payload.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IpSecDxe/Ikev2/Payload.c +++ b/NetworkPkg/IpSecDxe/Ikev2/Payload.c @@ -XXX,XX +XXX,XX @@ ON_EXIT: return Status; } -/** - Save some useful payloads after accepting the Packet. - - @param[in] SessionCommon Pointer to IKEV2_SESSION_COMMON related to the operation. - @param[in] IkePacket Pointer to received IkePacet. - @param[in] IkeType The type used to indicate it is in IkeSa or ChildSa or Info - exchange. - -**/ -VOID -Ikev2OnPacketAccepted ( - IN IKEV2_SESSION_COMMON *SessionCommon, - IN IKE_PACKET *IkePacket, - IN UINT8 IkeType - ) -{ - return; -} /** diff --git a/NetworkPkg/IpSecDxe/Ikev2/Utility.c b/NetworkPkg/IpSecDxe/Ikev2/Utility.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IpSecDxe/Ikev2/Utility.c +++ b/NetworkPkg/IpSecDxe/Ikev2/Utility.c @@ -XXX,XX +XXX,XX @@ Ikev2SaSessionRemove ( return NULL; } -/** - Marking a SA session as on deleting. - - @param[in] IkeSaSession Pointer to IKEV2_SA_SESSION. - - @retval EFI_SUCCESS Find the related SA session and marked it. - -**/ -EFI_STATUS -Ikev2SaSessionOnDeleting ( - IN IKEV2_SA_SESSION *IkeSaSession - ) -{ - return EFI_SUCCESS; -} /** Free specified Seession Common. The session common would belong to a IKE SA or @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaSessionReg ( return ; } -/** - Find the ChildSaSession by it's MessagId. - - @param[in] SaSessionList Pointer to a ChildSaSession List. - @param[in] Mid The messageId used to search ChildSaSession. - - @return Pointer to IKEV2_CHILD_SA_SESSION or NULL. - -**/ -IKEV2_CHILD_SA_SESSION * -Ikev2ChildSaSessionLookupByMid ( - IN LIST_ENTRY *SaSessionList, - IN UINT32 Mid - ) -{ - LIST_ENTRY *Entry; - IKEV2_CHILD_SA_SESSION *ChildSaSession; - - NET_LIST_FOR_EACH (Entry, SaSessionList) { - ChildSaSession = IKEV2_CHILD_SA_SESSION_BY_IKE_SA (Entry); - - if (ChildSaSession->MessageId == Mid) { - return ChildSaSession; - } - } - return NULL; -} /** This function find the Child SA by the specified SPI. @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaSessionRemove ( return NULL; } -/** - Mark a specified Child SA Session as on deleting. - - @param[in] ChildSaSession Pointer to IKEV2_CHILD_SA_SESSION. - - @retval EFI_SUCCESS Operation is successful. - -**/ -EFI_STATUS -Ikev2ChildSaSessionOnDeleting ( - IN IKEV2_CHILD_SA_SESSION *ChildSaSession - ) -{ - return EFI_SUCCESS; -} - /** Free the memory located for the specified IKEV2_CHILD_SA_SESSION. @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaAssociateSpdEntry ( } -/** - This function finds the SPI from Create Child SA Exchange Packet. - - @param[in] IkePacket Pointer to IKE_PACKET to be searched. - - @retval SPI number or 0 if it is not supported. - -**/ -UINT32 -Ikev2ChildExchangeRekeySpi ( - IN IKE_PACKET *IkePacket - ) -{ - // - // Not support yet. - // - return 0; -} /** Validate the IKE header of received IKE packet. diff --git a/NetworkPkg/IpSecDxe/Ikev2/Utility.h b/NetworkPkg/IpSecDxe/Ikev2/Utility.h index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/IpSecDxe/Ikev2/Utility.h +++ b/NetworkPkg/IpSecDxe/Ikev2/Utility.h @@ -XXX,XX +XXX,XX @@ Ikev2SaSessionRemove ( ); -/** - Marking a SA session as on deleting. - - @param[in] IkeSaSession Pointer to IKEV2_SA_SESSION. - - @retval EFI_SUCCESS Find the related SA session and marked it. - -**/ -EFI_STATUS -Ikev2SaSessionOnDeleting ( - IN IKEV2_SA_SESSION *IkeSaSession - ); - /** After IKE/Child SA is estiblished, close the time event and free sent packet. @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaSessionLookupBySpi ( IN UINT32 Spi ); -/** - Find the ChildSaSession by it's MessagId. - - @param[in] SaSessionList Pointer to a ChildSaSession List. - @param[in] Mid The messageId used to search ChildSaSession. - - @return Pointer to IKEV2_CHILD_SA_SESSION. - -**/ -IKEV2_CHILD_SA_SESSION * -Ikev2ChildSaSessionLookupByMid ( - IN LIST_ENTRY *SaSessionList, - IN UINT32 Mid - ); /** Insert a Child SA Session into the specified ChildSa list.. @@ -XXX,XX +XXX,XX @@ Ikev2ChildSaSessionRemove ( IN UINT8 ListType ); -/** - Mark a specified Child SA Session as on deleting. - - @param[in] ChildSaSession Pointer to IKEV2_CHILD_SA_SESSION. - - @retval EFI_SUCCESS Operation is successful. - -**/ -EFI_STATUS -Ikev2ChildSaSessionOnDeleting ( - IN IKEV2_CHILD_SA_SESSION *ChildSaSession - ); /** Free the memory located for the specified IKEV2_CHILD_SA_SESSION. @@ -XXX,XX +XXX,XX @@ Ikev2ChildExchangeRequestType( IN IKE_PACKET *IkePacket ); -/** - This function finds the SPI from Create Child Sa Exchange Packet. - - @param[in] IkePacket Pointer to IKE_PACKET to be searched. - - @retval SPI number. - -**/ -UINT32 -Ikev2ChildExchangeRekeySpi( - IN IKE_PACKET *IkePacket - ); - /** Associate a SPD selector to the Child SA Session. @@ -XXX,XX +XXX,XX @@ Ikev2DecodePacket ( IN UINTN IkeType ); -/** - Save some useful payloads after accepting the Packet. - - @param[in] SessionCommon Pointer to IKEV2_SESSION_COMMON related to the operation. - @param[in] IkePacket Pointer to received IkePacet. - @param[in] IkeType The type used to indicate it is in IkeSa or ChildSa or Info - exchange. - -**/ -VOID -Ikev2OnPacketAccepted ( - IN IKEV2_SESSION_COMMON *SessionCommon, - IN IKE_PACKET *IkePacket, - IN UINT8 IkeType - ); /** Send out IKEV2 packet. -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel The function TcpPawsOK that is never called have been removed. Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Siyuan Fu <siyuan.fu@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li <songpeng.li@intel.com> --- NetworkPkg/TcpDxe/TcpOption.c | 32 +------------------------------- NetworkPkg/TcpDxe/TcpOption.h | 18 +----------------- 2 files changed, 2 insertions(+), 48 deletions(-) diff --git a/NetworkPkg/TcpDxe/TcpOption.c b/NetworkPkg/TcpDxe/TcpOption.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/TcpDxe/TcpOption.c +++ b/NetworkPkg/TcpDxe/TcpOption.c @@ -XXX,XX +XXX,XX @@ /** @file Routines to process TCP option. - Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -XXX,XX +XXX,XX @@ TcpParseOption ( return 0; } - -/** - Check the segment against PAWS. - - @param[in] Tcb Pointer to the TCP_CB of this TCP instance. - @param[in] TSVal The timestamp value. - - @retval 1 The segment passed the PAWS check. - @retval 0 The segment failed to pass the PAWS check. - -**/ -UINT32 -TcpPawsOK ( - IN TCP_CB *Tcb, - IN UINT32 TSVal - ) -{ - // - // PAWS as defined in RFC1323, buggy... - // - if (TCP_TIME_LT (TSVal, Tcb->TsRecent) && - TCP_TIME_LT (Tcb->TsRecentAge + TCP_PAWS_24DAY, mTcpTick) - ) { - - return 0; - - } - - return 1; -} diff --git a/NetworkPkg/TcpDxe/TcpOption.h b/NetworkPkg/TcpDxe/TcpOption.h index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/TcpDxe/TcpOption.h +++ b/NetworkPkg/TcpDxe/TcpOption.h @@ -XXX,XX +XXX,XX @@ /** @file Tcp option's routine header file. - Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -XXX,XX +XXX,XX @@ TcpParseOption ( IN OUT TCP_OPTION *Option ); -/** - Check the segment against PAWS. - - @param[in] Tcb Pointer to the TCP_CB of this TCP instance. - @param[in] TSVal The timestamp value. - - @retval 1 The segment passed the PAWS check. - @retval 0 The segment failed to pass the PAWS check. - -**/ -UINT32 -TcpPawsOK ( - IN TCP_CB *Tcb, - IN UINT32 TSVal - ); - #endif -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel The definition NetLib has been removed. Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Siyuan Fu <siyuan.fu@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li <songpeng.li@intel.com> --- NetworkPkg/TlsDxe/TlsDxe.inf | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/NetworkPkg/TlsDxe/TlsDxe.inf b/NetworkPkg/TlsDxe/TlsDxe.inf index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/TlsDxe/TlsDxe.inf +++ b/NetworkPkg/TlsDxe/TlsDxe.inf @@ -XXX,XX +XXX,XX @@ # This module produces EFI TLS (Transport Layer Security) Protocol and EFI TLS # Service Binding Protocol, to provide TLS services. # -# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR> # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -XXX,XX +XXX,XX @@ BaseLib UefiLib DebugLib - NetLib BaseCryptLib TlsLib -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel The function PxeBcFreeBootFileOption that is never called have been removed. Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Siyuan Fu <siyuan.fu@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li <songpeng.li@intel.com> --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 23 ----------------------- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 10 ---------- 2 files changed, 33 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c @@ -XXX,XX +XXX,XX @@ PxeBcCacheDhcp6Packet ( return EFI_SUCCESS; } - -/** - Free all the nodes in the list for boot file. - - @param[in] Head The pointer to the head of list. - -**/ -VOID -PxeBcFreeBootFileOption ( - IN LIST_ENTRY *Head - ) -{ - LIST_ENTRY *Entry; - LIST_ENTRY *NextEntry; - PXEBC_DHCP6_OPTION_NODE *Node; - - NET_LIST_FOR_EACH_SAFE (Entry, NextEntry, Head) { - Node = NET_LIST_USER_STRUCT (Entry, PXEBC_DHCP6_OPTION_NODE, Link); - RemoveEntryList (Entry); - FreePool (Node); - } -} - /** Retrieve the boot server address using the EFI_DNS6_PROTOCOL. diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h index XXXXXXX..XXXXXXX 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h @@ -XXX,XX +XXX,XX @@ typedef struct { } PXEBC_DHCP6_PACKET_CACHE; -/** - Free all the nodes in the boot file list. - - @param[in] Head The pointer to the head of the list. - -**/ -VOID -PxeBcFreeBootFileOption ( - IN LIST_ENTRY *Head - ); /** -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel