Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 15, 2018 9:46 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v2 22/27] MdeModulePkg HiiDatabaseDxe: Remove a
> redundant function
>
> The function GetStorageWidth that is never called has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Star Zeng <star.zeng at intel.com>
> Reviewed-by: Laszlo Ersek <lersek at redhat.com>
> ---
> .../Universal/HiiDatabaseDxe/ConfigRouting.c | 47 -------------------
> 1 file changed, 47 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index c778cd92f8..39e1811e69 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -3590,53 +3590,6 @@ Done:
> return Status;
> }
>
> -/**
> - Get Data buffer size based on data type.
> -
> - @param ValueType The input data type.
> -
> - @retval The data buffer size for the input type.
> -**/
> -UINT16
> -GetStorageWidth (
> - IN UINT8 ValueType
> - )
> -{
> - UINT16 StorageWidth;
> -
> - switch (ValueType) {
> - case EFI_IFR_NUMERIC_SIZE_1:
> - case EFI_IFR_TYPE_BOOLEAN:
> - StorageWidth = (UINT16) sizeof (UINT8);
> - break;
> -
> - case EFI_IFR_NUMERIC_SIZE_2:
> - StorageWidth = (UINT16) sizeof (UINT16);
> - break;
> -
> - case EFI_IFR_NUMERIC_SIZE_4:
> - StorageWidth = (UINT16) sizeof (UINT32);
> - break;
> -
> - case EFI_IFR_NUMERIC_SIZE_8:
> - StorageWidth = (UINT16) sizeof (UINT64);
> - break;
> -
> - case EFI_IFR_TYPE_TIME:
> - StorageWidth = (UINT16) sizeof (EFI_IFR_TIME);
> - break;
> -
> - case EFI_IFR_TYPE_DATE:
> - StorageWidth = (UINT16) sizeof (EFI_IFR_DATE);
> - break;
> -
> - default:
> - StorageWidth = 0;
> - break;
> - }
> -
> - return StorageWidth;
> -}
>
> /**
> Update the default value in the block data which is used as bit var store.
> --
> 2.18.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel