From nobody Mon May 12 08:30:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1534297628174990.1317845267686; Tue, 14 Aug 2018 18:47:08 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 0F436210F1550; Tue, 14 Aug 2018 18:47:07 -0700 (PDT) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9212B21962301 for ; Tue, 14 Aug 2018 18:47:06 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 18:47:06 -0700 Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga001.fm.intel.com with ESMTP; 14 Aug 2018 18:47:05 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,241,1531810800"; d="scan'208";a="81435053" From: shenglei To: edk2-devel@lists.01.org Date: Wed, 15 Aug 2018 09:45:43 +0800 Message-Id: <20180815014609.19948-2-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180815014609.19948-1-shenglei.zhang@intel.com> References: <20180815014609.19948-1-shenglei.zhang@intel.com> Subject: [edk2] [PATCH v2 01/27] MdeModulePkg CapsuleApp: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Dong , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RDMRC_1 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The function DumpImageAuthentication that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Star Zeng --- .../Application/CapsuleApp/CapsuleDump.c | 31 ------------------- 1 file changed, 31 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModuleP= kg/Application/CapsuleApp/CapsuleDump.c index 45c3ecd050..7a3eb94362 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c @@ -106,37 +106,6 @@ DumpUxCapsule ( Print(L" OffsetY - 0x%x\n", DisplayCapsule->ImagePayload.Offse= tY); } =20 -/** - Dump FMP image authentication information. - - @param[in] Image The FMP capsule image - @param[in] ImageSize The size of the FMP capsule image in bytes. - - @return the size of FMP authentication. -**/ -UINTN -DumpImageAuthentication ( - IN VOID *Image, - IN UINTN ImageSize - ) -{ - EFI_FIRMWARE_IMAGE_AUTHENTICATION *ImageAuthentication; - - ImageAuthentication =3D Image; - if (CompareGuid(&ImageAuthentication->AuthInfo.CertType, &gEfiCertPkcs7G= uid) || - CompareGuid(&ImageAuthentication->AuthInfo.CertType, &gEfiCertTypeRs= a2048Sha256Guid)) { - Print(L"[ImageAuthentication]\n"); - Print(L" MonotonicCount - 0x%lx\n", ImageAuthentication->MonotonicC= ount); - Print(L"WIN_CERTIFICATE:\n"); - Print(L" dwLength - 0x%x\n", ImageAuthentication->AuthInfo.Hd= r.dwLength); - Print(L" wRevision - 0x%x\n", ImageAuthentication->AuthInfo.Hd= r.wRevision); - Print(L" wCertificateType - 0x%x\n", ImageAuthentication->AuthInfo.Hd= r.wCertificateType); - Print(L" CertType - %g\n", &ImageAuthentication->AuthInfo.Cer= tType); - return sizeof(ImageAuthentication->MonotonicCount) + ImageAuthenticati= on->AuthInfo.Hdr.dwLength; - } else { - return 0; - } -} =20 /** Dump a non-nested FMP capsule. --=20 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel