From nobody Mon May 12 13:53:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1534297705465496.51274644926366; Tue, 14 Aug 2018 18:48:25 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 6B0C3210F2039; Tue, 14 Aug 2018 18:47:33 -0700 (PDT) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 54B28210F2039 for ; Tue, 14 Aug 2018 18:47:32 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 18:47:32 -0700 Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga001.fm.intel.com with ESMTP; 14 Aug 2018 18:47:31 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,241,1531810800"; d="scan'208";a="81435183" From: shenglei To: edk2-devel@lists.01.org Date: Wed, 15 Aug 2018 09:46:01 +0800 Message-Id: <20180815014609.19948-20-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180815014609.19948-1-shenglei.zhang@intel.com> References: <20180815014609.19948-1-shenglei.zhang@intel.com> Subject: [edk2] [PATCH v2 19/27] MdeModulePkg EmmcBlockIoPei: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Dong , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RDMRC_1 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The function EmmcPeimUnlinkMemBlock that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 v2: Remove the comment that mentioned 'EmmcPeimUnlinkMemBlock' within function EmmcPeimFreeMemPool(). Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Hao Wu Reviewed-by: Star Zeng --- .../Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c b/MdeModulePkg/= Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c index a6f188f385..a55a34a3dc 100644 --- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c +++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c @@ -219,31 +219,7 @@ EmmcPeimIsMemBlockEmpty ( return TRUE; } =20 -/** - Unlink the memory block from the pool's list. - - @param Head The block list head of the memory's pool. - @param BlockToUnlink The memory block to unlink. =20 -**/ -VOID -EmmcPeimUnlinkMemBlock ( - IN EMMC_PEIM_MEM_BLOCK *Head, - IN EMMC_PEIM_MEM_BLOCK *BlockToUnlink - ) -{ - EMMC_PEIM_MEM_BLOCK *Block; - - ASSERT ((Head !=3D NULL) && (BlockToUnlink !=3D NULL)); - - for (Block =3D Head; Block !=3D NULL; Block =3D Block->Next) { - if (Block->Next =3D=3D BlockToUnlink) { - Block->Next =3D BlockToUnlink->Next; - BlockToUnlink->Next =3D NULL; - break; - } - } -} =20 /** Initialize the memory management pool for the host controller. @@ -305,8 +281,6 @@ EmmcPeimFreeMemPool ( =20 // // Unlink all the memory blocks from the pool, then free them. - // EmmcPeimUnlinkMemBlock can't be used to unlink and free the - // first block. // for (Block =3D Pool->Head->Next; Block !=3D NULL; Block =3D Pool->Head->= Next) { EmmcPeimFreeMemBlock (Pool, Block); --=20 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel