[v4] Change CpuS3Data memory type and address limitation

[edk2] [Patch v4 0/5] Change CpuS3Data memory type and address limitation

Posted by Eric Dong 5 years, 8 months ago

Because CpuS3Data memory will be copy to smram at SmmReadToLock point by PiSmmCpuDxeSmm driver, the memory type no need to be ACPI NVS type, also the address not limit to below 4G.

This change remove the limit of ACPI NVS memory type and below 4G.

Cc: Marvin H user <Marvin.Haeuser@outlook.com>
Cc: Fan Jeff <vanjeff_919@hotmail.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>

Eric Dong (5):
  UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT saved in Smram.
  UefiCpuPkg/AcpiCpuData.h: Remove AcpiNVS and Below 4G limitation.
  UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.
  UefiCpuPkg/CpuS3DataDxe: Remove below 4G limitation.
  UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation.

 UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c                |  51 +++++---
 UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf           |   1 +
 UefiCpuPkg/Include/AcpiCpuData.h                   |  34 ++----
 .../DxeRegisterCpuFeaturesLib.c                    |  67 -----------
 .../PeiRegisterCpuFeaturesLib.c                    | 131 ---------------------
 .../RegisterCpuFeaturesLib/RegisterCpuFeatures.h   |  20 ----
 .../RegisterCpuFeaturesLib.c                       |  92 +++++++++++++++
 UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c                  |  31 +++--
 8 files changed, 155 insertions(+), 272 deletions(-)

-- 
2.15.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch v4 0/5] Change CpuS3Data memory type and address limitation

Posted by Laszlo Ersek 5 years, 8 months ago

On 08/15/18 04:14, Eric Dong wrote:
> Because CpuS3Data memory will be copy to smram at SmmReadToLock point by PiSmmCpuDxeSmm driver, the memory type no need to be ACPI NVS type, also the address not limit to below 4G.
> 
> This change remove the limit of ACPI NVS memory type and below 4G.
> 
> Cc: Marvin H user <Marvin.Haeuser@outlook.com>
> Cc: Fan Jeff <vanjeff_919@hotmail.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> Eric Dong (5):
>   UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT saved in Smram.
>   UefiCpuPkg/AcpiCpuData.h: Remove AcpiNVS and Below 4G limitation.
>   UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.
>   UefiCpuPkg/CpuS3DataDxe: Remove below 4G limitation.
>   UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation.
> 
>  UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c                |  51 +++++---
>  UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf           |   1 +
>  UefiCpuPkg/Include/AcpiCpuData.h                   |  34 ++----
>  .../DxeRegisterCpuFeaturesLib.c                    |  67 -----------
>  .../PeiRegisterCpuFeaturesLib.c                    | 131 ---------------------
>  .../RegisterCpuFeaturesLib/RegisterCpuFeatures.h   |  20 ----
>  .../RegisterCpuFeaturesLib.c                       |  92 +++++++++++++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c                  |  31 +++--
>  8 files changed, 155 insertions(+), 272 deletions(-)
> 

Looks like this series is now fully reviewed.

I will now do some regression-testing.

Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch v4 0/5] Change CpuS3Data memory type and address limitation

Posted by Laszlo Ersek 5 years, 8 months ago

On 08/15/18 15:14, Laszlo Ersek wrote:
> On 08/15/18 04:14, Eric Dong wrote:
>> Because CpuS3Data memory will be copy to smram at SmmReadToLock point by PiSmmCpuDxeSmm driver, the memory type no need to be ACPI NVS type, also the address not limit to below 4G.
>>
>> This change remove the limit of ACPI NVS memory type and below 4G.
>>
>> Cc: Marvin H user <Marvin.Haeuser@outlook.com>
>> Cc: Fan Jeff <vanjeff_919@hotmail.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>>
>> Eric Dong (5):
>>   UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT saved in Smram.
>>   UefiCpuPkg/AcpiCpuData.h: Remove AcpiNVS and Below 4G limitation.
>>   UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.
>>   UefiCpuPkg/CpuS3DataDxe: Remove below 4G limitation.
>>   UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation.
>>
>>  UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c                |  51 +++++---
>>  UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf           |   1 +
>>  UefiCpuPkg/Include/AcpiCpuData.h                   |  34 ++----
>>  .../DxeRegisterCpuFeaturesLib.c                    |  67 -----------
>>  .../PeiRegisterCpuFeaturesLib.c                    | 131 ---------------------
>>  .../RegisterCpuFeaturesLib/RegisterCpuFeatures.h   |  20 ----
>>  .../RegisterCpuFeaturesLib.c                       |  92 +++++++++++++++
>>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c                  |  31 +++--
>>  8 files changed, 155 insertions(+), 272 deletions(-)
>>
> 
> Looks like this series is now fully reviewed.
> 
> I will now do some regression-testing.

Tested on the Q35 machine type, built into OVMF with -D SMM_REQUIRE, on
top of commit 22ec06c8aaa1.

I used the tests described here:
<https://github.com/tianocore/tianocore.github.io/wiki/Testing-SMM-with-QEMU,-KVM-and-libvirt>.

- with Linux guests:
  Fedora (IA32); Fedora (IA32X64); RHEL7 (IA32X64)

- with Windows guests (all IA32X64):
  7; Server 2008 R2; 8.1; Server 2012 R2; 10

For patches #1 through #4:
Tested-by: Laszlo Ersek <lersek@redhat.com>

(Patch #5 is not testable with OVMF, because no module in OVMF uses
RegisterCpuFeaturesLib -- the lib class isn't resolved under OvmfPkg/ to
any instance at all.)

Please hold off pushing the series until after the upcoming stable tag.

Thanks,
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel