Fix SMM stack size issue

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue

Posted by Guo, Mang 5 years, 10 months ago

Contributed-under: TianoCore Contribution Agreement 1.1

Signed-off-by: Guo Mang <mang.guo@intel.com>
---
 Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index 6ebbb66..7f44f0a 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -1437,7 +1437,12 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
   #
   MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
   MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
-  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf
+  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf {
+   <PcdsFixedAtBuild>
+     gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000
+  }
+  
+  
   UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf
   MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
   UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf
-- 
2.10.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue

Posted by Kinney, Michael D 5 years, 10 months ago

Guo,

Can you please provide the old size and
the new size in the commit message?

Also, what changed that required a larger
stack?

Thanks,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Guo, Mang
> Sent: Wednesday, May 30, 2018 2:13 AM
> To: edk2-devel@lists.01.org
> Cc: Wei, David <david.wei@intel.com>
> Subject: [edk2] [Patch][edk2-platforms/devel-
> MinnowBoardMax-UDK2017] Fix SMM stack size issue
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> 
> Signed-off-by: Guo Mang <mang.guo@intel.com>
> ---
>  Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 6ebbb66..7f44f0a 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -1437,7 +1437,12 @@
> $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/
> IA32/fTPMInitPeim.inf
>    #
>    MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
>    MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
> -  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf
> +  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf {
> +   <PcdsFixedAtBuild>
> +
> gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000
> +  }
> +
> +
>    UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf
> 
> MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
>    UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf
> --
> 2.10.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue

Posted by Guo, Mang 5 years, 10 months ago

Hi Mike,

Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 version. Because this version OS needs larger SMM stack size to set variable.
SMM stack size was changed from 0x2000 to 0x4000 to fix this issue.

Updated the patch to provide a complete description of the change in the commit message. 


Thanks,
Mang


-----Original Message-----
From: Kinney, Michael D 
Sent: Wednesday, May 30, 2018 11:13 PM
To: Guo, Mang; edk2-devel@lists.01.org; Kinney, Michael D
Cc: Wei, David
Subject: RE: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue

Guo,

Can you please provide the old size and
the new size in the commit message?

Also, what changed that required a larger
stack?

Thanks,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Guo, Mang
> Sent: Wednesday, May 30, 2018 2:13 AM
> To: edk2-devel@lists.01.org
> Cc: Wei, David <david.wei@intel.com>
> Subject: [edk2] [Patch][edk2-platforms/devel-
> MinnowBoardMax-UDK2017] Fix SMM stack size issue
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> 
> Signed-off-by: Guo Mang <mang.guo@intel.com>
> ---
>  Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 6ebbb66..7f44f0a 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -1437,7 +1437,12 @@
> $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/
> IA32/fTPMInitPeim.inf
>    #
>    MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
>    MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
> -  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf
> +  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf {
> +   <PcdsFixedAtBuild>
> +
> gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000
> +  }
> +
> +
>    UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf
> 
> MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
>    UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf
> --
> 2.10.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel