Code miss UINT32 and UINT64 value type setting in
VOID*, like as {UINT32({TRUE})}

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
---
 BaseTools/Source/Python/Common/Expression.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/Python/Common/Expression.py b/BaseTools/Source/Python/Common/Expression.py
index 6a1103df2c..13212b32a9 100644
--- a/BaseTools/Source/Python/Common/Expression.py
+++ b/BaseTools/Source/Python/Common/Expression.py
@@ -874,12 +874,14 @@ class ValueExpressionEx(ValueExpression):
                                 elif Item.startswith('UINT16'):
                                     ItemSize = 2
                                     ValueType = "UINT16"
                                 elif Item.startswith('UINT32'):
                                     ItemSize = 4
+                                    ValueType = "UINT32"
                                 elif Item.startswith('UINT64'):
                                     ItemSize = 8
+                                    ValueType = "UINT64"
                                 else:
                                     ItemSize = 0
                                 if ValueType:
                                     TmpValue = ValueExpressionEx(Item, ValueType, self._Symb)(True)
                                 else:
-- 
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Feng, YunhuaX 
Sent: Friday, February 09, 2018 12:31 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH] BaseTools: Fix VOID* type bug

Code miss UINT32 and UINT64 value type setting in VOID*, like as {UINT32({TRUE})}

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
---
 BaseTools/Source/Python/Common/Expression.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/Python/Common/Expression.py b/BaseTools/Source/Python/Common/Expression.py
index 6a1103df2c..13212b32a9 100644
--- a/BaseTools/Source/Python/Common/Expression.py
+++ b/BaseTools/Source/Python/Common/Expression.py
@@ -874,12 +874,14 @@ class ValueExpressionEx(ValueExpression):
                                 elif Item.startswith('UINT16'):
                                     ItemSize = 2
                                     ValueType = "UINT16"
                                 elif Item.startswith('UINT32'):
                                     ItemSize = 4
+                                    ValueType = "UINT32"
                                 elif Item.startswith('UINT64'):
                                     ItemSize = 8
+                                    ValueType = "UINT64"
                                 else:
                                     ItemSize = 0
                                 if ValueType:
                                     TmpValue = ValueExpressionEx(Item, ValueType, self._Symb)(True)
                                 else:
--
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel