[edk2] [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib.

Marvin Häuser posted 1 patch 5 years, 11 months ago
Failed in applying to current master (apply log)
MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 +
1 file changed, 1 insertion(+)
[edk2] [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib.
Posted by Marvin Häuser 5 years, 11 months ago
UefiDebugLibConOut does currently not consume UefiLib, from which it
uses the Print() function. This commit adds an explicit dependency.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
 MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
index 583872f54e81..64651c4169a8 100644
--- a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
+++ b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
@@ -46,6 +46,7 @@ [LibraryClasses]
   PrintLib
   UefiBootServicesTableLib
   DebugPrintErrorLevelLib
+  UefiLib
 
 [Pcd]
   gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue        ## SOMETIMES_CONSUMES
-- 
2.17.1.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib.
Posted by Gao, Liming 5 years, 11 months ago
UefiDebugLibConOut depends on PrintLib. It doesn't call any API in UefiLib. 

> -----Original Message-----
> From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com]
> Sent: Sunday, June 17, 2018 12:15 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib.
> 
> UefiDebugLibConOut does currently not consume UefiLib, from which it
> uses the Print() function. This commit adds an explicit dependency.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> ---
>  MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> index 583872f54e81..64651c4169a8 100644
> --- a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> +++ b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> @@ -46,6 +46,7 @@ [LibraryClasses]
>    PrintLib
>    UefiBootServicesTableLib
>    DebugPrintErrorLevelLib
> +  UefiLib
> 
>  [Pcd]
>    gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue        ## SOMETIMES_CONSUMES
> --
> 2.17.1.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib.
Posted by Marvin Häuser 5 years, 11 months ago
Sorry, you are right. The linker somehow blamed UefiDebugLibConOut for a module not declaring that dependency.

Regards,
Marvin.

> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Monday, June 18, 2018 4:57 PM
> To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume
> UefiLib.
> 
> UefiDebugLibConOut depends on PrintLib. It doesn't call any API in UefiLib.
> 
> > -----Original Message-----
> > From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com]
> > Sent: Sunday, June 17, 2018 12:15 AM
> > To: edk2-devel@lists.01.org
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume
> UefiLib.
> >
> > UefiDebugLibConOut does currently not consume UefiLib, from which it
> > uses the Print() function. This commit adds an explicit dependency.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> > ---
> >  MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> > b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> > index 583872f54e81..64651c4169a8 100644
> > --- a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> > +++ b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> > @@ -46,6 +46,7 @@ [LibraryClasses]
> >    PrintLib
> >    UefiBootServicesTableLib
> >    DebugPrintErrorLevelLib
> > +  UefiLib
> >
> >  [Pcd]
> >    gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue        ##
> SOMETIMES_CONSUMES
> > --
> > 2.17.1.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel