MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 323 +++++++++++- MdeModulePkg/Universal/Disk/UdfDxe/File.c | 13 +- MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 515 ++++++++------------ MdeModulePkg/Universal/Disk/UdfDxe/Udf.c | 7 - MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 88 +--- MdePkg/Include/IndustryStandard/Udf.h | 63 +++ 6 files changed, 566 insertions(+), 443 deletions(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=707 Hi, This patchset fixes a bug in Partition driver that UDF partitions occupied the entire disk space instead of using LVD space only. BTW, I've only tested it under OVMF and built it with GCC only. That would be appreciable if someone could build with other toolchains and see if this doesn't break. I used a Windows 10 ISO image with UdfDxe disabled and enabled. The `map -r` output seemed OK. No breakage when booting an OS off an ElTorito partition from an UDF bridge disk. v1->v2: - Followed Laszlo's suggestions to submit a proper patchset. Thanks! - As I'm still waiting for Ruiyu and Star to test this fix, I took advantage of it and did some code cleanups :-) Repo: https://github.com/pcacjr/edk2.git Branch: udf-partition-fix-v2 Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <liming.gao@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Ruiyu Ni <ruiyu.ni@intel.com> Cc: Star Zeng <star.zeng@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Reported-by: Ruiyu Ni <ruiyu.ni@intel.com> Signed-off-by: Paulo Alcantara <pcacjr@zytor.com> --- Paulo Alcantara (3): MdePkg: Add UDF volume structure definitions MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 323 +++++++++++- MdeModulePkg/Universal/Disk/UdfDxe/File.c | 13 +- MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 515 ++++++++------------ MdeModulePkg/Universal/Disk/UdfDxe/Udf.c | 7 - MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 88 +--- MdePkg/Include/IndustryStandard/Udf.h | 63 +++ 6 files changed, 566 insertions(+), 443 deletions(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Paulo, Could you please paste a "map -r" output on a CDROM which contains Eltorito volume? I want to confirm that the result is expected. Thanks/Ray > -----Original Message----- > From: Paulo Alcantara [mailto:pcacjr@zytor.com] > Sent: Sunday, September 17, 2017 9:13 PM > To: edk2-devel@lists.01.org > Cc: Paulo Alcantara <pcacjr@zytor.com>; Kinney, Michael D > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Laszlo > Ersek <lersek@redhat.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star > <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com> > Subject: [PATCH v2 0/3] UDF partition driver fix > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=707 > > Hi, > > This patchset fixes a bug in Partition driver that UDF partitions occupied the > entire disk space instead of using LVD space only. > > BTW, I've only tested it under OVMF and built it with GCC only. That would > be appreciable if someone could build with other toolchains and see if this > doesn't break. > > I used a Windows 10 ISO image with UdfDxe disabled and enabled. The `map > -r` output seemed OK. No breakage when booting an OS off an ElTorito > partition from an UDF bridge disk. > > v1->v2: > - Followed Laszlo's suggestions to submit a proper patchset. Thanks! > - As I'm still waiting for Ruiyu and Star to test this fix, I took > advantage of it and did some code cleanups :-) > > Repo: https://github.com/pcacjr/edk2.git > Branch: udf-partition-fix-v2 > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Laszlo Ersek <lersek@redhat.com> > Cc: Ruiyu Ni <ruiyu.ni@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Reported-by: Ruiyu Ni <ruiyu.ni@intel.com> > Signed-off-by: Paulo Alcantara <pcacjr@zytor.com> > --- > > Paulo Alcantara (3): > MdePkg: Add UDF volume structure definitions > MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition > MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes > > MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 323 > +++++++++++- > MdeModulePkg/Universal/Disk/UdfDxe/File.c | 13 +- > MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 515 > ++++++++------------ > MdeModulePkg/Universal/Disk/UdfDxe/Udf.c | 7 - > MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 88 +--- > MdePkg/Include/IndustryStandard/Udf.h | 63 +++ > 6 files changed, 566 insertions(+), 443 deletions(-) > > -- > 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Hi Ruiyu, On 9/18/2017 1:52 AM, Ni, Ruiyu wrote: > Paulo, > Could you please paste a "map -r" output on a CDROM which > contains Eltorito volume? > I want to confirm that the result is expected. With UdfDxe driver disabled in OVMF: >Mapping table > FS0: Alias(s):CD0c65535a1:;BLK2: > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/CDROM(0x1) > BLK0: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0) > BLK1: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/CDROM(0x0) > BLK3: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/VenMedia(C5BD4D42-1A76-4996-8956-73CDA326CD0A) With UdfDxe driver enabled in OVMF: > Mapping table > FS0: Alias(s):CD0c65535a1:;BLK2: > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/CDROM(0x1) > FS1: Alias(s):F0c65535a:;BLK3: > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/VenMedia(C5BD4D42-1A76-4996-8956-73CDA326CD0A) > BLK0: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0) > BLK1: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/CDROM(0x0) Thanks! Paulo > > Thanks/Ray > >> -----Original Message----- >> From: Paulo Alcantara [mailto:pcacjr@zytor.com] >> Sent: Sunday, September 17, 2017 9:13 PM >> To: edk2-devel@lists.01.org >> Cc: Paulo Alcantara <pcacjr@zytor.com>; Kinney, Michael D >> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Laszlo >> Ersek <lersek@redhat.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star >> <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com> >> Subject: [PATCH v2 0/3] UDF partition driver fix >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=707 >> >> Hi, >> >> This patchset fixes a bug in Partition driver that UDF partitions occupied the >> entire disk space instead of using LVD space only. >> >> BTW, I've only tested it under OVMF and built it with GCC only. That would >> be appreciable if someone could build with other toolchains and see if this >> doesn't break. >> >> I used a Windows 10 ISO image with UdfDxe disabled and enabled. The `map >> -r` output seemed OK. No breakage when booting an OS off an ElTorito >> partition from an UDF bridge disk. >> >> v1->v2: >> - Followed Laszlo's suggestions to submit a proper patchset. Thanks! >> - As I'm still waiting for Ruiyu and Star to test this fix, I took >> advantage of it and did some code cleanups :-) >> >> Repo: https://github.com/pcacjr/edk2.git >> Branch: udf-partition-fix-v2 >> >> Cc: Michael D Kinney <michael.d.kinney@intel.com> >> Cc: Liming Gao <liming.gao@intel.com> >> Cc: Laszlo Ersek <lersek@redhat.com> >> Cc: Ruiyu Ni <ruiyu.ni@intel.com> >> Cc: Star Zeng <star.zeng@intel.com> >> Cc: Jiewen Yao <jiewen.yao@intel.com> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Reported-by: Ruiyu Ni <ruiyu.ni@intel.com> >> Signed-off-by: Paulo Alcantara <pcacjr@zytor.com> >> --- >> >> Paulo Alcantara (3): >> MdePkg: Add UDF volume structure definitions >> MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition >> MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes >> >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 323 >> +++++++++++- >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 13 +- >> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 515 >> ++++++++------------ >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.c | 7 - >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 88 +--- >> MdePkg/Include/IndustryStandard/Udf.h | 63 +++ >> 6 files changed, 566 insertions(+), 443 deletions(-) >> >> -- >> 2.11.0 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
© 2016 - 2024 Red Hat, Inc.