BaseTools: improve reuse and remove dead code

[edk2] [PATCH v1 0/5] BaseTools: improve reuse and remove dead code

Posted by Jaben Carsey 6 years, 9 months ago

remove class and function definitions that are never used
re-use existing regular expressions instead of compiling
use string format instead of eval()

Jaben Carsey (5):
  BaseTools: StrGather has redundant declaration
  BaseTools: StrGather simplify string/int conversion functions
  BaseTools: StrGather remove functions no one calls
  BaseTools: FdfParser & FdfParserLite refactor regular expression for
    GUIDs
  BaseTools: FdfParser remove class never used.

 BaseTools/Source/Python/AutoGen/StrGather.py    | 57 +++-----------------
 BaseTools/Source/Python/Common/FdfParserLite.py |  4 +-
 BaseTools/Source/Python/GenFds/FdfParser.py     | 19 +------
 3 files changed, 10 insertions(+), 70 deletions(-)

-- 
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 0/5] BaseTools: improve reuse and remove dead code

Posted by Zhu, Yonghong 6 years, 9 months ago

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
I will push this series patch.

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Friday, March 16, 2018 5:39 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/5] BaseTools: improve reuse and remove dead code

remove class and function definitions that are never used re-use existing regular expressions instead of compiling use string format instead of eval()

Jaben Carsey (5):
  BaseTools: StrGather has redundant declaration
  BaseTools: StrGather simplify string/int conversion functions
  BaseTools: StrGather remove functions no one calls
  BaseTools: FdfParser & FdfParserLite refactor regular expression for
    GUIDs
  BaseTools: FdfParser remove class never used.

 BaseTools/Source/Python/AutoGen/StrGather.py    | 57 +++-----------------
 BaseTools/Source/Python/Common/FdfParserLite.py |  4 +-
 BaseTools/Source/Python/GenFds/FdfParser.py     | 19 +------
 3 files changed, 10 insertions(+), 70 deletions(-)

--
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel