[edk2] [PATCH v1 0/9] BaseTools: refactoring

Jaben Carsey posted 9 patches 6 years ago
Failed in applying to current master (apply log)
BaseTools/Source/Python/GenFds/DepexSection.py    |  14 +-
BaseTools/Source/Python/GenFds/FdfParser.py       |  20 +--
BaseTools/Source/Python/GenFds/FfsInfStatement.py |  27 +---
BaseTools/Source/Python/Workspace/DscBuildData.py | 146 +++++++++-----------
BaseTools/Source/Python/build/build.py            |   4 +-
5 files changed, 87 insertions(+), 124 deletions(-)
[edk2] [PATCH v1 0/9] BaseTools: refactoring
Posted by Jaben Carsey 6 years ago
group of patches for refactoring BaseTools.  removing unused functions, 
variables, and parameters.  make functions statis where apropriate.

Jaben (9):
  BaseTools: remove unused local variable.
  BaseTools: change DscBuildData functions without need for self to
    staticmethod
  BaseTools: Remove unused functions from DscBuildData
  BaseTools: move RegEx compile out of loops
  BaseTools: use dictionary.get() when we have value if not found
  BaseTools: refactor DepexSection.GenSection
  BaseTools: FdfParser refactor to remove a dictionary
  BaseTools: FdfParser - refactor functions to make static
  BaseTools: FfsInfStatement - remove unused function

 BaseTools/Source/Python/GenFds/DepexSection.py    |  14 +-
 BaseTools/Source/Python/GenFds/FdfParser.py       |  20 +--
 BaseTools/Source/Python/GenFds/FfsInfStatement.py |  27 +---
 BaseTools/Source/Python/Workspace/DscBuildData.py | 146 +++++++++-----------
 BaseTools/Source/Python/build/build.py            |   4 +-
 5 files changed, 87 insertions(+), 124 deletions(-)

-- 
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v1 0/9] BaseTools: refactoring
Posted by Zhu, Yonghong 6 years ago
Reviewed this series patch.
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Saturday, April 14, 2018 4:51 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/9] BaseTools: refactoring

group of patches for refactoring BaseTools.  removing unused functions, variables, and parameters.  make functions statis where apropriate.

Jaben (9):
  BaseTools: remove unused local variable.
  BaseTools: change DscBuildData functions without need for self to
    staticmethod
  BaseTools: Remove unused functions from DscBuildData
  BaseTools: move RegEx compile out of loops
  BaseTools: use dictionary.get() when we have value if not found
  BaseTools: refactor DepexSection.GenSection
  BaseTools: FdfParser refactor to remove a dictionary
  BaseTools: FdfParser - refactor functions to make static
  BaseTools: FfsInfStatement - remove unused function

 BaseTools/Source/Python/GenFds/DepexSection.py    |  14 +-
 BaseTools/Source/Python/GenFds/FdfParser.py       |  20 +--
 BaseTools/Source/Python/GenFds/FfsInfStatement.py |  27 +---  BaseTools/Source/Python/Workspace/DscBuildData.py | 146 +++++++++-----------
 BaseTools/Source/Python/build/build.py            |   4 +-
 5 files changed, 87 insertions(+), 124 deletions(-)

--
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel