[edk2] [PATCH v1 31/42] BaseTools: remove redundant content in InfSectionParser

Jaben Carsey posted 42 patches 7 years, 9 months ago
[edk2] [PATCH v1 31/42] BaseTools: remove redundant content in InfSectionParser
Posted by Jaben Carsey 7 years, 9 months ago
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/AutoGen/InfSectionParser.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/InfSectionParser.py b/BaseTools/Source/Python/AutoGen/InfSectionParser.py
index cf4e76159e81..2cd5a6667a02 100644
--- a/BaseTools/Source/Python/AutoGen/InfSectionParser.py
+++ b/BaseTools/Source/Python/AutoGen/InfSectionParser.py
@@ -26,7 +26,6 @@ class InfSectionParser():
         self._ParserInf()
     
     def _ParserInf(self):
-        Filename = self._FilePath
         FileLinesList = []
         UserExtFind = False
         FindEnd = True
@@ -35,9 +34,9 @@ class InfSectionParser():
         SectionData = []
         
         try:
-            FileLinesList = open(Filename, "r", 0).readlines()
+            FileLinesList = open(self._FilePath, "r", 0).readlines()
         except BaseException:
-            EdkLogger.error("build", AUTOGEN_ERROR, 'File %s is opened failed.' % Filename)
+            EdkLogger.error("build", AUTOGEN_ERROR, 'File %s is opened failed.' % self._FilePath)
         
         for Index in range(0, len(FileLinesList)):
             line = str(FileLinesList[Index]).strip()
@@ -49,7 +48,7 @@ class InfSectionParser():
             if UserExtFind and FindEnd == False:
                 if line:
                     SectionData.append(line)
-            if line.lower().startswith(TAB_SECTION_START) and line.lower().endswith(TAB_SECTION_END):
+            if line.startswith(TAB_SECTION_START) and line.endswith(TAB_SECTION_END):
                 SectionLine = line
                 UserExtFind = True
                 FindEnd = False
@@ -59,7 +58,7 @@ class InfSectionParser():
                 UserExtFind = False
                 FindEnd = True
                 self._FileSectionDataList.append({SectionLine: SectionData[:]})
-                SectionData = []
+                del SectionData[:]
                 SectionLine = ''
     
     # Get user extension TianoCore data
-- 
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel