[edk2] [PATCH v1 0/2] BaseTools: cleanup for speed

Jaben Carsey posted 2 patches 5 years, 11 months ago
Failed in applying to current master (apply log)
BaseTools/Source/Python/AutoGen/AutoGen.py             | 500 +++++++-------------
BaseTools/Source/Python/AutoGen/GenC.py                |   2 +-
BaseTools/Source/Python/AutoGen/GenMake.py             |   4 +-
BaseTools/Source/Python/AutoGen/GenPcdDb.py            |  14 +-
BaseTools/Source/Python/AutoGen/GenVar.py              |   2 +-
BaseTools/Source/Python/AutoGen/StrGather.py           |   8 +-
BaseTools/Source/Python/Common/Misc.py                 |   2 +-
BaseTools/Source/Python/Common/String.py               |   2 +-
BaseTools/Source/Python/Common/VpdInfoFile.py          |   2 +-
BaseTools/Source/Python/GenFds/FdfParser.py            |   8 +-
BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 119 +++--
BaseTools/Source/Python/Workspace/WorkspaceCommon.py   |  52 +-
BaseTools/Source/Python/build/BuildReport.py           |  26 +-
BaseTools/Source/Python/build/build.py                 |   6 +-
14 files changed, 291 insertions(+), 456 deletions(-)
[edk2] [PATCH v1 0/2] BaseTools: cleanup for speed
Posted by Jaben Carsey 5 years, 11 months ago
the first patch merges 2 almost identical functions by moving optional output
to the WorkspaceCommon version and then calls it from AutoGen.

the second patch is lots of small cleanups.

Jaben Carsey (2):
  BaseTools: refactor to remove functions
  BaseTools: Cleanup unneeded code

 BaseTools/Source/Python/AutoGen/AutoGen.py             | 500 +++++++-------------
 BaseTools/Source/Python/AutoGen/GenC.py                |   2 +-
 BaseTools/Source/Python/AutoGen/GenMake.py             |   4 +-
 BaseTools/Source/Python/AutoGen/GenPcdDb.py            |  14 +-
 BaseTools/Source/Python/AutoGen/GenVar.py              |   2 +-
 BaseTools/Source/Python/AutoGen/StrGather.py           |   8 +-
 BaseTools/Source/Python/Common/Misc.py                 |   2 +-
 BaseTools/Source/Python/Common/String.py               |   2 +-
 BaseTools/Source/Python/Common/VpdInfoFile.py          |   2 +-
 BaseTools/Source/Python/GenFds/FdfParser.py            |   8 +-
 BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 119 +++--
 BaseTools/Source/Python/Workspace/WorkspaceCommon.py   |  52 +-
 BaseTools/Source/Python/build/BuildReport.py           |  26 +-
 BaseTools/Source/Python/build/build.py                 |   6 +-
 14 files changed, 291 insertions(+), 456 deletions(-)

-- 
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v1 0/2] BaseTools: cleanup for speed
Posted by Zhu, Yonghong 5 years, 10 months ago
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Friday, May 18, 2018 8:07 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/2] BaseTools: cleanup for speed

the first patch merges 2 almost identical functions by moving optional output to the WorkspaceCommon version and then calls it from AutoGen.

the second patch is lots of small cleanups.

Jaben Carsey (2):
  BaseTools: refactor to remove functions
  BaseTools: Cleanup unneeded code

 BaseTools/Source/Python/AutoGen/AutoGen.py             | 500 +++++++-------------
 BaseTools/Source/Python/AutoGen/GenC.py                |   2 +-
 BaseTools/Source/Python/AutoGen/GenMake.py             |   4 +-
 BaseTools/Source/Python/AutoGen/GenPcdDb.py            |  14 +-
 BaseTools/Source/Python/AutoGen/GenVar.py              |   2 +-
 BaseTools/Source/Python/AutoGen/StrGather.py           |   8 +-
 BaseTools/Source/Python/Common/Misc.py                 |   2 +-
 BaseTools/Source/Python/Common/String.py               |   2 +-
 BaseTools/Source/Python/Common/VpdInfoFile.py          |   2 +-
 BaseTools/Source/Python/GenFds/FdfParser.py            |   8 +-
 BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 119 +++--
 BaseTools/Source/Python/Workspace/WorkspaceCommon.py   |  52 +-
 BaseTools/Source/Python/build/BuildReport.py           |  26 +-
 BaseTools/Source/Python/build/build.py                 |   6 +-
 14 files changed, 291 insertions(+), 456 deletions(-)

--
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel