Instead of testing each equality individually, just make a set and test once.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/Ecc/Configuration.py | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/BaseTools/Source/Python/Ecc/Configuration.py b/BaseTools/Source/Python/Ecc/Configuration.py
index 217b60f4f319..8f4426c20421 100644
--- a/BaseTools/Source/Python/Ecc/Configuration.py
+++ b/BaseTools/Source/Python/Ecc/Configuration.py
@@ -404,17 +404,9 @@ class Configuration(object):
                     ErrorMsg = "Invalid configuration option '%s' was found" % List[0]
                     EdkLogger.error("Ecc", EdkLogger.ECC_ERROR, ErrorMsg, File = Filepath, Line = LineNo)
                 assert _ConfigFileToInternalTranslation[List[0]] in self.__dict__
-                if List[0] == 'ModifierList':
-                    List[1] = GetSplitValueList(List[1], TAB_COMMA_SPLIT)
                 if List[0] == 'MetaDataFileCheckPathOfGenerateFileList' and List[1] == "":
                     continue
-                if List[0] == 'SkipDirList':
-                    List[1] = GetSplitValueList(List[1], TAB_COMMA_SPLIT)
-                if List[0] == 'SkipFileList':
-                    List[1] = GetSplitValueList(List[1], TAB_COMMA_SPLIT)
-                if List[0] == 'BinaryExtList':
-                    List[1] = GetSplitValueList(List[1], TAB_COMMA_SPLIT)
-                if List[0] == 'Copyright':
+                if List[0] in {'ModifierList','SkipDirList','SkipFileList','BinaryExtList','Copyright'}:
                     List[1] = GetSplitValueList(List[1], TAB_COMMA_SPLIT)
                 self.__dict__[_ConfigFileToInternalTranslation[List[0]]] = List[1]
 
-- 
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel