[libvirt] [PATCH] tests: Link virusbmock with probes

John Ferlan posted 1 patch 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1486731894-11777-1-git-send-email-jferlan@redhat.com
tests/Makefile.am | 1 +
1 file changed, 1 insertion(+)
[libvirt] [PATCH] tests: Link virusbmock with probes
Posted by John Ferlan 7 years, 1 month ago
Seeing similar error to commit id '997be5c27' with the inability
to find the libvirt_event_poll_purge_timeout_semaphore symbol
causing a virusbtest failure.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

 This is a really strange one... I applied Michal's patches, the error
occurred. I rebuilt cleanly and the error went away. This morning after
apply the top of tree, the error returns. Just changing the Makefile.am
doesn't always "clean" up the error, but after a make clean and rebuild
the error goes away.  Perhaps has to do with some build dependency on
the virusbmock that virusbtest has that somehow isn't being recognized
in the Makefile.am... But I'm not sure what magic incantation needs to
be levied at the Makefile.am in order to tell it to do the right thing!

 tests/Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7149a86..32a7282 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1204,6 +1204,7 @@ virusbmock_la_SOURCES = virusbmock.c
 virusbmock_la_CFLAGS = $(AM_CFLAGS)
 virusbmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS)
 virusbmock_la_LIBADD = $(MOCKLIBS_LIBS) \
+	$(PROBES_O) \
 	../src/libvirt_util.la
 
 virnetdevbandwidthmock_la_SOURCES = \
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tests: Link virusbmock with probes
Posted by Boris Fiuczynski 7 years, 1 month ago
On 02/10/2017 02:04 PM, John Ferlan wrote:
> Seeing similar error to commit id '997be5c27' with the inability
> to find the libvirt_event_poll_purge_timeout_semaphore symbol
> causing a virusbtest failure.
>
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
>
>  This is a really strange one... I applied Michal's patches, the error
> occurred. I rebuilt cleanly and the error went away. This morning after
> apply the top of tree, the error returns. Just changing the Makefile.am
> doesn't always "clean" up the error, but after a make clean and rebuild
> the error goes away.  Perhaps has to do with some build dependency on
> the virusbmock that virusbtest has that somehow isn't being recognized
> in the Makefile.am... But I'm not sure what magic incantation needs to
> be levied at the Makefile.am in order to tell it to do the right thing!
>
>  tests/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 7149a86..32a7282 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -1204,6 +1204,7 @@ virusbmock_la_SOURCES = virusbmock.c
>  virusbmock_la_CFLAGS = $(AM_CFLAGS)
>  virusbmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS)
>  virusbmock_la_LIBADD = $(MOCKLIBS_LIBS) \
> +	$(PROBES_O) \
>  	../src/libvirt_util.la
>
>  virnetdevbandwidthmock_la_SOURCES = \
>
Hi John,
your patch worked for me.

Tested-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>


-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tests: Link virusbmock with probes
Posted by Michal Privoznik 7 years, 1 month ago
On 02/10/2017 02:04 PM, John Ferlan wrote:
> Seeing similar error to commit id '997be5c27' with the inability
> to find the libvirt_event_poll_purge_timeout_semaphore symbol
> causing a virusbtest failure.
> 
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
> 
>  This is a really strange one... I applied Michal's patches, the error
> occurred. I rebuilt cleanly and the error went away. This morning after
> apply the top of tree, the error returns. Just changing the Makefile.am
> doesn't always "clean" up the error, but after a make clean and rebuild
> the error goes away.  Perhaps has to do with some build dependency on
> the virusbmock that virusbtest has that somehow isn't being recognized
> in the Makefile.am... But I'm not sure what magic incantation needs to
> be levied at the Makefile.am in order to tell it to do the right thing!
> 
>  tests/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 7149a86..32a7282 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -1204,6 +1204,7 @@ virusbmock_la_SOURCES = virusbmock.c
>  virusbmock_la_CFLAGS = $(AM_CFLAGS)
>  virusbmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS)
>  virusbmock_la_LIBADD = $(MOCKLIBS_LIBS) \
> +	$(PROBES_O) \
>  	../src/libvirt_util.la
>  
>  virnetdevbandwidthmock_la_SOURCES = \
> 

ACK.

I've installed systemtap and can confirm this fixes the problem.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list