[libvirt] [RFC v2 0/2] vireventpoll implimentation using epoll

Derbyshev Dmitriy posted 2 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1487095461-12268-1-git-send-email-dderbyshev@virtuozzo.com
configure.ac                                      |  28 +
src/Makefile.am                                   |  12 +-
src/util/vireventepoll.c                          | 201 +++++++
src/util/vireventpoll.c                           | 700 ++--------------------
src/util/{vireventpoll.c => vireventpollcommon.c} | 231 ++-----
src/util/vireventpollinternal.h                   |  91 +++
tests/commanddata/{test14.log => test3epoll.log}  |   2 +
tests/commandtest.c                               |   4 +
8 files changed, 451 insertions(+), 818 deletions(-)
create mode 100644 src/util/vireventepoll.c
copy src/util/{vireventpoll.c => vireventpollcommon.c} (78%)
create mode 100644 src/util/vireventpollinternal.h
copy tests/commanddata/{test14.log => test3epoll.log} (94%)
[libvirt] [RFC v2 0/2] vireventpoll implimentation using epoll
Posted by Derbyshev Dmitriy 7 years, 1 month ago
From: Derbyshev Dmitry <dderbyshev@virtuozzo.com>

Provides about 20% boost on local machine with 35 vms.
virEventPollDispatchHandles can also be split to pass cb via epoll 
data field.

Should start sending as PATCH instead?

Changes since v1:
 * ifdef supstituded by 2 .c files with vireventpollinternal.h
   implementations
 * PROBE purged

Derbyshev Dmitry (2):
  vireventpoll: isolate common code
  vireventpoll implimentation using epoll

 configure.ac                                      |  28 +
 src/Makefile.am                                   |  12 +-
 src/util/vireventepoll.c                          | 201 +++++++
 src/util/vireventpoll.c                           | 700 ++--------------------
 src/util/{vireventpoll.c => vireventpollcommon.c} | 231 ++-----
 src/util/vireventpollinternal.h                   |  91 +++
 tests/commanddata/{test14.log => test3epoll.log}  |   2 +
 tests/commandtest.c                               |   4 +
 8 files changed, 451 insertions(+), 818 deletions(-)
 create mode 100644 src/util/vireventepoll.c
 copy src/util/{vireventpoll.c => vireventpollcommon.c} (78%)
 create mode 100644 src/util/vireventpollinternal.h
 copy tests/commanddata/{test14.log => test3epoll.log} (94%)

-- 
1.9.5.msysgit.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC v2 0/2] vireventpoll implimentation using epoll
Posted by Dmitry Derbyshev 7 years, 1 month ago
Ping.
Also, noticed that I renamed patch series, old name was "Substitute poll 
by epoll in virEventPollRunOnce". My bad.

/14/2017 9:04 PM, Derbyshev Dmitriy пишет:
> From: Derbyshev Dmitry <dderbyshev@virtuozzo.com>
>
> Provides about 20% boost on local machine with 35 vms.
> virEventPollDispatchHandles can also be split to pass cb via epoll
> data field.
>
> Should start sending as PATCH instead?
>
> Changes since v1:
>   * ifdef supstituded by 2 .c files with vireventpollinternal.h
>     implementations
>   * PROBE purged
>
> Derbyshev Dmitry (2):
>    vireventpoll: isolate common code
>    vireventpoll implimentation using epoll
>
>   configure.ac                                      |  28 +
>   src/Makefile.am                                   |  12 +-
>   src/util/vireventepoll.c                          | 201 +++++++
>   src/util/vireventpoll.c                           | 700 ++--------------------
>   src/util/{vireventpoll.c => vireventpollcommon.c} | 231 ++-----
>   src/util/vireventpollinternal.h                   |  91 +++
>   tests/commanddata/{test14.log => test3epoll.log}  |   2 +
>   tests/commandtest.c                               |   4 +
>   8 files changed, 451 insertions(+), 818 deletions(-)
>   create mode 100644 src/util/vireventepoll.c
>   copy src/util/{vireventpoll.c => vireventpollcommon.c} (78%)
>   create mode 100644 src/util/vireventpollinternal.h
>   copy tests/commanddata/{test14.log => test3epoll.log} (94%)
>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC v2 0/2] vireventpoll implimentation using epoll
Posted by Maxim Nestratov 7 years ago
22-Feb-17 17:35, Dmitry Derbyshev пишет:

> Ping.
> Also, noticed that I renamed patch series, old name was "Substitute poll by epoll in virEventPollRunOnce". My bad.
>

A few issues required to be fixed to make 'make syntax-check' pass. Otherwise looks good to me.

Maxim

> /14/2017 9:04 PM, Derbyshev Dmitriy пишет:
>> From: Derbyshev Dmitry <dderbyshev@virtuozzo.com>
>>
>> Provides about 20% boost on local machine with 35 vms.
>> virEventPollDispatchHandles can also be split to pass cb via epoll
>> data field.
>>
>> Should start sending as PATCH instead?
>>
>> Changes since v1:
>>   * ifdef supstituded by 2 .c files with vireventpollinternal.h
>>     implementations
>>   * PROBE purged
>>
>> Derbyshev Dmitry (2):
>>    vireventpoll: isolate common code
>>    vireventpoll implimentation using epoll
>>
>>   configure.ac                                      |  28 +
>>   src/Makefile.am                                   |  12 +-
>>   src/util/vireventepoll.c                          | 201 +++++++
>>   src/util/vireventpoll.c                           | 700 ++--------------------
>>   src/util/{vireventpoll.c => vireventpollcommon.c} | 231 ++-----
>>   src/util/vireventpollinternal.h                   |  91 +++
>>   tests/commanddata/{test14.log => test3epoll.log}  |   2 +
>>   tests/commandtest.c                               |   4 +
>>   8 files changed, 451 insertions(+), 818 deletions(-)
>>   create mode 100644 src/util/vireventepoll.c
>>   copy src/util/{vireventpoll.c => vireventpollcommon.c} (78%)
>>   create mode 100644 src/util/vireventpollinternal.h
>>   copy tests/commanddata/{test14.log => test3epoll.log} (94%)
>>
>
> -- 
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list