---
 docs/news.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 8f6b768..593cc52 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -176,6 +176,16 @@
           qemu: Do not crash on USB address with no port and invalid bus
         </summary>
       </change>
+      <change>
+        <summary>
+          crypto: Always pad data before encrypting it
+        </summary>
+        <description>
+          If this step is not performed, when the data length matches the
+          chunk size the decryption routines will misinterpret the last byte
+          of data as the padding lenght and fail to decode it correctly.
+        </description>
+      </change>
     </section>
   </release>
   <release version="v3.2.0" date="2017-04-02">
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, May 03, 2017 at 06:03:23PM +0200, Andrea Bolognani wrote:
>---
> docs/news.xml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/docs/news.xml b/docs/news.xml
>index 8f6b768..593cc52 100644
>--- a/docs/news.xml
>+++ b/docs/news.xml
>@@ -176,6 +176,16 @@
>           qemu: Do not crash on USB address with no port and invalid bus
>         </summary>
>       </change>
>+      <change>
>+        <summary>
>+          crypto: Always pad data before encrypting it
>+        </summary>
>+        <description>
>+          If this step is not performed, when the data length matches the
>+          chunk size the decryption routines will misinterpret the last byte
>+          of data as the padding lenght and fail to decode it correctly.

s/lenght/length/

ACK with that fixed

I make no statement regarding its eligibility for the freeze (except
this one).

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, 2017-05-03 at 18:16 +0200, Ján Tomko wrote:
[...]
> > +        <description>
> > +          If this step is not performed, when the data length matches the
> > +          chunk size the decryption routines will misinterpret the last byte
> > +          of data as the padding lenght and fail to decode it correctly.
> 
> s/lenght/length/
> 
> ACK with that fixed

Good catch.

And of course I had to make a fool of myself by forgetting
to fix it before pushing :/

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list