[v1] Support multiple PHBs for pSeries guests

[libvirt] [PATCH 11/26] schema: Allow <target index='...'/>

Posted by Andrea Bolognani 7 years, 11 months ago

---
 docs/schemas/domaincommon.rng | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 4d9f8d1..cff595b 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -1996,6 +1996,11 @@
                   </attribute>
                 </optional>
                 <optional>
+                  <attribute name='index'>
+                    <ref name='uint8'/>
+                  </attribute>
+                </optional>
+                <optional>
                   <element name='node'>
                     <ref name='unsignedInt'/>
                   </element>
-- 
2.7.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 11/26] schema: Allow <target index='...'/>

Posted by Laine Stump 7 years, 11 months ago

On 06/02/2017 12:07 PM, Andrea Bolognani wrote:
> ---
>  docs/schemas/domaincommon.rng | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 4d9f8d1..cff595b 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1996,6 +1996,11 @@
>                    </attribute>
>                  </optional>
>                  <optional>
> +                  <attribute name='index'>
> +                    <ref name='uint8'/>
> +                  </attribute>
> +                </optional>
> +                <optional>
>                    <element name='node'>
>                      <ref name='unsignedInt'/>
>                    </element>
> 

I always just put the schema changes in the same patch as the
parser/formatter changes (along with documentation in
formatdomain.html.in - I know you said in your epic synopsis that you
have documentation patches planned, but in the past we've required an
addition to format*.html.in before ACKing any patch that added to the
parser/formatter/schema).

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 11/26] schema: Allow <target index='...'/>

Posted by Andrea Bolognani 7 years, 11 months ago

On Tue, 2017-06-13 at 17:53 -0400, Laine Stump wrote:
> I always just put the schema changes in the same patch as theA
> parser/formatter changes (along with documentation in
> formatdomain.html.in - I know you said in your epic synopsis that you
> have documentation patches planned, but in the past we've required an
> addition to format*.html.in before ACKing any patch that added to the
> parser/formatter/schema).

Sure, I can have it all squashed together in a single commit
in v2 if you prefer it that way.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list