[v1] Support multiple PHBs for pSeries guests

[libvirt] [PATCH 13/26] schema: Allow 'spapr-pci-host-bridge' controller model

Posted by Andrea Bolognani 7 years, 11 months ago

---
 docs/schemas/domaincommon.rng | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index cff595b..d565a0b 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -1953,6 +1953,8 @@
               <element name="model">
                 <attribute name="name">
                   <choice>
+                    <!-- implementations of 'pci-root' -->
+                    <value>spapr-pci-host-bridge</value>
                     <!-- implementations of 'pci-bridge' -->
                     <value>pci-bridge</value>
                     <!-- implementations of 'dmi-to-pci-bridge' -->
-- 
2.7.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 13/26] schema: Allow 'spapr-pci-host-bridge' controller model

Posted by Laine Stump 7 years, 11 months ago

On 06/02/2017 12:07 PM, Andrea Bolognani wrote:
> ---
>  docs/schemas/domaincommon.rng | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index cff595b..d565a0b 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1953,6 +1953,8 @@
>                <element name="model">
>                  <attribute name="name">
>                    <choice>
> +                    <!-- implementations of 'pci-root' -->
> +                    <value>spapr-pci-host-bridge</value>
>                      <!-- implementations of 'pci-bridge' -->
>                      <value>pci-bridge</value>
>                      <!-- implementations of 'dmi-to-pci-bridge' -->
> 

As with 11/26 and 12/26 - ACK to 13 & 14/26, but combined, and with a
sentence added to formatdomain.html.in *and* an xml2xml test case.

(and I assume the validation to disallow this model name for anything
other than pci-root is in a later patch?

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 13/26] schema: Allow 'spapr-pci-host-bridge' controller model

Posted by Andrea Bolognani 7 years, 11 months ago

On Tue, 2017-06-13 at 21:39 -0400, Laine Stump wrote:
> (and I assume the validation to disallow this model name for anything
> other than pci-root is in a later patch?

It's actually already in place: qemuBuildControllerDevStr()
contains whitelist-style checks that only allow eg. ioh3420
or pcie-root-port to be used as model names for a PCIe Root
Ports, so the new model name will automatically be rejected.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list