1. Patchew
  2. Libvirt
  3. [libvirt] [PATCH 00/26] Support multiple PHBs for pSeries guests
  4. View patch

[libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private

Andrea Bolognani posted 26 patches 7 years, 11 months ago
There is a newer version of this series
[libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private
Posted by Andrea Bolognani 7 years, 11 months ago 
There are no external users.
---
 src/conf/domain_addr.c   | 2 +-
 src/conf/domain_addr.h   | 5 -----
 src/libvirt_private.syms | 1 -
 3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index 639168e..9c809e8 100644
--- a/src/conf/domain_addr.c
+++ b/src/conf/domain_addr.c
@@ -362,7 +362,7 @@ virDomainPCIAddressBusSetModel(virDomainPCIAddressBusPtr bus,
  *  0 = no action performed
  * >0 = number of buses added
  */
-int
+static int
 virDomainPCIAddressSetGrow(virDomainPCIAddressSetPtr addrs,
                            virPCIDeviceAddressPtr addr,
                            virDomainPCIConnectFlags flags)
diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h
index f884b8a..efa97ca 100644
--- a/src/conf/domain_addr.h
+++ b/src/conf/domain_addr.h
@@ -145,11 +145,6 @@ bool virDomainPCIAddressSlotInUse(virDomainPCIAddressSetPtr addrs,
                                   virPCIDeviceAddressPtr addr)
     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
 
-int virDomainPCIAddressSetGrow(virDomainPCIAddressSetPtr addrs,
-                               virPCIDeviceAddressPtr addr,
-                               virDomainPCIConnectFlags flags)
-    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
-
 int virDomainPCIAddressReserveAddr(virDomainPCIAddressSetPtr addrs,
                                    virPCIDeviceAddressPtr addr,
                                    virDomainPCIConnectFlags flags)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 429b095..901cc99 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -113,7 +113,6 @@ virDomainPCIAddressReserveNextAddr;
 virDomainPCIAddressSetAllMulti;
 virDomainPCIAddressSetAlloc;
 virDomainPCIAddressSetFree;
-virDomainPCIAddressSetGrow;
 virDomainPCIAddressSlotInUse;
 virDomainPCIAddressValidate;
 virDomainPCIControllerModelToConnectType;
-- 
2.7.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private
Posted by Laine Stump 7 years, 11 months ago 
On 06/02/2017 12:07 PM, Andrea Bolognani wrote:
> There are no external users.
> ---
>  src/conf/domain_addr.c   | 2 +-
>  src/conf/domain_addr.h   | 5 -----
>  src/libvirt_private.syms | 1 -
>  3 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
> index 639168e..9c809e8 100644
> --- a/src/conf/domain_addr.c
> +++ b/src/conf/domain_addr.c
> @@ -362,7 +362,7 @@ virDomainPCIAddressBusSetModel(virDomainPCIAddressBusPtr bus,
>   *  0 = no action performed
>   * >0 = number of buses added
>   */
> -int
> +static int
>  virDomainPCIAddressSetGrow(virDomainPCIAddressSetPtr addrs,
>                             virPCIDeviceAddressPtr addr,
>                             virDomainPCIConnectFlags flags)
> diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h
> index f884b8a..efa97ca 100644
> --- a/src/conf/domain_addr.h
> +++ b/src/conf/domain_addr.h
> @@ -145,11 +145,6 @@ bool virDomainPCIAddressSlotInUse(virDomainPCIAddressSetPtr addrs,
>                                    virPCIDeviceAddressPtr addr)
>      ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
>  
> -int virDomainPCIAddressSetGrow(virDomainPCIAddressSetPtr addrs,
> -                               virPCIDeviceAddressPtr addr,
> -                               virDomainPCIConnectFlags flags)
> -    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
> -
>  int virDomainPCIAddressReserveAddr(virDomainPCIAddressSetPtr addrs,
>                                     virPCIDeviceAddressPtr addr,
>                                     virDomainPCIConnectFlags flags)
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 429b095..901cc99 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -113,7 +113,6 @@ virDomainPCIAddressReserveNextAddr;
>  virDomainPCIAddressSetAllMulti;
>  virDomainPCIAddressSetAlloc;
>  virDomainPCIAddressSetFree;
> -virDomainPCIAddressSetGrow;
>  virDomainPCIAddressSlotInUse;
>  virDomainPCIAddressValidate;
>  virDomainPCIControllerModelToConnectType;
> 

Reviewed-by: Laine Stump <laine@laine.org>

(This *is* the new hot way to say ACK, right?)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private
Posted by Ján Tomko 7 years, 11 months ago 
On Sun, Jun 11, 2017 at 10:10:39PM -0400, Laine Stump wrote:
>Reviewed-by: Laine Stump <laine@laine.org>
>
>(This *is* the new hot way to say ACK, right?)

It is not a replacement (AFAIK only rebels like John and Pavel use it)
and it is not an equivalent (with Reviewed-by, I assume the reviewer
wants me to make it a part of the commit history).

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private
Posted by Andrea Bolognani 7 years, 11 months ago 
On Mon, 2017-06-12 at 08:35 +0200, Ján Tomko wrote:
> > Reviewed-by: Laine Stump <laine@laine.org>
> > 
> > (This *is* the new hot way to say ACK, right?)
> 
> It is not a replacement (AFAIK only rebels like John and Pavel use it)
> and it is not an equivalent (with Reviewed-by, I assume the reviewer
> wants me to make it a part of the commit history).

Both ACK and R-B are perfectly acceptable ways to signal the
submitter you consider their code suitable for merging. As a
project we don't currently mandate or prefer either form, so
feel free to use the one you like best :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private
Posted by Laine Stump 7 years, 11 months ago 
On 06/12/2017 05:20 AM, Andrea Bolognani wrote:
> On Mon, 2017-06-12 at 08:35 +0200, Ján Tomko wrote:
>>> Reviewed-by: Laine Stump <laine@laine.org>
>>>  
>>> (This *is* the new hot way to say ACK, right?)
>>  
>> It is not a replacement (AFAIK only rebels like John and Pavel use it)
>> and it is not an equivalent (with Reviewed-by, I assume the reviewer
>> wants me to make it a part of the commit history).
> 
> Both ACK and R-B are perfectly acceptable ways to signal the
> submitter you consider their code suitable for merging. As a
> project we don't currently mandate or prefer either form, so
> feel free to use the one you like best :)

Yeah, I noticed the discussion awhile back and then noticed that some
people had started using it, so wasn't sure if I'd missed some memo
about "phasing it in" or something.

Personally, I like the ease/brevity of "ACK", and as for having a
Reviewed-by as part of the commit history, I have two comments: 1) I
don't care much about having *my* reviews documented in the history, but
it's sometimes useful to know who the reviewer was when it's someone
else (of course others will say the same for patches that *I* review,
so... :-)

So I'm conflicted. It seems like a good idea but takes more time. Too
bad there's not some commit hook that could search the email archives
for the message with the ACK for a patch and add a Reviewed-by to the
commit automatically...

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-8c64711

© 2016 - 2025 Red Hat, Inc.