As virtio-crypto has been supported in QEMU 2.8 and the frontend
driver has been merged in linux 4.10, so it's necessary to support
virtio-crypto in libvirt.

---
Changes since v3:
  - spilt the capabilities part into a separate patch. [Boris]
  - include Boris's virtio-crypto ccw support(PATCH 6 & 8). [Boris]
  - add the missing capabilities in caps_2.9.0.x86_64.xml. [Boris]
  - fix Indentation and missing virDomainCryptoDefFree. [Marc]

Changes since v2:
  - PATCH 1: modify docs as Martin & Boris's suggestion. [Martin & Boris]
  - PATCH 2: add the missing 'ToString'. [Martin]
  - PATCH 3: use virAsprintf instead of virBufferAsprintf. [Martin]
             remove pointless virBufferCheckError. [Martin]
  - rebase on master. [Longpeng]

Changes since v1:
  - split patch [Martin]
  - rebase on master [Martin]
  - add docs/tests/schema [Martin]
  - fix typos [Gonglei]

---
Boris Fiuczynski (2):
  qemu: virtio-crypto: add ccw support
  qemu: virtio-crypto: add test for ccw support

Longpeng(Mike) (6):
  docs: schema: Add basic documentation for the virtual
  docs: news: Add virtio-crypto devices
  conf: Parse virtio-crypto in the domain XML
  caps: Add qemu capabilities about virtio-crypto
  qemu: Implement support for 'builtin' backend for virtio-crypto
  tests: Add testcase for virtio-crypto parsing

 docs/formatdomain.html.in                          |  61 ++++++
 docs/news.xml                                      |  10 +
 docs/schemas/domaincommon.rng                      |  30 +++
 src/conf/domain_conf.c                             | 213 ++++++++++++++++++++-
 src/conf/domain_conf.h                             |  32 ++++
 src/libvirt_private.syms                           |   5 +
 src/qemu/qemu_alias.c                              |  20 ++
 src/qemu/qemu_alias.h                              |   3 +
 src/qemu/qemu_capabilities.c                       |   6 +
 src/qemu/qemu_capabilities.h                       |   4 +
 src/qemu/qemu_command.c                            | 130 +++++++++++++
 src/qemu/qemu_command.h                            |   3 +
 src/qemu/qemu_domain_address.c                     |  25 +++
 src/qemu/qemu_driver.c                             |   6 +
 src/qemu/qemu_hotplug.c                            |   1 +
 tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml    |   2 +
 tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml   |   2 +
 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml   |   2 +
 .../qemuxml2argv-virtio-crypto-builtin.xml         |  26 +++
 .../qemuxml2argv-virtio-crypto-ccw.args            |  22 +++
 .../qemuxml2argv-virtio-crypto-ccw.xml             |  16 ++
 .../qemuxml2argv-virtio-crypto.args                |  22 +++
 tests/qemuxml2argvtest.c                           |   6 +
 .../qemuxml2xmlout-virtio-crypto-builtin.xml       |  31 +++
 tests/qemuxml2xmltest.c                            |   2 +
 25 files changed, 679 insertions(+), 1 deletion(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-crypto-builtin.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-crypto-ccw.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-crypto-ccw.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-crypto.args
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-virtio-crypto-builtin.xml

-- 
1.8.3.1


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Ping...

On 2017/7/7 16:07, Longpeng(Mike) wrote:

> As virtio-crypto has been supported in QEMU 2.8 and the frontend
> driver has been merged in linux 4.10, so it's necessary to support
> virtio-crypto in libvirt.
> 
> ---
> Changes since v3:
>   - spilt the capabilities part into a separate patch. [Boris]
>   - include Boris's virtio-crypto ccw support(PATCH 6 & 8). [Boris]
>   - add the missing capabilities in caps_2.9.0.x86_64.xml. [Boris]
>   - fix Indentation and missing virDomainCryptoDefFree. [Marc]
> 
> Changes since v2:
>   - PATCH 1: modify docs as Martin & Boris's suggestion. [Martin & Boris]
>   - PATCH 2: add the missing 'ToString'. [Martin]
>   - PATCH 3: use virAsprintf instead of virBufferAsprintf. [Martin]
>              remove pointless virBufferCheckError. [Martin]
>   - rebase on master. [Longpeng]
> 
> Changes since v1:
>   - split patch [Martin]
>   - rebase on master [Martin]
>   - add docs/tests/schema [Martin]
>   - fix typos [Gonglei]
> 
> ---
> Boris Fiuczynski (2):
>   qemu: virtio-crypto: add ccw support
>   qemu: virtio-crypto: add test for ccw support
> 
> Longpeng(Mike) (6):
>   docs: schema: Add basic documentation for the virtual
>   docs: news: Add virtio-crypto devices
>   conf: Parse virtio-crypto in the domain XML
>   caps: Add qemu capabilities about virtio-crypto
>   qemu: Implement support for 'builtin' backend for virtio-crypto
>   tests: Add testcase for virtio-crypto parsing
> 
>  docs/formatdomain.html.in                          |  61 ++++++
>  docs/news.xml                                      |  10 +
>  docs/schemas/domaincommon.rng                      |  30 +++
>  src/conf/domain_conf.c                             | 213 ++++++++++++++++++++-
>  src/conf/domain_conf.h                             |  32 ++++
>  src/libvirt_private.syms                           |   5 +
>  src/qemu/qemu_alias.c                              |  20 ++
>  src/qemu/qemu_alias.h                              |   3 +
>  src/qemu/qemu_capabilities.c                       |   6 +
>  src/qemu/qemu_capabilities.h                       |   4 +
>  src/qemu/qemu_command.c                            | 130 +++++++++++++
>  src/qemu/qemu_command.h                            |   3 +
>  src/qemu/qemu_domain_address.c                     |  25 +++
>  src/qemu/qemu_driver.c                             |   6 +
>  src/qemu/qemu_hotplug.c                            |   1 +
>  tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml    |   2 +
>  tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml   |   2 +
>  tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml   |   2 +
>  .../qemuxml2argv-virtio-crypto-builtin.xml         |  26 +++
>  .../qemuxml2argv-virtio-crypto-ccw.args            |  22 +++
>  .../qemuxml2argv-virtio-crypto-ccw.xml             |  16 ++
>  .../qemuxml2argv-virtio-crypto.args                |  22 +++
>  tests/qemuxml2argvtest.c                           |   6 +
>  .../qemuxml2xmlout-virtio-crypto-builtin.xml       |  31 +++
>  tests/qemuxml2xmltest.c                            |   2 +
>  25 files changed, 679 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-crypto-builtin.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-crypto-ccw.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-crypto-ccw.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-crypto.args
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-virtio-crypto-builtin.xml
> 


-- 
Regards,
Longpeng(Mike)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 07/07/2017 04:07 AM, Longpeng(Mike) wrote:
> As virtio-crypto has been supported in QEMU 2.8 and the frontend
> driver has been merged in linux 4.10, so it's necessary to support
> virtio-crypto in libvirt.
> 
> ---

Hi Mike,

Seems like this topic has gone quiet..  Is there a v5 in the works?

Matt

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 2017/10/25 23:14, Matthew Rosato wrote:

> On 07/07/2017 04:07 AM, Longpeng(Mike) wrote:
>> As virtio-crypto has been supported in QEMU 2.8 and the frontend
>> driver has been merged in linux 4.10, so it's necessary to support
>> virtio-crypto in libvirt.
>>
>> ---
> 
> Hi Mike,
> 
> Seems like this topic has gone quiet..  Is there a v5 in the works?
> 


Hi Matt,

V5 is always in our plan, but we want to make the virtio-crypto spec (the latest
version is V20) upstream first.

I mainly work on an amazing and interesting project these two weeks, so even the
virtio-crypto spec is delayed.

I'll take some time to work on the V21 spec these days.

> Matt
> 
> 
> 


-- 
Regards,
Longpeng(Mike)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list