[v3] qemu: migration: show disks stats for nbd migration

[libvirt] [PATCH v3 REBASE 05/16] qemu: drop excessive zero-out in qemuMigrationFetchJobStatus

Posted by Nikolay Shirokovskiy 7 years, 8 months ago

qemuMonitorGetMigrationStats will do it for us anyway.
---
 src/qemu/qemu_migration.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index b7ad65d..cc42f7a 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1387,7 +1387,6 @@ qemuMigrationFetchJobStatus(virQEMUDriverPtr driver,
     if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
         return -1;
 
-    memset(&jobInfo->stats, 0, sizeof(jobInfo->stats));
     rv = qemuMonitorGetMigrationStats(priv->mon, &jobInfo->stats);
 
     if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0)
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 REBASE 05/16] qemu: drop excessive zero-out in qemuMigrationFetchJobStatus

Posted by Jiri Denemark 7 years, 8 months ago

On Thu, Aug 24, 2017 at 09:56:42 +0300, Nikolay Shirokovskiy wrote:
> qemuMonitorGetMigrationStats will do it for us anyway.
> ---
>  src/qemu/qemu_migration.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index b7ad65d..cc42f7a 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -1387,7 +1387,6 @@ qemuMigrationFetchJobStatus(virQEMUDriverPtr driver,
>      if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
>          return -1;
>  
> -    memset(&jobInfo->stats, 0, sizeof(jobInfo->stats));
>      rv = qemuMonitorGetMigrationStats(priv->mon, &jobInfo->stats);
>  
>      if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0)

ACK

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list