Various apparmor related changes (part )

[libvirt] [PATCH 12/12] apparmor, virt-aa-helper: Allow access to /sys/bus/usb/devices

Posted by Christian Ehrhardt 7 years, 4 months ago

From: Jamie Strandboge <jamie@ubuntu.com>

Required to generate correct profiles when using usb passthrough.

Bug-Ubuntu: https://bugs.launchpad.net/bugs/565691

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 examples/apparmor/usr.lib.libvirt.virt-aa-helper | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
index d63c844..de92291 100644
--- a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
+++ b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
@@ -22,6 +22,8 @@ profile virt-aa-helper /usr/{lib,lib64}/libvirt/virt-aa-helper {
   # for hostdev
   /sys/devices/ r,
   /sys/devices/** r,
+  /sys/bus/usb/devices/ r,
+  /sys/bus/usb/devices/** r,
   deny /dev/sd* r,
   deny /dev/vd* r,
   deny /dev/dm-* r,
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 12/12] apparmor, virt-aa-helper: Allow access to /sys/bus/usb/devices

Posted by Jamie Strandboge 7 years, 4 months ago

On Tue, 2017-12-19 at 16:03 +0100, Christian Ehrhardt wrote:
> From: Jamie Strandboge <jamie@ubuntu.com>
> 
> Required to generate correct profiles when using usb passthrough.
> 
> Bug-Ubuntu: https://bugs.launchpad.net/bugs/565691
> 
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  examples/apparmor/usr.lib.libvirt.virt-aa-helper | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> index d63c844..de92291 100644
> --- a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> +++ b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> @@ -22,6 +22,8 @@ profile virt-aa-helper
> /usr/{lib,lib64}/libvirt/virt-aa-helper {
>    # for hostdev
>    /sys/devices/ r,
>    /sys/devices/** r,
> +  /sys/bus/usb/devices/ r,
> +  /sys/bus/usb/devices/** r,
>    deny /dev/sd* r,
>    deny /dev/vd* r,
>    deny /dev/dm-* r,

Note that only the first rule is needed since /sys/bus/usb/devices/ is
a symlink farm (at least these days). AppArmor resolves symlinks before
applying mediation so the glob rule won't ever match anything.

+1 for first rule.

-- 
Jamie Strandboge             | http://www.canonical.com--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 12/12] apparmor, virt-aa-helper: Allow access to /sys/bus/usb/devices

Posted by intrigeri 7 years, 4 months ago

Hi,

Jamie Strandboge:
> On Tue, 2017-12-19 at 16:03 +0100, Christian Ehrhardt wrote:
>>  examples/apparmor/usr.lib.libvirt.virt-aa-helper | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
>> b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
>> index d63c844..de92291 100644
>> --- a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
>> +++ b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
>> @@ -22,6 +22,8 @@ profile virt-aa-helper
>> /usr/{lib,lib64}/libvirt/virt-aa-helper {
>>    # for hostdev
>>    /sys/devices/ r,
>>    /sys/devices/** r,
>> +  /sys/bus/usb/devices/ r,
>> +  /sys/bus/usb/devices/** r,
>>    deny /dev/sd* r,
>>    deny /dev/vd* r,
>>    deny /dev/dm-* r,

> Note that only the first rule is needed since /sys/bus/usb/devices/ is
> a symlink farm (at least these days). AppArmor resolves symlinks before
> applying mediation so the glob rule won't ever match anything.

> +1 for first rule.

+1 for the first rule as well.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2] apparmor, virt-aa-helper: Allow access to /sys/bus/usb/devices

Posted by Christian Ehrhardt 7 years, 4 months ago

From: Jamie Strandboge <jamie@ubuntu.com>

Required to generate correct profiles when using usb passthrough.

Bug-Ubuntu: https://bugs.launchpad.net/bugs/565691

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Acked-by: Jamie Strandboge <jamie@ubuntu.com>
Acked-by: Intrigeri <intrigeri@boum.org>
---
 examples/apparmor/usr.lib.libvirt.virt-aa-helper | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
index d63c844..6a6558e 100644
--- a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
+++ b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
@@ -22,6 +22,7 @@ profile virt-aa-helper /usr/{lib,lib64}/libvirt/virt-aa-helper {
   # for hostdev
   /sys/devices/ r,
   /sys/devices/** r,
+  /sys/bus/usb/devices/ r,
   deny /dev/sd* r,
   deny /dev/vd* r,
   deny /dev/dm-* r,
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] apparmor, virt-aa-helper: Allow access to /sys/bus/usb/devices

Posted by Jamie Strandboge 7 years, 4 months ago

On Wed, 2017-12-20 at 11:56 +0100, Christian Ehrhardt wrote:
> From: Jamie Strandboge <jamie@ubuntu.com>
> 
> Required to generate correct profiles when using usb passthrough.
> 
> Bug-Ubuntu: https://bugs.launchpad.net/bugs/565691
> 
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Acked-by: Jamie Strandboge <jamie@ubuntu.com>
> Acked-by: Intrigeri <intrigeri@boum.org>
> ---
>  examples/apparmor/usr.lib.libvirt.virt-aa-helper | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> index d63c844..6a6558e 100644
> --- a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> +++ b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> @@ -22,6 +22,7 @@ profile virt-aa-helper
> /usr/{lib,lib64}/libvirt/virt-aa-helper {
>    # for hostdev
>    /sys/devices/ r,
>    /sys/devices/** r,
> +  /sys/bus/usb/devices/ r,

+1 to apply

-- 
Jamie Strandboge             | http://www.canonical.com--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list