rpc: fix memleak

[libvirt] [PATCH 1/2] daemon: fix rpc event leak on error path in remoteDispatchObjectEventSend

Posted by Nikolay Shirokovskiy 7 years, 2 months ago

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
---
 src/remote/remote_daemon_dispatch.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
index fdb0a36..ea67cb7 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -4008,7 +4008,8 @@ remoteDispatchObjectEventSend(virNetServerClientPtr client,
         goto cleanup;
 
     VIR_DEBUG("Queue event %d %zu", procnr, msg->bufferLength);
-    virNetServerClientSendMessage(client, msg);
+    if (virNetServerClientSendMessage(client, msg) < 0)
+        goto cleanup;
 
     xdr_free(proc, data);
     return;
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/2] daemon: fix rpc event leak on error path in remoteDispatchObjectEventSend

Posted by Daniel P. Berrangé 7 years, 2 months ago

On Mon, Feb 26, 2018 at 02:13:49PM +0300, Nikolay Shirokovskiy wrote:
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
> ---
>  src/remote/remote_daemon_dispatch.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
> index fdb0a36..ea67cb7 100644
> --- a/src/remote/remote_daemon_dispatch.c
> +++ b/src/remote/remote_daemon_dispatch.c
> @@ -4008,7 +4008,8 @@ remoteDispatchObjectEventSend(virNetServerClientPtr client,
>          goto cleanup;
>  
>      VIR_DEBUG("Queue event %d %zu", procnr, msg->bufferLength);
> -    virNetServerClientSendMessage(client, msg);
> +    if (virNetServerClientSendMessage(client, msg) < 0)
> +        goto cleanup;
>  
>      xdr_free(proc, data);
>      return;

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/2] daemon: fix rpc event leak on error path in remoteDispatchObjectEventSend
[libvirt] [PATCH 2/2] lxc: fix rpc event leak on error path in virLXCControllerEventSend