From nobody Wed May 14 08:07:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1523979912089282.8523586949982; Tue, 17 Apr 2018 08:45:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 910F730043F6; Tue, 17 Apr 2018 15:45:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 879FE6A248; Tue, 17 Apr 2018 15:45:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 93DD6180BAD7; Tue, 17 Apr 2018 15:45:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3HFj5ng023829 for ; Tue, 17 Apr 2018 11:45:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id C1D3B58834; Tue, 17 Apr 2018 15:45:05 +0000 (UTC) Received: from mx1.redhat.com (ext-mx13.extmail.prod.ext.phx2.redhat.com [10.5.110.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B77F97F354 for ; Tue, 17 Apr 2018 15:44:21 +0000 (UTC) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF74D30043E7 for ; Tue, 17 Apr 2018 15:44:10 +0000 (UTC) Received: by mail-pf0-f195.google.com with SMTP id p15so12335525pff.11 for ; Tue, 17 Apr 2018 08:44:10 -0700 (PDT) Received: from centos.localdomain ([49.32.171.250]) by smtp.gmail.com with ESMTPSA id c201sm28984268pfb.30.2018.04.17.08.44.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Apr 2018 08:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=VwV3aA2arLiKGg4+59alReXTk8WGOa/olfkSJNSsT+A=; b=NqwcZf4XPnJHwEAtkr1E3OfuDWvca866gEpbKhQpMXSu30o3ZorkZo9RtSdymon+KV rp8byV0JxeAgByiC7twNec+Gap2mieEEZ/3wc50wgDDnJ0wP6b3z2WpDVUg9dIx67iZl 3k++BCYhlSck60q8iwyLZz3tONrAhh6WHs8Gdsv/vwd5jFykNFO0bie7so24fu87/gt9 Ms5QF+SYjxIiDkhCmx19B8twwLtQ0H7RwnLnI0QyVwpZFjZXc12A+8IL26mwzxrrz/LI Kv3C/MnhVAZiMraARhby5pLnsLakGr7C6pJvJNGA6dHXFDubigy36QbMKhI7Jm+TCXbN 2n3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=VwV3aA2arLiKGg4+59alReXTk8WGOa/olfkSJNSsT+A=; b=fffueUyOSxM1KvRTSnqaPhNmJ9HaO3me8u3oRhG69MPtHP22+r+8DR/4IoACo1upGL ZWEe3XkKWnHArVpzw2GmB3KTDfEwxRGauvGcXZk9xQZEQSdtpqOyPffBgYFFMEKT10jH 6X2oOZO88E/JeuKk1RoUWgN7iCpotjuC6cGKMnBl/Dbr28A7EJeO5grD7/yVyPAFoPpu nwbW4FVL+dN/e0jX4mP8SSNgRoWOXgXpwt/sjt9hyfeWYr0IXptcKn4HzQnhZmsRVj/1 eHt3984XlLVLoHVzb9CXy2Q2o9ydXomc44uxQeGuurTJd0iRTNS27LKu1LQ+sJHFn8vf oCqA== X-Gm-Message-State: ALQs6tDSz5gGxPrCdeYe3NLekHXL+sOqfYH1w/osUcgS9xu/qb3D+JZ6 X0NfBdNzZ5AAoNRhzv+yTCjd+w/c X-Google-Smtp-Source: AIpwx4/uWBy0g7eaq5pTSjAnaZZLX09UdoQi1dgvqpqlXtm+dHRZmiDyqykZRKfS9YKxBQ/4xP/m1Q== X-Received: by 10.98.59.207 with SMTP id w76mr2460827pfj.36.1523979850199; Tue, 17 Apr 2018 08:44:10 -0700 (PDT) From: Sukrit Bhatnagar To: libvir-list@redhat.com Date: Tue, 17 Apr 2018 04:26:22 +0530 Message-Id: <1523919386-3847-2-git-send-email-skrtbhtngr@gmail.com> In-Reply-To: <1523919386-3847-1-git-send-email-skrtbhtngr@gmail.com> References: <1523919386-3847-1-git-send-email-skrtbhtngr@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 17 Apr 2018 15:44:11 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 17 Apr 2018 15:44:11 +0000 (UTC) for IP:'209.85.192.195' DOMAIN:'mail-pf0-f195.google.com' HELO:'mail-pf0-f195.google.com' FROM:'skrtbhtngr@gmail.com' RCPT:'' X-RedHat-Spam-Score: 2.104 ** (DATE_IN_PAST_12_24, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.192.195 mail-pf0-f195.google.com 209.85.192.195 mail-pf0-f195.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.42 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v4 1/5] qemu: Escape commas for qemuBuildRomStr X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 17 Apr 2018 15:45:11 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Add comma escaping for info->romfile. Signed-off-by: Sukrit Bhatnagar --- src/qemu/qemu_command.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f864350..e7b8aa3 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -459,8 +459,10 @@ qemuBuildRomStr(virBufferPtr buf, default: break; } - if (info->romfile) - virBufferAsprintf(buf, ",romfile=3D%s", info->romfile); + if (info->romfile) { + virBufferAddLit(buf, ",romfile=3D"); + virQEMUBuildBufferEscapeComma(buf, info->romfile); + } } return 0; } --=20 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list