[libvirt] [PATCH v3 2/3] qemu: Extend the capabilities with tpm-crb device

Stefan Berger posted 3 patches 7 years ago
[libvirt] [PATCH v3 2/3] qemu: Extend the capabilities with tpm-crb device
Posted by Stefan Berger 7 years ago
QEMU on x86_64 (since v2.12) can support tpm-crb devices.
Introduce qemu capabilities for this device.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---
 src/qemu/qemu_capabilities.c                      | 5 +++++
 src/qemu/qemu_capabilities.h                      | 1 +
 tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 +
 3 files changed, 7 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 833c755..22d86da 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -473,6 +473,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
               /* 290 */
               "query-cpus-fast",
               "disk-write-cache",
+              "tpm-crb",
     );
 
 
@@ -2342,6 +2343,10 @@ const struct tpmTypeToCaps virQEMUCapsTPMModelsToCaps[] = {
         .type = VIR_DOMAIN_TPM_MODEL_TIS,
         .caps = QEMU_CAPS_DEVICE_TPM_TIS,
     },
+    {
+        .type = VIR_DOMAIN_TPM_MODEL_CRB,
+        .caps = QEMU_CAPS_DEVICE_TPM_CRB,
+    },
 };
 
 static int
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index f08cfc2..d51d710 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -457,6 +457,7 @@ typedef enum {
     /* 290 */
     QEMU_CAPS_QUERY_CPUS_FAST, /* query-cpus-fast command */
     QEMU_CAPS_DISK_WRITE_CACHE, /* qemu block frontends support write-cache param */
+    QEMU_CAPS_DEVICE_TPM_CRB, /* -device tpm-crb */
 
     QEMU_CAPS_LAST /* this must always be the last item */
 } virQEMUCapsFlags;
diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml
index d809a78..f573fb7 100644
--- a/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml
@@ -195,6 +195,7 @@
   <flag name='seccomp-blacklist'/>
   <flag name='query-cpus-fast'/>
   <flag name='disk-write-cache'/>
+  <flag name='tpm-crb'/>
   <version>2011090</version>
   <kvmVersion>0</kvmVersion>
   <microcodeVersion>390060</microcodeVersion>
-- 
2.5.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 2/3] qemu: Extend the capabilities with tpm-crb device
Posted by John Ferlan 7 years ago

On 04/26/2018 01:42 PM, Stefan Berger wrote:
> QEMU on x86_64 (since v2.12) can support tpm-crb devices.
> Introduce qemu capabilities for this device.
> 
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_capabilities.c                      | 5 +++++
>  src/qemu/qemu_capabilities.h                      | 1 +
>  tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 +
>  3 files changed, 7 insertions(+)
> 

I'll merge this with latest top...

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 2/3] qemu: Extend the capabilities with tpm-crb device
Posted by Stefan Berger 7 years ago
On 05/01/2018 09:13 AM, John Ferlan wrote:
>
> On 04/26/2018 01:42 PM, Stefan Berger wrote:
>> QEMU on x86_64 (since v2.12) can support tpm-crb devices.
>> Introduce qemu capabilities for this device.
>>
>> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>> ---
>>   src/qemu/qemu_capabilities.c                      | 5 +++++
>>   src/qemu/qemu_capabilities.h                      | 1 +
>>   tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 +
>>   3 files changed, 7 insertions(+)
>>
> I'll merge this with latest top...

Great! Thanks.

    Stefan
>
> Reviewed-by: John Ferlan <jferlan@redhat.com>
>
> John
>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list