From nobody Mon Dec 15 23:04:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528123023433156.52997986981381; Mon, 4 Jun 2018 07:37:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D446830C75D3; Mon, 4 Jun 2018 14:37:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 26CCD5C578; Mon, 4 Jun 2018 14:37:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 801061800FC1; Mon, 4 Jun 2018 14:36:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w54EaZ7i008050 for ; Mon, 4 Jun 2018 10:36:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id CE5523083326; Mon, 4 Jun 2018 14:36:35 +0000 (UTC) Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C5E15307D983 for ; Mon, 4 Jun 2018 14:36:35 +0000 (UTC) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7222830A74D3 for ; Mon, 4 Jun 2018 14:36:24 +0000 (UTC) Received: by mail-pf0-f195.google.com with SMTP id a22-v6so2950924pfo.12 for ; Mon, 04 Jun 2018 07:36:24 -0700 (PDT) Received: from centos.localdomain ([42.106.2.208]) by smtp.gmail.com with ESMTPSA id f63-v6sm23448806pfe.143.2018.06.04.07.36.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 07:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=Y8oYvAXydUCf11SqxrRRXK43DENB6q9NqWz5pFc7B+Q=; b=lq2+Z+uZk0nVFFzxZAFISyjxmFW68MHpENYSranBCobPzivjPUehdwPmv2lfa4ZenO /rirkwm0bcCsMpDAMhlFQQtXtMtDl9VzE/OOk290VXQrclJziCIso/1IZ/hpLxP/Dm9m NS25q9DCWzOkAmyVR4ofkiMXlt5pQeEAOwA2jww9ps3c0iLvZbvjA+Uj6BKftUjsDkEn I95yd3Hdp7k4y2nG3cHxqFHV15CGI3cfmRwkBFps7UtnCpbqtXikNXGd5KSfSrnu3mLD rMwljSpoESs41cLiRcYQozdobwdEY+y/6BgqIOaQtPW5KrDx2p0s+B8ks34SfMB4WxZs xm0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Y8oYvAXydUCf11SqxrRRXK43DENB6q9NqWz5pFc7B+Q=; b=PxlhXP9A7gVioS1CWWXSPPrX7d3WmNAgGcqw/drkmnzcCh3qQxjtzsi2XYjm2R976Q +flpJy7/o8QE/AzxUBAsLZUd13aR8KlWi+0Gc2zVb5ESoMxO+CLAT5L5WLuPBp5Sev/6 aRWxHJqycHJTxgVWM7LoWUWSnSh5DwCfWjrGSWKFwMNeFVXMyMJRk9vtdtUUQMM3ohyi bG+16JGCYVcaLCo/h/LWD+umZ90pOao801sBVZcP+RAZIUVS4ImVNGENAe9jEQGHkOgD VFp9F4gU/oKWseLgMz9+TOOsD1yZ1bVF+u4TBdPi4SbJGeL0hssulwOUryckpwqILwSD MeyA== X-Gm-Message-State: APt69E3VyET38ECW7Ak3+ssKz0GyaXjcfXKRNKzQJXfdcdi4k1BDfFP9 /RsFJ7kVe7S4PXk0gNa+XehrycIu X-Google-Smtp-Source: ADUXVKImQGlvFFB1YOi+aVOZ9upjbhLr6L6VwujhisLib3BjWEezN6HSFTyaEsuRsZD1nd1qoD7Vhw== X-Received: by 2002:a63:bf0b:: with SMTP id v11-v6mr4269149pgf.29.1528122983610; Mon, 04 Jun 2018 07:36:23 -0700 (PDT) From: Sukrit Bhatnagar To: libvir-list@redhat.com Date: Sun, 3 Jun 2018 13:42:00 +0530 Message-Id: <1528013536-22196-3-git-send-email-skrtbhtngr@gmail.com> In-Reply-To: <1528013536-22196-1-git-send-email-skrtbhtngr@gmail.com> References: <1528013536-22196-1-git-send-email-skrtbhtngr@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 04 Jun 2018 14:36:24 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 04 Jun 2018 14:36:24 +0000 (UTC) for IP:'209.85.192.195' DOMAIN:'mail-pf0-f195.google.com' HELO:'mail-pf0-f195.google.com' FROM:'skrtbhtngr@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.991 (DATE_IN_PAST_24_48, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.192.195 mail-pf0-f195.google.com 209.85.192.195 mail-pf0-f195.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.45 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v1 02/18] use VIR_AUTOFREE in src/util/virarptable.c X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 04 Jun 2018 14:37:02 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Modify code to use VIR_AUTOFREE macro wherever required. Signed-off-by: Sukrit Bhatnagar --- src/util/virarptable.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/util/virarptable.c b/src/util/virarptable.c index c0e90dc..f53a479 100644 --- a/src/util/virarptable.c +++ b/src/util/virarptable.c @@ -71,9 +71,8 @@ virArpTableGet(void) { int num =3D 0; int msglen; - void *nlData =3D NULL; + VIR_AUTOFREE(void *) nlData =3D NULL; virArpTablePtr table =3D NULL; - char *ipstr =3D NULL; struct nlmsghdr* nh; struct rtattr * tb[NDA_MAX+1]; =20 @@ -89,6 +88,7 @@ virArpTableGet(void) VIR_WARNINGS_NO_CAST_ALIGN for (; NLMSG_OK(nh, msglen); nh =3D NLMSG_NEXT(nh, msglen)) { VIR_WARNINGS_RESET + VIR_AUTOFREE(char *) ipstr =3D NULL; struct ndmsg *r =3D NLMSG_DATA(nh); int len =3D nh->nlmsg_len; void *addr; @@ -134,8 +134,6 @@ virArpTableGet(void) =20 if (VIR_STRDUP(table->t[num].ipaddr, ipstr) < 0) goto cleanup; - - VIR_FREE(ipstr); } =20 if (tb[NDA_LLADDR]) { @@ -155,13 +153,10 @@ virArpTableGet(void) } =20 end_of_netlink_messages: - VIR_FREE(nlData); return table; =20 cleanup: virArpTableFree(table); - VIR_FREE(ipstr); - VIR_FREE(nlData); return NULL; } =20 --=20 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list