[v3] use GNU C's cleanup attribute in src/util (batch I)

[libvirt] [PATCH v3 09/35] util: command: remove redundant include directive

Posted by Sukrit Bhatnagar 6 years, 10 months ago

The include directive for viralloc.h is added in vircommand.h
in a previous patch.

Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
---
 src/util/vircommand.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 6dab105..8681e7b 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -44,7 +44,6 @@
 
 #define __VIR_COMMAND_PRIV_H_ALLOW__
 #include "vircommandpriv.h"
-#include "viralloc.h"
 #include "virerror.h"
 #include "virutil.h"
 #include "virlog.h"
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 09/35] util: command: remove redundant include directive

Posted by Erik Skultety 6 years, 10 months ago

On Sat, Jun 30, 2018 at 02:30:13PM +0530, Sukrit Bhatnagar wrote:
> The include directive for viralloc.h is added in vircommand.h
> in a previous patch.

How about:

"viralloc.h is pulled in by vircommand.h"

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list