[v3] use GNU C's cleanup attribute in src/util (batch I)

[libvirt] [PATCH v3 06/35] util: string: introduce typedef for string

Posted by Sukrit Bhatnagar 6 years, 10 months ago

Alias virString to (char *) so that the new cleanup macros
can be used for a list of strings (char **).

Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
---
 src/util/virstring.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/util/virstring.h b/src/util/virstring.h
index 607ae66..ac930fd 100644
--- a/src/util/virstring.h
+++ b/src/util/virstring.h
@@ -26,6 +26,8 @@
 
 # include "internal.h"
 
+typedef char *virString;
+
 char **virStringSplitCount(const char *string,
                            const char *delim,
                            size_t max_tokens,
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 06/35] util: string: introduce typedef for string

Posted by Erik Skultety 6 years, 10 months ago

On Sat, Jun 30, 2018 at 02:30:10PM +0530, Sukrit Bhatnagar wrote:
> Alias virString to (char *) so that the new cleanup macros
> can be used for a list of strings (char **).
>
> Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
> ---
>  src/util/virstring.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/util/virstring.h b/src/util/virstring.h
> index 607ae66..ac930fd 100644
> --- a/src/util/virstring.h
> +++ b/src/util/virstring.h
> @@ -26,6 +26,8 @@
>
>  # include "internal.h"
>
> +typedef char *virString;
> +
>  char **virStringSplitCount(const char *string,
>                             const char *delim,
>                             size_t max_tokens,

Not a deal breaker, but I'd probably squash this into the next patch.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list