From nobody Tue May 13 11:08:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1532639122998548.8176481647566; Thu, 26 Jul 2018 14:05:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13AFF82DE; Thu, 26 Jul 2018 21:05:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCA3B5D6A5; Thu, 26 Jul 2018 21:05:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6996C3FCC1; Thu, 26 Jul 2018 21:05:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6QL4xwV024730 for ; Thu, 26 Jul 2018 17:04:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id C6A1C60177; Thu, 26 Jul 2018 21:04:59 +0000 (UTC) Received: from mx1.redhat.com (ext-mx11.extmail.prod.ext.phx2.redhat.com [10.5.110.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFF3060175 for ; Thu, 26 Jul 2018 21:04:59 +0000 (UTC) Received: from mail-pl0-f51.google.com (mail-pl0-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88B9A308403E for ; Thu, 26 Jul 2018 21:04:58 +0000 (UTC) Received: by mail-pl0-f51.google.com with SMTP id s17-v6so1342217plp.7 for ; Thu, 26 Jul 2018 14:04:58 -0700 (PDT) Received: from centos.localdomain ([42.106.3.93]) by smtp.gmail.com with ESMTPSA id z10-v6sm3279182pfh.83.2018.07.26.14.04.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 14:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=fA2/p0h+aqqveDyv27Xv0FVYGgGrwbC8EZG9m+jNopY=; b=EEQNTCYpaJ9HRrQIOlQSU5Tbur3g2xCtEroZtDaAmvDJHDiH3aUibCQKg5nlQxQokt Qv/djKgFFzCfgfft8JXE2qeUVsHO4ia8cIzYErFZQVL4z1Z3U/6XKUCA+2PBadk3Y4Ow Ekdtvdlmn6Y97kw7Xh5lgRpNU4aKmXQ/s0W6Ub/4AXVkB9eOOh1MNdN6V633gMtp5ZRl dKeURFtJf4KqptB4huhayI0sCo58wp0KsVt2LAnUyx+ovOnwJ+XhUu1Vxwg169Cg0itL DQFpjDaQKHYNshNXEU2/uDXAiTsagbZf993ARJv7axO5KGIiPbtUPjTuc9zJEg6ViGe8 iGHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=fA2/p0h+aqqveDyv27Xv0FVYGgGrwbC8EZG9m+jNopY=; b=TqTFP08UOwudjwfFGsVEttL6HQFS4/+t6W/dpfvNT4KWyuDg63zPaVmxyi9K4fYBO4 KDqj12OMwZerWXKAbhakBVxvpWr+GC4c7gWKv63WntUPR6xikk+XojHJVt13Fyob40SU hRw3frUnUdU6X2Gsb3erdaaFnwPQ2dhtIj5rQhIRCCyVZsys7O+/8doyoqznLIRsSBfH 6GpxMMVHkhmezEq2LeiPDEViAKM4y0isG6JtLCPY2aRWdlo+DCxZyzm2FVIn9Pjn+aS+ 5Zul/y3DCoxt+sSML4JsbiVGV/LL71Z55iqvoCBVKeErVqL81hBd4+exbTBpnomnDadG brwg== X-Gm-Message-State: AOUpUlFK6Ly3G2LNZq1EeBsJzZw2eeztUdnrst79LeEq4ceSWSM3Ntnq d2TlavEpHZ0LV/lp8FPF5n3OjG36 X-Google-Smtp-Source: AAOMgpfudS7tBXZ1a4r67VvCjDeE7/tYPGxhcoNuf9krrXeFrrnjO/scPS8bPK+LI9NUm1gqXUaqvw== X-Received: by 2002:a17:902:8f8c:: with SMTP id z12-v6mr3340902plo.4.1532639097776; Thu, 26 Jul 2018 14:04:57 -0700 (PDT) From: Sukrit Bhatnagar To: libvir-list@redhat.com Date: Tue, 24 Jul 2018 21:22:11 +0530 Message-Id: <1532447562-24010-11-git-send-email-skrtbhtngr@gmail.com> In-Reply-To: <1532447562-24010-1-git-send-email-skrtbhtngr@gmail.com> References: <1532447562-24010-1-git-send-email-skrtbhtngr@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 26 Jul 2018 21:04:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 26 Jul 2018 21:04:58 +0000 (UTC) for IP:'209.85.160.51' DOMAIN:'mail-pl0-f51.google.com' HELO:'mail-pl0-f51.google.com' FROM:'skrtbhtngr@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.37 * (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_WEB, SPF_PASS) 209.85.160.51 mail-pl0-f51.google.com 209.85.160.51 mail-pl0-f51.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.40 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 10/41] util: cgroup: use VIR_AUTOPTR for aggregate types X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 26 Jul 2018 21:05:21 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" By making use of GNU C's cleanup attribute handled by the VIR_AUTOPTR macro for declaring aggregate pointer variables, majority of the calls to *Free functions can be dropped, which in turn leads to getting rid of most of our cleanup sections. Signed-off-by: Sukrit Bhatnagar Reviewed-by: Erik Skultety --- src/util/vircgroup.c | 185 +++++++++++++++++++----------------------------= ---- 1 file changed, 67 insertions(+), 118 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 6f7b5b4..61fafe2 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -836,25 +836,21 @@ virCgroupGetValueForBlkDev(virCgroupPtr group, { VIR_AUTOFREE(char *) prefix =3D NULL; VIR_AUTOFREE(char *) str =3D NULL; - char **lines =3D NULL; - int ret =3D -1; + VIR_AUTOPTR(virString) lines =3D NULL; =20 if (virCgroupGetValueStr(group, controller, key, &str) < 0) - goto error; + return -1; =20 if (!(prefix =3D virCgroupGetBlockDevString(path))) - goto error; + return -1; =20 if (!(lines =3D virStringSplit(str, "\n", -1))) - goto error; + return -1; =20 if (VIR_STRDUP(*value, virStringListGetFirstWithPrefix(lines, prefix))= < 0) - goto error; + return -1; =20 - ret =3D 0; - error: - virStringListFree(lines); - return ret; + return 0; } =20 =20 @@ -1217,12 +1213,11 @@ virCgroupAddTaskController(virCgroupPtr group, pid_= t pid, int controller) static int virCgroupSetPartitionSuffix(const char *path, char **res) { - char **tokens; + VIR_AUTOPTR(virString) tokens =3D NULL; size_t i; - int ret =3D -1; =20 if (!(tokens =3D virStringSplit(path, "/", 0))) - return ret; + return -1; =20 for (i =3D 0; tokens[i] !=3D NULL; i++) { /* Whitelist the 3 top level fixed dirs @@ -1241,22 +1236,18 @@ virCgroupSetPartitionSuffix(const char *path, char = **res) !strchr(tokens[i], '.')) { if (VIR_REALLOC_N(tokens[i], strlen(tokens[i]) + strlen(".partition") + 1= ) < 0) - goto cleanup; + return -1; strcat(tokens[i], ".partition"); } =20 if (virCgroupPartitionEscape(&(tokens[i])) < 0) - goto cleanup; + return -1; } =20 if (!(*res =3D virStringListJoin((const char **)tokens, "/"))) - goto cleanup; + return -1; =20 - ret =3D 0; - - cleanup: - virStringListFree(tokens); - return ret; + return 0; } =20 =20 @@ -1277,10 +1268,10 @@ virCgroupNewPartition(const char *path, int controllers, virCgroupPtr *group) { - int ret =3D -1; VIR_AUTOFREE(char *) parentPath =3D NULL; VIR_AUTOFREE(char *) newPath =3D NULL; - virCgroupPtr parent =3D NULL; + VIR_AUTOPTR(virCgroup) parent =3D NULL; + VIR_AUTOPTR(virCgroup) tmpGroup =3D NULL; VIR_DEBUG("path=3D%s create=3D%d controllers=3D%x", path, create, controllers); =20 @@ -1315,12 +1306,11 @@ virCgroupNewPartition(const char *path, } } =20 - ret =3D 0; + return 0; + cleanup: - if (ret !=3D 0) - virCgroupFree(*group); - virCgroupFree(parent); - return ret; + VIR_STEAL_PTR(tmpGroup, *group); + return -1; } =20 =20 @@ -1502,9 +1492,9 @@ virCgroupNewMachineSystemd(const char *name, int controllers, virCgroupPtr *group) { - int ret =3D -1; int rv; - virCgroupPtr init, parent =3D NULL; + VIR_AUTOPTR(virCgroup) init =3D NULL; + VIR_AUTOPTR(virCgroup) parent =3D NULL; VIR_AUTOFREE(char *) path =3D NULL; char *offset; =20 @@ -1531,12 +1521,10 @@ virCgroupNewMachineSystemd(const char *name, =20 path =3D init->controllers[VIR_CGROUP_CONTROLLER_SYSTEMD].placement; init->controllers[VIR_CGROUP_CONTROLLER_SYSTEMD].placement =3D NULL; - virCgroupFree(init); =20 if (!path || STREQ(path, "/") || path[0] !=3D '/') { VIR_DEBUG("Systemd didn't setup its controller"); - ret =3D -2; - goto cleanup; + return -2; } =20 offset =3D path; @@ -1546,7 +1534,7 @@ virCgroupNewMachineSystemd(const char *name, NULL, controllers, &parent) < 0) - goto cleanup; + return -1; =20 =20 for (;;) { @@ -1560,11 +1548,11 @@ virCgroupNewMachineSystemd(const char *name, parent, controllers, &tmp) < 0) - goto cleanup; + return -1; =20 if (virCgroupMakeGroup(parent, tmp, true, VIR_CGROUP_NONE) < 0) { virCgroupFree(tmp); - goto cleanup; + return -1; } if (t) { *t =3D '/'; @@ -1587,10 +1575,7 @@ virCgroupNewMachineSystemd(const char *name, } } =20 - ret =3D 0; - cleanup: - virCgroupFree(parent); - return ret; + return 0; } =20 =20 @@ -1611,8 +1596,7 @@ virCgroupNewMachineManual(const char *name, int controllers, virCgroupPtr *group) { - virCgroupPtr parent =3D NULL; - int ret =3D -1; + VIR_AUTOPTR(virCgroup) parent =3D NULL; =20 VIR_DEBUG("Fallback to non-systemd setup"); if (virCgroupNewPartition(partition, @@ -1620,9 +1604,9 @@ virCgroupNewMachineManual(const char *name, controllers, &parent) < 0) { if (virCgroupNewIgnoreError()) - goto done; + return 0; =20 - goto cleanup; + return -1; } =20 if (virCgroupNewDomainPartition(parent, @@ -1630,7 +1614,7 @@ virCgroupNewMachineManual(const char *name, name, true, group) < 0) - goto cleanup; + return -1; =20 if (virCgroupAddTask(*group, pidleader) < 0) { virErrorPtr saved =3D virSaveLastError(); @@ -1642,12 +1626,7 @@ virCgroupNewMachineManual(const char *name, } } =20 - done: - ret =3D 0; - - cleanup: - virCgroupFree(parent); - return ret; + return 0; } =20 =20 @@ -2376,7 +2355,7 @@ static virOnceControl virCgroupMemoryOnce =3D VIR_ONC= E_CONTROL_INITIALIZER; static void virCgroupMemoryOnceInit(void) { - virCgroupPtr group; + VIR_AUTOPTR(virCgroup) group =3D NULL; unsigned long long int mem_unlimited =3D 0ULL; =20 if (virCgroupNew(-1, "/", NULL, -1, &group) < 0) @@ -2390,7 +2369,6 @@ virCgroupMemoryOnceInit(void) "memory.limit_in_bytes", &mem_unlimited)); cleanup: - virCgroupFree(group); virCgroupMemoryUnlimitedKB =3D mem_unlimited >> 10; } =20 @@ -2991,22 +2969,21 @@ virCgroupGetPercpuVcpuSum(virCgroupPtr group, size_t nsum, virBitmapPtr cpumap) { - int ret =3D -1; ssize_t i =3D -1; - virCgroupPtr group_vcpu =3D NULL; =20 while ((i =3D virBitmapNextSetBit(guestvcpus, i)) >=3D 0) { VIR_AUTOFREE(char *) buf =3D NULL; + VIR_AUTOPTR(virCgroup) group_vcpu =3D NULL; char *pos; unsigned long long tmp; ssize_t j; =20 if (virCgroupNewThread(group, VIR_CGROUP_THREAD_VCPU, i, false, &group_vcpu) < 0) - goto cleanup; + return -1; =20 if (virCgroupGetCpuacctPercpuUsage(group_vcpu, &buf) < 0) - goto cleanup; + return -1; =20 pos =3D buf; for (j =3D virBitmapNextSetBit(cpumap, -1); @@ -3015,18 +2992,13 @@ virCgroupGetPercpuVcpuSum(virCgroupPtr group, if (virStrToLong_ull(pos, &pos, 10, &tmp) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cpuacct parse error")); - goto cleanup; + return -1; } sum_cpu_time[j] +=3D tmp; } - - virCgroupFree(group_vcpu); } =20 - ret =3D 0; - cleanup: - virCgroupFree(group_vcpu); - return ret; + return 0; } =20 =20 @@ -3058,7 +3030,6 @@ virCgroupGetPercpuStats(virCgroupPtr group, unsigned int ncpus, virBitmapPtr guestvcpus) { - int ret =3D -1; size_t i; int need_cpus, total_cpus; char *pos; @@ -3067,7 +3038,7 @@ virCgroupGetPercpuStats(virCgroupPtr group, virTypedParameterPtr ent; int param_idx; unsigned long long cpu_time; - virBitmapPtr cpumap =3D NULL; + VIR_AUTOPTR(virBitmap) cpumap =3D NULL; =20 /* return the number of supported params */ if (nparams =3D=3D 0 && ncpus !=3D 0) { @@ -3084,21 +3055,19 @@ virCgroupGetPercpuStats(virCgroupPtr group, total_cpus =3D virBitmapSize(cpumap); =20 /* return total number of cpus */ - if (ncpus =3D=3D 0) { - ret =3D total_cpus; - goto cleanup; - } + if (ncpus =3D=3D 0) + return total_cpus; =20 if (start_cpu >=3D total_cpus) { virReportError(VIR_ERR_INVALID_ARG, _("start_cpu %d larger than maximum of %d"), start_cpu, total_cpus - 1); - goto cleanup; + return -1; } =20 /* we get percpu cputime accounting info. */ if (virCgroupGetCpuacctPercpuUsage(group, &buf)) - goto cleanup; + return -1; pos =3D buf; =20 /* return percpu cputime in index 0 */ @@ -3113,14 +3082,14 @@ virCgroupGetPercpuStats(virCgroupPtr group, } else if (virStrToLong_ull(pos, &pos, 10, &cpu_time) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cpuacct parse error")); - goto cleanup; + return -1; } if (i < start_cpu) continue; ent =3D ¶ms[(i - start_cpu) * nparams + param_idx]; if (virTypedParameterAssign(ent, VIR_DOMAIN_CPU_STATS_CPUTIME, VIR_TYPED_PARAM_ULLONG, cpu_time) < 0) - goto cleanup; + return -1; } =20 /* return percpu vcputime in index 1 */ @@ -3128,10 +3097,10 @@ virCgroupGetPercpuStats(virCgroupPtr group, =20 if (guestvcpus && param_idx < nparams) { if (VIR_ALLOC_N(sum_cpu_time, need_cpus) < 0) - goto cleanup; + return -1; if (virCgroupGetPercpuVcpuSum(group, guestvcpus, sum_cpu_time, need_cpus, cpumap) < 0) - goto cleanup; + return -1; =20 for (i =3D start_cpu; i < need_cpus; i++) { if (virTypedParameterAssign(¶ms[(i - start_cpu) * nparams + @@ -3139,17 +3108,13 @@ virCgroupGetPercpuStats(virCgroupPtr group, VIR_DOMAIN_CPU_STATS_VCPUTIME, VIR_TYPED_PARAM_ULLONG, sum_cpu_time[i]) < 0) - goto cleanup; + return -1; } =20 param_idx++; } =20 - ret =3D param_idx; - - cleanup: - virBitmapFree(cpumap); - return ret; + return param_idx; } =20 =20 @@ -3505,23 +3470,18 @@ int virCgroupKill(virCgroupPtr group, int signum) { VIR_DEBUG("group=3D%p path=3D%s signum=3D%d", group, group->path, sign= um); - int ret; /* The 'tasks' file in cgroups can contain duplicated * pids, so we use a hash to track which we've already * killed. */ - virHashTablePtr pids =3D virHashCreateFull(100, - NULL, - virCgroupPidCode, - virCgroupPidEqual, - virCgroupPidCopy, - NULL); + VIR_AUTOPTR(virHashTable) pids =3D virHashCreateFull(100, + NULL, + virCgroupPidCode, + virCgroupPidEqual, + virCgroupPidCopy, + NULL); =20 - ret =3D virCgroupKillInternal(group, signum, pids); - - virHashFree(pids); - - return ret; + return virCgroupKillInternal(group, signum, pids); } =20 =20 @@ -3536,7 +3496,6 @@ virCgroupKillRecursiveInternal(virCgroupPtr group, bool killedAny =3D false; VIR_AUTOFREE(char *) keypath =3D NULL; DIR *dp =3D NULL; - virCgroupPtr subgroup =3D NULL; struct dirent *ent; int direrr; VIR_DEBUG("group=3D%p path=3D%s signum=3D%d pids=3D%p", @@ -3561,6 +3520,8 @@ virCgroupKillRecursiveInternal(virCgroupPtr group, } =20 while ((direrr =3D virDirRead(dp, &ent, keypath)) > 0) { + VIR_AUTOPTR(virCgroup) subgroup =3D NULL; + if (ent->d_type !=3D DT_DIR) continue; =20 @@ -3577,8 +3538,6 @@ virCgroupKillRecursiveInternal(virCgroupPtr group, =20 if (dormdir) virCgroupRemove(subgroup); - - virCgroupFree(subgroup); } if (direrr < 0) goto cleanup; @@ -3587,7 +3546,6 @@ virCgroupKillRecursiveInternal(virCgroupPtr group, ret =3D killedAny ? 1 : 0; =20 cleanup: - virCgroupFree(subgroup); VIR_DIR_CLOSE(dp); return ret; } @@ -3596,20 +3554,15 @@ virCgroupKillRecursiveInternal(virCgroupPtr group, int virCgroupKillRecursive(virCgroupPtr group, int signum) { - int ret; VIR_DEBUG("group=3D%p path=3D%s signum=3D%d", group, group->path, sign= um); - virHashTablePtr pids =3D virHashCreateFull(100, - NULL, - virCgroupPidCode, - virCgroupPidEqual, - virCgroupPidCopy, - NULL); + VIR_AUTOPTR(virHashTable) pids =3D virHashCreateFull(100, + NULL, + virCgroupPidCode, + virCgroupPidEqual, + virCgroupPidCopy, + NULL); =20 - ret =3D virCgroupKillRecursiveInternal(group, signum, pids, false); - - virHashFree(pids); - - return ret; + return virCgroupKillRecursiveInternal(group, signum, pids, false); } =20 =20 @@ -3944,15 +3897,12 @@ virCgroupHasEmptyTasks(virCgroupPtr cgroup, int con= troller) bool virCgroupControllerAvailable(int controller) { - virCgroupPtr cgroup; - bool ret =3D false; + VIR_AUTOPTR(virCgroup) cgroup =3D NULL; =20 if (virCgroupNewSelf(&cgroup) < 0) - return ret; + return false; =20 - ret =3D virCgroupHasController(cgroup, controller); - virCgroupFree(cgroup); - return ret; + return virCgroupHasController(cgroup, controller); } =20 #else /* !VIR_CGROUP_SUPPORTED */ @@ -4740,7 +4690,7 @@ virCgroupDelThread(virCgroupPtr cgroup, virCgroupThreadName nameval, int idx) { - virCgroupPtr new_cgroup =3D NULL; + VIR_AUTOPTR(virCgroup) new_cgroup =3D NULL; =20 if (cgroup) { if (virCgroupNewThread(cgroup, nameval, idx, false, &new_cgroup) <= 0) @@ -4748,7 +4698,6 @@ virCgroupDelThread(virCgroupPtr cgroup, =20 /* Remove the offlined cgroup */ virCgroupRemove(new_cgroup); - virCgroupFree(new_cgroup); } =20 return 0; --=20 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list