[libvirt] [PATCH v2 00/35] use GNU C's cleanup attribute in src/util (batch III)

Sukrit Bhatnagar posted 35 patches 5 years, 8 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
src/util/viriscsi.c             | 140 ++++------
src/util/virmacaddr.c           |   6 +
src/util/virmacaddr.h           |   4 +
src/util/virnetdev.c            | 604 ++++++++++++++++------------------------
src/util/virnetdev.h            |   4 +
src/util/virnetdevbridge.c      |  81 ++----
src/util/virnetdevip.c          | 227 ++++++---------
src/util/virnetdevip.h          |   5 +
src/util/virnetdevmacvlan.c     |  22 +-
src/util/virnetdevopenvswitch.c |  98 +++----
src/util/virnetdevtap.c         |  11 +-
src/util/virnetdevveth.c        |  32 +--
src/util/virnetlink.c           | 118 ++++----
src/util/virnetlink.h           |   5 +
src/util/virnuma.c              | 103 +++----
src/util/virperf.c              |  20 +-
src/util/virperf.h              |   8 +-
src/util/virpidfile.c           | 186 ++++---------
src/util/virprocess.c           |  58 ++--
src/util/virqemu.c              |  31 +--
src/util/virsocketaddr.c        | 113 ++++----
src/util/virsocketaddr.h        |   9 +-
22 files changed, 730 insertions(+), 1155 deletions(-)
[libvirt] [PATCH v2 00/35] use GNU C's cleanup attribute in src/util (batch III)
Posted by Sukrit Bhatnagar 5 years, 8 months ago
This third series of patches also modifies a few files in src/util
to use VIR_AUTOFREE and VIR_AUTOPTR for automatic freeing of memory
and get rid of some VIR_FREE macro invocations and *Free function
calls.

Sukrit Bhatnagar (35):
  util: iscsi: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: iscsi: use VIR_AUTOPTR for aggregate types
  util: netlink: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
  util: netlink: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: netlink: use VIR_AUTOPTR for aggregate types
  util: netdevbridge: use VIR_AUTOFREE instead of VIR_FREE for scalar
    types
  util: netdevbridge: use VIR_AUTOPTR for aggregate types
  util: macaddr: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
  util: netdev: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
  util: netdev: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: netdev: use VIR_AUTOPTR for aggregate types
  util: socketaddr: define cleanup function using
    VIR_DEFINE_AUTOPTR_FUNC
  util: socketaddr: use VIR_AUTOFREE instead of VIR_FREE for scalar
    types
  util: socketaddr: use VIR_AUTOPTR for aggregate types
  util: netdevip: define virNetDevIPAddrFree for use with cleanup macros
  util: netdevip: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
  util: netdevip: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: netdevip: use VIR_AUTOPTR for aggregate types
  util: netdevmacvlan: define cleanup function using
    VIR_DEFINE_AUTOPTR_FUNC
  util: netdevmacvlan: use VIR_AUTOFREE instead of VIR_FREE for scalar
    types
  util: netdevmacvlan: use VIR_AUTOPTR for aggregate types
  util: netdevopenvswitch: use VIR_AUTOFREE instead of VIR_FREE for
    scalar types
  util: netdevopenvswitch: use VIR_AUTOPTR for aggregate types
  util: netdevtap: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: netdevveth: use VIR_AUTOFREE instead of VIR_FREE for scalar
    types
  util: netdevveth: use VIR_AUTOPTR for aggregate types
  util: numa: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: numa: use VIR_AUTOPTR for aggregate types
  util: perf: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
  util: perf: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: pidfile: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: process: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: process: use VIR_AUTOPTR for aggregate types
  util: qemu: use VIR_AUTOFREE instead of VIR_FREE for scalar types
  util: qemu: use VIR_AUTOPTR for aggregate types

 src/util/viriscsi.c             | 140 ++++------
 src/util/virmacaddr.c           |   6 +
 src/util/virmacaddr.h           |   4 +
 src/util/virnetdev.c            | 604 ++++++++++++++++------------------------
 src/util/virnetdev.h            |   4 +
 src/util/virnetdevbridge.c      |  81 ++----
 src/util/virnetdevip.c          | 227 ++++++---------
 src/util/virnetdevip.h          |   5 +
 src/util/virnetdevmacvlan.c     |  22 +-
 src/util/virnetdevopenvswitch.c |  98 +++----
 src/util/virnetdevtap.c         |  11 +-
 src/util/virnetdevveth.c        |  32 +--
 src/util/virnetlink.c           | 118 ++++----
 src/util/virnetlink.h           |   5 +
 src/util/virnuma.c              | 103 +++----
 src/util/virperf.c              |  20 +-
 src/util/virperf.h              |   8 +-
 src/util/virpidfile.c           | 186 ++++---------
 src/util/virprocess.c           |  58 ++--
 src/util/virqemu.c              |  31 +--
 src/util/virsocketaddr.c        | 113 ++++----
 src/util/virsocketaddr.h        |   9 +-
 22 files changed, 730 insertions(+), 1155 deletions(-)

-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 00/35] use GNU C's cleanup attribute in src/util (batch III)
Posted by Erik Skultety 5 years, 8 months ago
On Mon, Aug 06, 2018 at 02:13:27AM +0530, Sukrit Bhatnagar wrote:
> This third series of patches also modifies a few files in src/util
> to use VIR_AUTOFREE and VIR_AUTOPTR for automatic freeing of memory
> and get rid of some VIR_FREE macro invocations and *Free function
> calls.

This will clearly not apply on top the current master since most of the patches
were already merged in some (updated) form, thus any other necessary
changes/adjustments need to be covered by a follow-up series built on top of
the current master. Also, there's something wrong with your system time, since
git send-email overwrote the time stamp of the patches to 5th of August, it
just looks weird on the list.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list