[v3] use GNU C's cleanup attribute in src/util (batch III)

[libvirt] [PATCH v3 11/11] util: qemu: use VIR_AUTOPTR for aggregate types

Posted by Sukrit Bhatnagar 6 years, 11 months ago

By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.

Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
---
 src/util/virqemu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/util/virqemu.c b/src/util/virqemu.c
index bc78853..1cd2b93 100644
--- a/src/util/virqemu.c
+++ b/src/util/virqemu.c
@@ -281,6 +281,7 @@ virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr srcdef)
  cleanup:
     virBufferFreeAndReset(&buf);
     return ret;
+
 }
 
 
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 11/11] util: qemu: use VIR_AUTOPTR for aggregate types

Posted by Erik Skultety 6 years, 11 months ago

On Thu, Aug 09, 2018 at 09:42:19AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of our cleanup sections.
>
> Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
> ---
>  src/util/virqemu.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/util/virqemu.c b/src/util/virqemu.c
> index bc78853..1cd2b93 100644
> --- a/src/util/virqemu.c
> +++ b/src/util/virqemu.c
> @@ -281,6 +281,7 @@ virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr srcdef)
>   cleanup:
>      virBufferFreeAndReset(&buf);
>      return ret;
> +

I'm sure you wanted to add some more into the commit, right? :)

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 11/11] util: qemu: use VIR_AUTOPTR for aggregate types

Posted by Sukrit Bhatnagar 6 years, 11 months ago

My bad. You can ignore this patch.
On Thu, 9 Aug 2018 at 18:18, Erik Skultety <eskultet@redhat.com> wrote:
>
> On Thu, Aug 09, 2018 at 09:42:19AM +0530, Sukrit Bhatnagar wrote:
> > By making use of GNU C's cleanup attribute handled by the
> > VIR_AUTOPTR macro for declaring aggregate pointer variables,
> > majority of the calls to *Free functions can be dropped, which
> > in turn leads to getting rid of most of our cleanup sections.
> >
> > Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
> > ---
> >  src/util/virqemu.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/util/virqemu.c b/src/util/virqemu.c
> > index bc78853..1cd2b93 100644
> > --- a/src/util/virqemu.c
> > +++ b/src/util/virqemu.c
> > @@ -281,6 +281,7 @@ virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr srcdef)
> >   cleanup:
> >      virBufferFreeAndReset(&buf);
> >      return ret;
> > +
>
> I'm sure you wanted to add some more into the commit, right? :)
>
> Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list