From nobody Wed Feb 11 07:10:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1493211860005566.5640190841638; Wed, 26 Apr 2017 06:04:20 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D052380F99; Wed, 26 Apr 2017 13:04:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72E3888841; Wed, 26 Apr 2017 13:04:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F3179410B1; Wed, 26 Apr 2017 13:04:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v3QD488c003211 for ; Wed, 26 Apr 2017 09:04:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id 810DD18C46; Wed, 26 Apr 2017 13:04:08 +0000 (UTC) Received: from angien.brq.redhat.com (dhcp129-47.brq.redhat.com [10.34.129.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id D749993290; Wed, 26 Apr 2017 13:04:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D052380F99 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D052380F99 From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 26 Apr 2017 15:03:58 +0200 Message-Id: <1750939d6ab4170c40f8c4f0e167c4d3a8d439ad.1493211777.git.pkrempa@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Peter Krempa Subject: [libvirt] [PATCH 2/4] qemu: process: Don't leak priv->usbaddrs after VM restart X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 26 Apr 2017 13:04:18 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since the private data structure is not freed upon stopping a VM, the usbaddrs pointer would be leaked: =3D=3D15388=3D=3D 136 (16 direct, 120 indirect) bytes in 1 blocks are defin= itely lost in loss record 893 of 1,019 =3D=3D15388=3D=3D at 0x4C2CF55: calloc (vg_replace_malloc.c:711) =3D=3D15388=3D=3D by 0x54BF64A: virAlloc (viralloc.c:144) =3D=3D15388=3D=3D by 0x5547588: virDomainUSBAddressSetCreate (domain_add= r.c:1608) =3D=3D15388=3D=3D by 0x144D38A2: qemuDomainAssignUSBAddresses (qemu_doma= in_address.c:2458) =3D=3D15388=3D=3D by 0x144D38A2: qemuDomainAssignAddresses (qemu_domain_= address.c:2515) =3D=3D15388=3D=3D by 0x144ED1E3: qemuProcessPrepareDomain (qemu_process.= c:5398) =3D=3D15388=3D=3D by 0x144F51FF: qemuProcessStart (qemu_process.c:5979) [...] --- src/qemu/qemu_process.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index e44359575..6787c47cf 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6441,6 +6441,10 @@ void qemuProcessStop(virQEMUDriverPtr driver, virBitmapFree(priv->autoCpuset); priv->autoCpuset =3D NULL; + /* remove address data */ + virDomainUSBAddressSetFree(priv->usbaddrs); + priv->usbaddrs =3D NULL; + /* The "release" hook cleans up additional resources */ if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) { char *xml =3D qemuDomainDefFormatXML(driver, vm->def, 0); --=20 2.12.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list