From nobody Wed May 14 16:48:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520871734889495.09191590583873; Mon, 12 Mar 2018 09:22:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D1FD185543; Mon, 12 Mar 2018 16:22:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D6D360C80; Mon, 12 Mar 2018 16:22:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4E8924CAA6; Mon, 12 Mar 2018 16:22:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CGLwt0025055 for ; Mon, 12 Mar 2018 12:21:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id 062672166BB2; Mon, 12 Mar 2018 16:21:58 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id A10FD215CDAE for ; Mon, 12 Mar 2018 16:21:57 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:21:44 +0100 Message-Id: <1c0562d95c71bbb4cb300715042397789984171d.1520871530.git.phrdina@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 14/18] connect: parse message arguments as first thing X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 12 Mar 2018 16:22:13 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" There is no need to open connection if parsing arguments fails. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- src/connect.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/connect.c b/src/connect.c index b31f08e..695fc0d 100644 --- a/src/connect.c +++ b/src/connect.c @@ -120,11 +120,11 @@ virtDBusConnectListDomains(sd_bus_message *message, uint32_t flags; int r; =20 - r =3D virtDBusConnectOpen(connect, error); + r =3D sd_bus_message_read(message, "u", &flags); if (r < 0) return r; =20 - r =3D sd_bus_message_read(message, "u", &flags); + r =3D virtDBusConnectOpen(connect, error); if (r < 0) return r; =20 @@ -170,11 +170,11 @@ virtDBusConnectCreateXML(sd_bus_message *message, _cleanup_(virtDBusUtilFreep) char *path =3D NULL; int r; =20 - r =3D virtDBusConnectOpen(connect, error); + r =3D sd_bus_message_read(message, "su", &xml, &flags); if (r < 0) return r; =20 - r =3D sd_bus_message_read(message, "su", &xml, &flags); + r =3D virtDBusConnectOpen(connect, error); if (r < 0) return r; =20 @@ -198,11 +198,11 @@ virtDBusConnectDefineXML(sd_bus_message *message, _cleanup_(virtDBusUtilFreep) char *path =3D NULL; int r; =20 - r =3D virtDBusConnectOpen(connect, error); + r =3D sd_bus_message_read(message, "s", &xml); if (r < 0) return r; =20 - r =3D sd_bus_message_read(message, "s", &xml); + r =3D virtDBusConnectOpen(connect, error); if (r < 0) return r; =20 --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list