From nobody Wed Feb 11 10:18:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.39 as permitted sender) client-ip=209.132.183.39; envelope-from=libvir-list-bounces@redhat.com; helo=mx6-phx2.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.39 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx6-phx2.redhat.com (mx6-phx2.redhat.com [209.132.183.39]) by mx.zohomail.com with SMTPS id 1489596940779718.4655942303242; Wed, 15 Mar 2017 09:55:40 -0700 (PDT) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2FGqQbv025552; Wed, 15 Mar 2017 12:52:26 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v2FGqPqD026977 for ; Wed, 15 Mar 2017 12:52:25 -0400 Received: from vhost2.laine.org (ovpn-116-93.phx2.redhat.com [10.3.116.93]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2FGqOdv014588 for ; Wed, 15 Mar 2017 12:52:25 -0400 From: Laine Stump To: libvir-list@redhat.com Date: Wed, 15 Mar 2017 12:52:21 -0400 Message-Id: <20170315165221.12479-1-laine@laine.org> In-Reply-To: <20170310203512.15478-1-laine@laine.org> References: <20170310203512.15478-1-laine@laine.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 21/19] util: log all setting of MAC addresses and vlan tags X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Having this information available will make it easier to determine the culprit when MAC or vlan tag appear to not be set, eg.: https://bugzilla.redhat.com/1364073 (This patch doesn't fix that bug, just makes it easier to diagnose) --- src/util/virnetdev.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 664a75d..86ae0d1 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -240,6 +240,7 @@ virNetDevSetMACInternal(const char *ifname, int fd =3D -1; int ret =3D -1; struct ifreq ifr; + char macstr[VIR_MAC_STRING_BUFLEN]; =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -255,7 +256,6 @@ virNetDevSetMACInternal(const char *ifname, virMacAddrGetRaw(macaddr, (unsigned char *)ifr.ifr_hwaddr.sa_data); =20 if (ioctl(fd, SIOCSIFHWADDR, &ifr) < 0) { - char macstr[VIR_MAC_STRING_BUFLEN]; =20 if (quiet && errno =3D=3D EADDRNOTAVAIL) goto cleanup; @@ -269,6 +269,10 @@ virNetDevSetMACInternal(const char *ifname, ret =3D 0; =20 cleanup: + VIR_DEBUG("SIOCSIFHWADDR %s MAC=3D%s - %s", + ifname, virMacAddrFormat(macaddr, macstr), + ret < 0 ? "Fail" : "Success"); + VIR_FORCE_CLOSE(fd); return ret; } @@ -311,6 +315,9 @@ virNetDevSetMACInternal(const char *ifname, =20 ret =3D 0; cleanup: + VIR_DEBUG("SIOCSIFLLADDR %s MAC=3D%s - %s", ifname, mac + 1), + ret < 0 ? "Fail" : "Success"); + VIR_FORCE_CLOSE(s); =20 return ret; @@ -1435,6 +1442,7 @@ virNetDevSetVfConfig(const char *ifname, int vf, bool *allowRetry) { int rc =3D -1; + char macstr[VIR_MAC_STRING_BUFLEN]; struct nlmsghdr *resp =3D NULL; struct nlmsgerr *err; unsigned int recvbuflen =3D 0; @@ -1518,8 +1526,6 @@ virNetDevSetVfConfig(const char *ifname, int vf, goto cleanup; } else if (err->error) { /* other errors are permanent */ - char macstr[VIR_MAC_STRING_BUFLEN]; - virReportSystemError(-err->error, _("Cannot set interface MAC/vlanid to %s/= %d " "for ifname %s vf %d"), @@ -1543,6 +1549,11 @@ virNetDevSetVfConfig(const char *ifname, int vf, =20 rc =3D 0; cleanup: + VIR_DEBUG("RTM_SETLINK %s vf %d MAC=3D%s vlanid=3D%d - %s", + ifname, vf, + macaddr ? virMacAddrFormat(macaddr, macstr) : "(unchanged)", + vlanid, rc < 0 ? "Fail" : "Success"); + nlmsg_free(nl_msg); VIR_FREE(resp); return rc; --=20 2.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list