[libvirt] [PATCH 16/16] network: Privatize virNetworkObj

John Ferlan posted 16 patches 8 years, 6 months ago
There is a newer version of this series
[libvirt] [PATCH 16/16] network: Privatize virNetworkObj
Posted by John Ferlan 8 years, 6 months ago
Move from virnetworkobj.h into virnetworkobj.c

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 src/conf/virnetworkobj.c | 21 +++++++++++++++++++++
 src/conf/virnetworkobj.h | 20 --------------------
 2 files changed, 21 insertions(+), 20 deletions(-)

diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c
index cc45a00..93a16e8 100644
--- a/src/conf/virnetworkobj.c
+++ b/src/conf/virnetworkobj.c
@@ -37,6 +37,27 @@ VIR_LOG_INIT("conf.virnetworkobj");
 /* currently, /sbin/tc implementation allows up to 16 bits for minor class size */
 #define CLASS_ID_BITMAP_SIZE (1<<16)
 
+struct _virNetworkObj {
+    virObjectLockable parent;
+
+    pid_t dnsmasqPid;
+    pid_t radvdPid;
+    bool active;
+    int autostart;
+    bool persistent;
+
+    virNetworkDefPtr def; /* The current definition */
+    virNetworkDefPtr newDef; /* New definition to activate at shutdown */
+
+    virBitmapPtr classIdMap; /* bitmap of class IDs for QoS */
+    unsigned long long floor_sum; /* sum of all 'floor'-s of attached NICs */
+
+    unsigned int taint;
+
+    /* Immutable pointer, self locking APIs */
+    virMacMapPtr macmap;
+};
+
 struct _virNetworkObjList {
     virObjectLockable parent;
 
diff --git a/src/conf/virnetworkobj.h b/src/conf/virnetworkobj.h
index 72afbcd..ec12307 100644
--- a/src/conf/virnetworkobj.h
+++ b/src/conf/virnetworkobj.h
@@ -26,26 +26,6 @@
 
 typedef struct _virNetworkObj virNetworkObj;
 typedef virNetworkObj *virNetworkObjPtr;
-struct _virNetworkObj {
-    virObjectLockable parent;
-
-    pid_t dnsmasqPid;
-    pid_t radvdPid;
-    bool active;
-    int autostart;
-    bool persistent;
-
-    virNetworkDefPtr def; /* The current definition */
-    virNetworkDefPtr newDef; /* New definition to activate at shutdown */
-
-    virBitmapPtr classIdMap; /* bitmap of class IDs for QoS */
-    unsigned long long floor_sum; /* sum of all 'floor'-s of attached NICs */
-
-    unsigned int taint;
-
-    /* Immutable pointer, self locking APIs */
-    virMacMapPtr macmap;
-};
 
 virNetworkObjPtr
 virNetworkObjNew(virNetworkDefPtr def);
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 16/16] network: Privatize virNetworkObj
Posted by Pavel Hrdina 8 years, 4 months ago
On Fri, May 19, 2017 at 09:03:24AM -0400, John Ferlan wrote:
> Move from virnetworkobj.h into virnetworkobj.c
> 
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
>  src/conf/virnetworkobj.c | 21 +++++++++++++++++++++
>  src/conf/virnetworkobj.h | 20 --------------------
>  2 files changed, 21 insertions(+), 20 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list