util: fix virfcp build on non-Linux

[libvirt] [PATCH] util: fix virfcp build on non-Linux

Posted by Roman Bogorodskiy 7 years, 11 months ago

 - Include virerror.h for virReportSystemError
 - Rename stub functions to match original function names
---
Pushed under the build breaker rule.

 src/util/virfcp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/util/virfcp.c b/src/util/virfcp.c
index 3c7fab917..7660ba720 100644
--- a/src/util/virfcp.c
+++ b/src/util/virfcp.c
@@ -26,6 +26,7 @@
 
 #include "viralloc.h"
 #include "virfile.h"
+#include "virerror.h"
 #include "virstring.h"
 
 #include "virfcp.h"
@@ -80,14 +81,14 @@ virFCReadRportValue(const char *rport,
 #else
 
 bool
-virSysfsIsCapableFCRport(const char *rport ATTRIBUTE_UNUSED)
+virFCIsCapableRport(const char *rport ATTRIBUTE_UNUSED)
 {
     virReportSystemError(ENOSYS, "%s", _("Not supported on this platform"));
     return false;
 }
 
 int
-virSysfsReadFCRport(const char *rport ATTRIBUTE_UNUSED,
+virFCReadRportValue(const char *rport ATTRIBUTE_UNUSED,
                     const char *entry ATTRIBUTE_UNUSED,
                     char **result ATTRIBUTE_UNUSED)
 {
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix virfcp build on non-Linux

Posted by John Ferlan 7 years, 11 months ago


On 05/26/2017 12:05 PM, Roman Bogorodskiy wrote:
>  - Include virerror.h for virReportSystemError
>  - Rename stub functions to match original function names
> ---
> Pushed under the build breaker rule.
> 
>  src/util/virfcp.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Thanks - some day I'll tire of wearing the pink bunny ears of shame or
will learn after trying walk through the same plate glass window again.

John

> diff --git a/src/util/virfcp.c b/src/util/virfcp.c
> index 3c7fab917..7660ba720 100644
> --- a/src/util/virfcp.c
> +++ b/src/util/virfcp.c
> @@ -26,6 +26,7 @@
>  
>  #include "viralloc.h"
>  #include "virfile.h"
> +#include "virerror.h"
>  #include "virstring.h"
>  
>  #include "virfcp.h"
> @@ -80,14 +81,14 @@ virFCReadRportValue(const char *rport,
>  #else
>  
>  bool
> -virSysfsIsCapableFCRport(const char *rport ATTRIBUTE_UNUSED)
> +virFCIsCapableRport(const char *rport ATTRIBUTE_UNUSED)
>  {
>      virReportSystemError(ENOSYS, "%s", _("Not supported on this platform"));
>      return false;
>  }
>  
>  int
> -virSysfsReadFCRport(const char *rport ATTRIBUTE_UNUSED,
> +virFCReadRportValue(const char *rport ATTRIBUTE_UNUSED,
>                      const char *entry ATTRIBUTE_UNUSED,
>                      char **result ATTRIBUTE_UNUSED)
>  {
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix virfcp build on non-Linux

Posted by Bjoern Walk 7 years, 11 months ago

Roman Bogorodskiy <bogorodskiy@gmail.com> [2017-05-26, 08:05PM +0400]:
> - Include virerror.h for virReportSystemError
> - Rename stub functions to match original function names
>---
>Pushed under the build breaker rule.
>
> src/util/virfcp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/src/util/virfcp.c b/src/util/virfcp.c
>index 3c7fab917..7660ba720 100644
>--- a/src/util/virfcp.c
>+++ b/src/util/virfcp.c
>@@ -26,6 +26,7 @@
>
> #include "viralloc.h"
> #include "virfile.h"
>+#include "virerror.h"
> #include "virstring.h"
>
> #include "virfcp.h"
>@@ -80,14 +81,14 @@ virFCReadRportValue(const char *rport,
> #else
>
> bool
>-virSysfsIsCapableFCRport(const char *rport ATTRIBUTE_UNUSED)
>+virFCIsCapableRport(const char *rport ATTRIBUTE_UNUSED)
> {
>     virReportSystemError(ENOSYS, "%s", _("Not supported on this platform"));
>     return false;
> }
>
> int
>-virSysfsReadFCRport(const char *rport ATTRIBUTE_UNUSED,
>+virFCReadRportValue(const char *rport ATTRIBUTE_UNUSED,
>                     const char *entry ATTRIBUTE_UNUSED,
>                     char **result ATTRIBUTE_UNUSED)
> {
>-- 
>2.13.0
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
>

Oops, thank you. Will have to look out for this in the future.

Bjoern

-- 
IBM Systems
Linux on z Systems & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland
Schönaicher Str. 220
71032 Böblingen
Phone: +49 7031 16 1819
E-Mail: bwalk@de.ibm.com
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list